[PR #1664] [FEAT] Migrate detect_stream_type() from C to Rust #2370

Open
opened 2026-01-29 17:21:47 +00:00 by claunia · 0 comments
Owner

Original Pull Request: https://github.com/CCExtractor/ccextractor/pull/1664

State: closed
Merged: No


In raising this pull request, I confirm the following (please check boxes):

  • I have read and understood the contributors guide.
  • I have checked that another pull request for this purpose does not exist.
  • I have considered, and confirmed that this submission will be valuable to others.
  • I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  • I give this submission freely, and claim no ownership to its content.
  • I have mentioned this change in the changelog.

My familiarity with the project is as follows (check one):

  • I have never used CCExtractor.
  • I have used CCExtractor just a couple of times.
  • I absolutely love CCExtractor, but have not contributed previously.
  • I am an active contributor to CCExtractor(hopefully)

This PR tries to migrate the C function detect_stream_type()(src/lib_ccx/stream_functions.c) that handles the detection of video container to its pure Rust equivalent detect_stream_type(ctx: &mut CcxDemuxer) (src/rust/lib_ccxr/src/util/stream_detector.rs).
This migration follows Rust_migration_guide

**Original Pull Request:** https://github.com/CCExtractor/ccextractor/pull/1664 **State:** closed **Merged:** No --- <!-- Please prefix your pull request with one of the following: **[FEATURE]** **[FIX]** **[IMPROVEMENT]**. --> **In raising this pull request, I confirm the following (please check boxes):** - [x] I have read and understood the [contributors guide](https://github.com/CCExtractor/ccextractor/blob/master/.github/CONTRIBUTING.md). - [x] I have checked that another pull request for this purpose does not exist. - [x] I have considered, and confirmed that this submission will be valuable to others. - [x] I accept that this submission may not be used, and the pull request closed at the will of the maintainer. - [x] I give this submission freely, and claim no ownership to its content. - [ ] **I have mentioned this change in the [changelog](https://github.com/CCExtractor/ccextractor/blob/master/docs/CHANGES.TXT).** **My familiarity with the project is as follows (check one):** - [ ] I have never used CCExtractor. - [ ] I have used CCExtractor just a couple of times. - [ ] I absolutely love CCExtractor, but have not contributed previously. - [x] I am an active contributor to CCExtractor(hopefully) --- This PR tries to migrate the C function `detect_stream_type()`(`src/lib_ccx/stream_functions.c`) that handles the detection of video container to its pure Rust equivalent `detect_stream_type(ctx: &mut CcxDemuxer)` (`src/rust/lib_ccxr/src/util/stream_detector.rs`). This migration follows [Rust_migration_guide](https://github.com/CCExtractor/ccextractor/blob/master/docs/Rust_migration_guide.md)
claunia added the pull-request label 2026-01-29 17:21:47 +00:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/ccextractor#2370