mirror of
https://github.com/CCExtractor/ccextractor.git
synced 2026-02-14 21:23:42 +00:00
[CEA-708] Discoloration in the captions #238
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @Izaron on GitHub (Jan 11, 2017).
In CEA-708 we have subtitle color for each row (subtitle line)
Often the color disappears from the expected line. We get all the colors in function SetPenColor in fg_color (as far I tested) but often it is assigned to the wrong row number of window, percentage of confusion depends on example video. It's necessary to correct the confusion.
Result:
Expected:
^ In this example all the colors is equals to 42 (fg_color == 42), but there are blank lines anyway.
File HISTW.ts from samples
@Izaron commented on GitHub (Jan 12, 2017):
@cfsmp3 After reading the documentation and code I think I found a mistake. Pen colors and attributions are independent from line number, but in current master we storing it for the whole lines. There are the real fg_color changing in SetPenColor (wrote small subprogram): korean.txt (yellow color for first line as in 708 player), usa.txt, histw.txt - almost all text is gray.
Same thing with SetPenAttributes - we can have italicised only one word in the line, but have either full italicised line or full not italicised
I have to rewrite code architecture - single pen for single window as it is written in the documentation