[CEA-708] Discoloration in the captions #238

Closed
opened 2026-01-29 16:38:39 +00:00 by claunia · 1 comment
Owner

Originally created by @Izaron on GitHub (Jan 11, 2017).

In CEA-708 we have subtitle color for each row (subtitle line)
Often the color disappears from the expected line. We get all the colors in function SetPenColor in fg_color (as far I tested) but often it is assigned to the wrong row number of window, percentage of confusion depends on example video. It's necessary to correct the confusion.

Result:

38
00:02:37,307 --> 00:02:38,608
<font color="aaaaaa">When you've been making         </font>
delicious natural cheese        

Expected:

38
00:02:37,307 --> 00:02:38,608
<font color="aaaaaa">When you've been making         </font>
<font color="aaaaaa">delicious natural cheese        </font>

^ In this example all the colors is equals to 42 (fg_color == 42), but there are blank lines anyway.
File HISTW.ts from samples

Originally created by @Izaron on GitHub (Jan 11, 2017). In CEA-708 we have subtitle color for each row (subtitle line) Often the color disappears from the expected line. We get all the colors in function [SetPenColor](https://en.wikipedia.org/wiki/CEA-708#SetPenColor_.280x91_.2B_3_bytes.29) in fg_color (as far I tested) but often it is assigned to the wrong row number of window, percentage of confusion depends on example video. It's necessary to correct the confusion. Result: ``` 38 00:02:37,307 --> 00:02:38,608 <font color="aaaaaa">When you've been making </font> delicious natural cheese ``` Expected: ``` 38 00:02:37,307 --> 00:02:38,608 <font color="aaaaaa">When you've been making </font> <font color="aaaaaa">delicious natural cheese </font> ``` ^ In this example all the colors is equals to 42 (fg_color == 42), but there are blank lines anyway. File HISTW.ts from [samples](https://drive.google.com/drive/folders/0B_61ywKPmI0Ta2diT3l0eTlHc2c)
Author
Owner

@Izaron commented on GitHub (Jan 12, 2017):

@cfsmp3 After reading the documentation and code I think I found a mistake. Pen colors and attributions are independent from line number, but in current master we storing it for the whole lines. There are the real fg_color changing in SetPenColor (wrote small subprogram): korean.txt (yellow color for first line as in 708 player), usa.txt, histw.txt - almost all text is gray.
Same thing with SetPenAttributes - we can have italicised only one word in the line, but have either full italicised line or full not italicised
I have to rewrite code architecture - single pen for single window as it is written in the documentation

@Izaron commented on GitHub (Jan 12, 2017): @cfsmp3 After reading the documentation and code I think I found a mistake. Pen colors and attributions are independent from line number, but in current master we storing it for the whole lines. There are the real fg_color changing in SetPenColor (wrote small subprogram): [korean.txt](https://gist.github.com/Izaron/b43c2c72b53923955f51fbd7d240941a) (yellow color for first line as in 708 player), [usa.txt](https://gist.github.com/Izaron/89499ccc30db91cefc8dc9b6c2df7ecd), [histw.txt](https://gist.github.com/Izaron/73a3837c6246cb62b5b93928db33523a) - almost all text is gray. Same thing with SetPenAttributes - we can have italicised only one word in the line, but have either full italicised line or full not italicised I have to rewrite code architecture - single pen for single window as it is written in the documentation
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/ccextractor#238