[PR #1673] [MERGED] fix: debugdvb arg typo #2384

Open
opened 2026-01-29 17:21:52 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/CCExtractor/ccextractor/pull/1673
Author: @hrideshmg
Created: 3/13/2025
Status: Merged
Merged: 3/14/2025
Merged by: @cfsmp3

Base: masterHead: fix_dvb_debug_typo


📝 Commits (1)

📊 Changes

2 files changed (+2 additions, -2 deletions)

View changed files

📝 src/rust/src/args.rs (+1 -1)
📝 src/rust/src/parser.rs (+1 -1)

📄 Description

In raising this pull request, I confirm the following (please check boxes):

  • I have read and understood the contributors guide.
  • I have checked that another pull request for this purpose does not exist.
  • I have considered, and confirmed that this submission will be valuable to others.
  • I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  • I give this submission freely, and claim no ownership to its content.

My familiarity with the project is as follows (check one):

  • I have never used CCExtractor.
  • I have used CCExtractor just a couple of times.
  • I absolutely love CCExtractor, but have not contributed previously.
  • I am an active contributor to CCExtractor.

Came across this issue while trying to debug #985, passing --debugdvbsub to a ccextractor build built with rust would error citing an unknown argument. Turned out to be a simple typo in the rust arg parser.

Here is the entry on ccextractor --help:

--debugdvbsub
          Write the DVB subtitle debug traces to console

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/CCExtractor/ccextractor/pull/1673 **Author:** [@hrideshmg](https://github.com/hrideshmg) **Created:** 3/13/2025 **Status:** ✅ Merged **Merged:** 3/14/2025 **Merged by:** [@cfsmp3](https://github.com/cfsmp3) **Base:** `master` ← **Head:** `fix_dvb_debug_typo` --- ### 📝 Commits (1) - [`35c3b39`](https://github.com/CCExtractor/ccextractor/commit/35c3b39ef36fa001db2be6f1e9bf53cf77a0efd9) fix: debugdvb arg typo ### 📊 Changes **2 files changed** (+2 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `src/rust/src/args.rs` (+1 -1) 📝 `src/rust/src/parser.rs` (+1 -1) </details> ### 📄 Description <!-- Please prefix your pull request with one of the following: **[FEATURE]** **[FIX]** **[IMPROVEMENT]**. --> **In raising this pull request, I confirm the following (please check boxes):** - [x] I have read and understood the [contributors guide](https://github.com/CCExtractor/ccextractor/blob/master/.github/CONTRIBUTING.md). - [x] I have checked that another pull request for this purpose does not exist. - [x] I have considered, and confirmed that this submission will be valuable to others. - [x] I accept that this submission may not be used, and the pull request closed at the will of the maintainer. - [x] I give this submission freely, and claim no ownership to its content. **My familiarity with the project is as follows (check one):** - [ ] I have never used CCExtractor. - [x] I have used CCExtractor just a couple of times. - [ ] I absolutely love CCExtractor, but have not contributed previously. - [ ] I am an active contributor to CCExtractor. --- Came across this issue while trying to debug #985, passing `--debugdvbsub` to a ccextractor build built with rust would error citing an unknown argument. Turned out to be a simple typo in the rust arg parser. Here is the entry on `ccextractor --help`: ``` --debugdvbsub Write the DVB subtitle debug traces to console ``` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-29 17:21:52 +00:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/ccextractor#2384