[PR #1677] [MERGED] [FIX] CMake builds failing #2388

Open
opened 2026-01-29 17:21:53 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/CCExtractor/ccextractor/pull/1677
Author: @hrideshmg
Created: 3/20/2025
Status: Merged
Merged: 3/22/2025
Merged by: @cfsmp3

Base: masterHead: fix_cmake


📝 Commits (1)

  • c202364 fix: CMake builds failing due to oudated corrosion

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 src/rust/CMakeLists.txt (+1 -1)

📄 Description

In raising this pull request, I confirm the following (please check boxes):

  • I have read and understood the contributors guide.
  • I have checked that another pull request for this purpose does not exist.
  • I have considered, and confirmed that this submission will be valuable to others.
  • I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  • I give this submission freely, and claim no ownership to its content.
  • I have mentioned this change in the changelog.

My familiarity with the project is as follows (check one):

  • I have never used CCExtractor.
  • I have used CCExtractor just a couple of times.
  • I absolutely love CCExtractor, but have not contributed previously.
  • I am an active contributor to CCExtractor.

CMake builds have been failing recently (as seen on GH actions), this is caused due to corrosion v0.5.0 being incompatible with the latest release of rustup.

This patch upgrades corrosion to v0.5.1 to enable support.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/CCExtractor/ccextractor/pull/1677 **Author:** [@hrideshmg](https://github.com/hrideshmg) **Created:** 3/20/2025 **Status:** ✅ Merged **Merged:** 3/22/2025 **Merged by:** [@cfsmp3](https://github.com/cfsmp3) **Base:** `master` ← **Head:** `fix_cmake` --- ### 📝 Commits (1) - [`c202364`](https://github.com/CCExtractor/ccextractor/commit/c202364591e18dd2acf0fca14cb5a0e0066bdcc1) fix: CMake builds failing due to oudated corrosion ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `src/rust/CMakeLists.txt` (+1 -1) </details> ### 📄 Description <!-- Please prefix your pull request with one of the following: **[FEATURE]** **[FIX]** **[IMPROVEMENT]**. --> **In raising this pull request, I confirm the following (please check boxes):** - [x] I have read and understood the [contributors guide](https://github.com/CCExtractor/ccextractor/blob/master/.github/CONTRIBUTING.md). - [x] I have checked that another pull request for this purpose does not exist. - [x] I have considered, and confirmed that this submission will be valuable to others. - [x] I accept that this submission may not be used, and the pull request closed at the will of the maintainer. - [x] I give this submission freely, and claim no ownership to its content. - [x] **I have mentioned this change in the [changelog](https://github.com/CCExtractor/ccextractor/blob/master/docs/CHANGES.TXT).** **My familiarity with the project is as follows (check one):** - [ ] I have never used CCExtractor. - [ ] I have used CCExtractor just a couple of times. - [ ] I absolutely love CCExtractor, but have not contributed previously. - [x] I am an active contributor to CCExtractor. --- CMake builds have been failing recently (as seen on GH actions), this is caused due to corrosion v0.5.0 being [incompatible](https://github.com/corrosion-rs/corrosion/issues/590) with the latest [release](https://blog.rust-lang.org/2025/03/02/Rustup-1.28.0.html) of rustup. This patch upgrades corrosion to [v0.5.1](https://github.com/corrosion-rs/corrosion/releases/tag/v0.5.1) to enable support. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-29 17:21:53 +00:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/ccextractor#2388