starred/ccextractor
1
0
Fork 0
mirror of https://github.com/CCExtractor/ccextractor.git synced 2026-02-03 21:23:48 +00:00
Code Issues 1.5k Packages Projects Releases 20 Wiki Activity

[PR #1676] [FEAT] WIP module decoder_isdb in lib_ccxr #2389

New Issue
Open
opened 2026-01-29 17:21:53 +00:00 by claunia · 0 comments
claunia commented 2026-01-29 17:21:53 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/CCExtractor/ccextractor/pull/1676
Author: @vatsalkeshav
Created: 3/16/2025
Status: 🔄 Open

Base: master ← Head: isdb_migration

📝 Commits (4)

📊 Changes

15 files changed (+4047 additions, -5 deletions)

View changed files

📝 src/lib_ccx/ccx_decoders_isdb.c (+48 -2)
📝 src/rust/Cargo.lock (+3 -1)
📝 src/rust/Cargo.toml (+2 -1)
📝 src/rust/lib_ccxr/Cargo.lock (+204 -0)
📝 src/rust/lib_ccxr/Cargo.toml (+3 -1)
➕ src/rust/lib_ccxr/src/decoder_isdb/exit_codes.rs (+56 -0)
➕ src/rust/lib_ccxr/src/decoder_isdb/functions_common.rs (+173 -0)
➕ src/rust/lib_ccxr/src/decoder_isdb/functions_isdb.rs (+1986 -0)
➕ src/rust/lib_ccxr/src/decoder_isdb/mod.rs (+6 -0)
➕ src/rust/lib_ccxr/src/decoder_isdb/structs_ccdecode.rs (+281 -0)
➕ src/rust/lib_ccxr/src/decoder_isdb/structs_isdb.rs (+796 -0)
➕ src/rust/lib_ccxr/src/decoder_isdb/structs_xds.rs (+392 -0)
📝 src/rust/lib_ccxr/src/lib.rs (+1 -0)
➕ src/rust/src/libccxr_exports/isdb_exports.rs (+95 -0)
📝 src/rust/src/libccxr_exports/mod.rs (+1 -0)

📄 Description

In raising this pull request, I confirm the following (please check boxes):

  • I have read and understood the contributors guide.
  • I have checked that another pull request for this purpose does not exist.
  • I have considered, and confirmed that this submission will be valuable to others.
  • I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  • I give this submission freely, and claim no ownership to its content.
  • I have mentioned this change in the changelog.

My familiarity with the project is as follows (check one):

  • I have never used CCExtractor.
  • I have used CCExtractor just a couple of times.
  • I absolutely love CCExtractor, but have not contributed previously.
  • I am an active contributor to CCExtractor.

This PR migrates /src/lib_ccx/ccx_decoders_isdb.c to rust.
These changes have been made-

  1. Pure rust equivalent functions in /src/rust/lib_ccxr/src/decoder_isdb/functions_isdb.rs, functions_common.rs
  2. Required datatypes in /src/rust/lib_ccxr/src/decoder_isdb/structs_xds.rs, structs_isdb.rs , structs_ccdecode.rs(thanks @steel-bucket)
  3. Exit codes etc in /src/rust/lib_ccxr/src/decoder_isdb/exit_codes.rs
  4. C-compatible rust functions/exports in src/rust/src/libccxr_exports/isdb_exports.rs
  5. Declaration and use of written rust functions in /src/lib_ccx/ccx_decoders_isdb.c

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/CCExtractor/ccextractor/pull/1676 **Author:** [@vatsalkeshav](https://github.com/vatsalkeshav) **Created:** 3/16/2025 **Status:** 🔄 Open **Base:** `master` ← **Head:** `isdb_migration` --- ### 📝 Commits (4) - [`7d3f3d7`](https://github.com/CCExtractor/ccextractor/commit/7d3f3d700bd4a5c0f175fc30b5ae5499590f0730) added isdbs module in lib_ccxr - [`ccdfeee`](https://github.com/CCExtractor/ccextractor/commit/ccdfeee37d3c435276629b79c43b42629c37114c) some serious code refactoring - [`60d152a`](https://github.com/CCExtractor/ccextractor/commit/60d152a72bd8a87871b864507a65a2d6663b7d6b) update lib_ccxr/cargo.lock - [`40c64d9`](https://github.com/CCExtractor/ccextractor/commit/40c64d92ed4526d1dd4a1286f035be45bace31db) fixed some typos ### 📊 Changes **15 files changed** (+4047 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `src/lib_ccx/ccx_decoders_isdb.c` (+48 -2) 📝 `src/rust/Cargo.lock` (+3 -1) 📝 `src/rust/Cargo.toml` (+2 -1) 📝 `src/rust/lib_ccxr/Cargo.lock` (+204 -0) 📝 `src/rust/lib_ccxr/Cargo.toml` (+3 -1) ➕ `src/rust/lib_ccxr/src/decoder_isdb/exit_codes.rs` (+56 -0) ➕ `src/rust/lib_ccxr/src/decoder_isdb/functions_common.rs` (+173 -0) ➕ `src/rust/lib_ccxr/src/decoder_isdb/functions_isdb.rs` (+1986 -0) ➕ `src/rust/lib_ccxr/src/decoder_isdb/mod.rs` (+6 -0) ➕ `src/rust/lib_ccxr/src/decoder_isdb/structs_ccdecode.rs` (+281 -0) ➕ `src/rust/lib_ccxr/src/decoder_isdb/structs_isdb.rs` (+796 -0) ➕ `src/rust/lib_ccxr/src/decoder_isdb/structs_xds.rs` (+392 -0) 📝 `src/rust/lib_ccxr/src/lib.rs` (+1 -0) ➕ `src/rust/src/libccxr_exports/isdb_exports.rs` (+95 -0) 📝 `src/rust/src/libccxr_exports/mod.rs` (+1 -0) </details> ### 📄 Description <!-- Please prefix your pull request with one of the following: **[FEATURE]** **[FIX]** **[IMPROVEMENT]**. --> **In raising this pull request, I confirm the following (please check boxes):** - [x] I have read and understood the [contributors guide](https://github.com/CCExtractor/ccextractor/blob/master/.github/CONTRIBUTING.md). - [x] I have checked that another pull request for this purpose does not exist. - [x] I have considered, and confirmed that this submission will be valuable to others. - [x] I accept that this submission may not be used, and the pull request closed at the will of the maintainer. - [x] I give this submission freely, and claim no ownership to its content. - [ ] **I have mentioned this change in the [changelog](https://github.com/CCExtractor/ccextractor/blob/master/docs/CHANGES.TXT).** **My familiarity with the project is as follows (check one):** - [ ] I have never used CCExtractor. - [x] I have used CCExtractor just a couple of times. - [ ] I absolutely love CCExtractor, but have not contributed previously. - [x] I am an active contributor to CCExtractor. --- This PR migrates `/src/lib_ccx/ccx_decoders_isdb.c` to rust. These changes have been made- 1. Pure rust equivalent functions in `/src/rust/lib_ccxr/src/decoder_isdb/functions_isdb.rs, functions_common.rs` 2. Required datatypes in `/src/rust/lib_ccxr/src/decoder_isdb/structs_xds.rs`, `structs_isdb.rs` , `structs_ccdecode.rs`(thanks @steel-bucket) 3. Exit codes etc in `/src/rust/lib_ccxr/src/decoder_isdb/exit_codes.rs` 4. C-compatible rust functions/exports in `src/rust/src/libccxr_exports/isdb_exports.rs` 5. Declaration and use of written rust functions in `/src/lib_ccx/ccx_decoders_isdb.c` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-29 17:21:53 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
CEA-708
difficulty: easy
difficulty: hard
difficulty: medium
DTMB
DVB
enhancement
enhancement
Flutter GUI
GCI19
good-first-task
GSoC 2021
GSOC-2023
GSOC-2023
GSOC-2023
GSoC-related
Hacktoberfest
HardsubX
help wanted
invalid
JokerTV
Mac / OSX
more-info-needed
needs-commercial-sponsor
needs-commercial-sponsor
needs-commercial-sponsor
needs-confirmation-of-being-broken
OCR
pull-request
Mirrored from GitHub Pull Request
 Python
regression
Rust
teletext
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/ccextractor#2389
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?