[PR #1680] [MERGED] [FIX] Corrected bitness check for 64-bit systems #2394

New Issue

claunia · 2026-01-29T17:21:55Z

claunia commented

2026-01-29 17:21:55 +00:00

📋 Pull Request Information

Original PR: https://github.com/CCExtractor/ccextractor/pull/1680
Author: @AhmedYasserrr
Created: 3/30/2025
Status: ✅ Merged
Merged: 3/30/2025
Merged by: @cfsmp3

Base: master ← Head: master

📝 Commits (1)

f3e61fc [FIX] Corrected bitness check for 64-bit systems

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 linux/build (+1 -1)

📄 Description

[FIX] Corrected bitness check and added help option to build script

In raising this pull request, I confirm the following (please check boxes):

I have read and understood the contributors guide.
I have checked that another pull request for this purpose does not exist.
I have considered, and confirmed that this submission will be valuable to others.
I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
I give this submission freely, and claim no ownership to its content.
I have mentioned this change in the changelog.

My familiarity with the project is as follows (check one):

I have never used CCExtractor.
I have used CCExtractor just a couple of times.
I absolutely love CCExtractor, but have not contributed previously.
I am an active contributor to CCExtractor.

Description of Changes

Fixed an issue in the bitness check in linux/build.sh:

   if [ "$bit_os"=="64" ]

Fixed missing spaces around == in bitness check. Without the spaces, the condition always evaluated to true, causing -DGPAC_64_BITS to be added even on non-64-bit systems.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/CCExtractor/ccextractor/pull/1680 **Author:** [@AhmedYasserrr](https://github.com/AhmedYasserrr) **Created:** 3/30/2025 **Status:** ✅ Merged **Merged:** 3/30/2025 **Merged by:** [@cfsmp3](https://github.com/cfsmp3) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (1) - [`f3e61fc`](https://github.com/CCExtractor/ccextractor/commit/f3e61fc660232708b56325b957fdd57693fea460) [FIX] Corrected bitness check for 64-bit systems ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `linux/build` (+1 -1) </details> ### 📄 Description  **[FIX]** Corrected bitness check and added help option to build script **In raising this pull request, I confirm the following (please check boxes):** - [x] I have read and understood the [contributors guide](https://github.com/CCExtractor/ccextractor/blob/master/.github/CONTRIBUTING.md). - [x] I have checked that another pull request for this purpose does not exist. - [x] I have considered, and confirmed that this submission will be valuable to others. - [x] I accept that this submission may not be used, and the pull request closed at the will of the maintainer. - [x] I give this submission freely, and claim no ownership to its content. - [x] **I have mentioned this change in the [changelog](https://github.com/CCExtractor/ccextractor/blob/master/docs/CHANGES.TXT).** **My familiarity with the project is as follows (check one):** - [ ] I have never used CCExtractor. - [ ] I have used CCExtractor just a couple of times. - [x] I absolutely love CCExtractor, but have not contributed previously. - [ ] I am an active contributor to CCExtractor. --- ## Description of Changes Fixed an issue in the bitness check in `linux/build.sh`: ```bash if [ "$bit_os"=="64" ] ``` Fixed missing spaces around `==` in bitness check. Without the spaces, the condition always evaluated to true, causing `-DGPAC_64_BITS` to be added even on non-64-bit systems. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

claunia added the pull-request label 2026-01-29 17:21:55 +00:00

claunia closed this issue

2026-01-29 17:21:55 +00:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/ccextractor#2394