starred/ccextractor
1
0
Fork 0
mirror of https://github.com/CCExtractor/ccextractor.git synced 2026-02-03 21:23:48 +00:00
Code Issues 1.5k Packages Projects Releases 20 Wiki Activity

[PR #1685] [CLOSED] [FIX] Initialize data structures for the rust CEA-708 decoder and correct Dtvcc-issue1499 #2401

New Issue
Open
opened 2026-01-29 17:21:57 +00:00 by claunia · 0 comments
claunia commented 2026-01-29 17:21:57 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/CCExtractor/ccextractor/pull/1685
Author: @ujjwalr27
Created: 4/8/2025
Status: ❌ Closed

Base: master ← Head: issue1499-v2

📝 Commits (3)

📊 Changes

5 files changed (+292 additions, -4 deletions)

View changed files

📝 src/lib_ccx/ccx_decoders_common.c (+14 -0)
📝 src/lib_ccx/ccx_decoders_common.h (+6 -0)
📝 src/lib_ccx/ccx_decoders_structs.h (+1 -0)
📝 src/lib_ccx/mp4.c (+41 -0)
📝 src/rust/src/lib.rs (+230 -4)

📄 Description

In raising this pull request, I confirm the following (please check boxes):

  • I have read and understood the contributors guide.
  • I have checked that another pull request for this purpose does not exist.
  • I have considered, and confirmed that this submission will be valuable to others.
  • I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  • I give this submission freely, and claim no ownership to its content.
  • I have mentioned this change in the changelog.

My familiarity with the project is as follows (check one):

  • I have never used CCExtractor.
  • I have used CCExtractor just a couple of times.
  • I absolutely love CCExtractor, but have not contributed previously.
  • I am an active contributor to CCExtractor.

Summary of Changes Made

1. In src/rust/src/lib.rs:

  • Added a new lib_cc_decode struct with a dtvcc_rust field to store the Rust Dtvcc instance.
  • Created ccxr_dtvcc_init() function to initialize the Dtvcc struct only once.
  • Created ccxr_dtvcc_free() function to free the Dtvcc struct.
  • Modified ccxr_process_cc_data() to use the stored Dtvcc instance instead of creating a new one each time.
  • Added a fallback to the old method if initialization fails.

2. In src/lib_ccx/ccx_decoders_structs.h:

  • Added the dtvcc_rust field to the existing lib_cc_decode struct definition.

3. In src/lib_ccx/ccx_decoders_common.h:

  • Added extern declarations for ccxr_dtvcc_init and ccxr_dtvcc_free functions.

4. In src/lib_ccx/ccx_decoders_common.c:

  • Added function declarations for the Rust functions.
  • Added a call to ccxr_dtvcc_init() after dtvcc_init is called.
  • Added a call to ccxr_dtvcc_free() before dtvcc_free is called.
  • Initialized dtvcc_rust to NULL in the init_cc_decode function.
  • Added NULL initialization for dtvcc_rust in the copy_decoder_context function.

5. In src/lib_ccx/mp4.c:

  • Fixed a conflict between multiple MEDIA_TYPE defines.
  • Confirmed that the extern declarations for the Rust functions were already in place.
  • Added code in the process_clcp function to use the Rust implementation of Dtvcc:
    • Checks if dtvcc_rust is NULL and initializes it if needed.
    • Creates a proper cc_block for the Rust implementation.
    • Calls ccxr_process_cc_data() with the block.
    • Falls back to the C implementation if Rust isn't available.

This implementation ensures that the Dtvcc struct is initialized only once at the start of the program and then reused for all subsequent function calls. This fixes the issue where data was being reset each time ccxr_process_cc_data() was called. The changes also integrate this approach into the MP4 code path.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/CCExtractor/ccextractor/pull/1685 **Author:** [@ujjwalr27](https://github.com/ujjwalr27) **Created:** 4/8/2025 **Status:** ❌ Closed **Base:** `master` ← **Head:** `issue1499-v2` --- ### 📝 Commits (3) - [`cdf8fd9`](https://github.com/CCExtractor/ccextractor/commit/cdf8fd9295ef1f5c752d4fc9223fb1b3358399a6) issue1499 - [`617023d`](https://github.com/CCExtractor/ccextractor/commit/617023d4a93ada32189bc94fefd4cc1897e37923) c2 - [`c43e1b3`](https://github.com/CCExtractor/ccextractor/commit/c43e1b33034c7640083f80e62136429982211c85) Merge branch 'CCExtractor:master' into issue1499 ### 📊 Changes **5 files changed** (+292 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `src/lib_ccx/ccx_decoders_common.c` (+14 -0) 📝 `src/lib_ccx/ccx_decoders_common.h` (+6 -0) 📝 `src/lib_ccx/ccx_decoders_structs.h` (+1 -0) 📝 `src/lib_ccx/mp4.c` (+41 -0) 📝 `src/rust/src/lib.rs` (+230 -4) </details> ### 📄 Description <!-- Please prefix your pull request with one of the following: **[FEATURE]** **[FIX]** **[IMPROVEMENT]**. --> **In raising this pull request, I confirm the following (please check boxes):** - [x] I have read and understood the [contributors guide](https://github.com/CCExtractor/ccextractor/blob/master/.github/CONTRIBUTING.md). - [x] I have checked that another pull request for this purpose does not exist. - [x] I have considered, and confirmed that this submission will be valuable to others. - [x] I accept that this submission may not be used, and the pull request closed at the will of the maintainer. - [x] I give this submission freely, and claim no ownership to its content. - [x] **I have mentioned this change in the [changelog](https://github.com/CCExtractor/ccextractor/blob/master/docs/CHANGES.TXT).** **My familiarity with the project is as follows (check one):** - [ ] I have never used CCExtractor. - [ ] I have used CCExtractor just a couple of times. - [x] I absolutely love CCExtractor, but have not contributed previously. - [ ] I am an active contributor to CCExtractor. --- ### Summary of Changes Made #### 1. In `src/rust/src/lib.rs`: - Added a new `lib_cc_decode` struct with a `dtvcc_rust` field to store the Rust `Dtvcc` instance. - Created `ccxr_dtvcc_init()` function to initialize the `Dtvcc` struct only once. - Created `ccxr_dtvcc_free()` function to free the `Dtvcc` struct. - Modified `ccxr_process_cc_data()` to use the stored `Dtvcc` instance instead of creating a new one each time. - Added a fallback to the old method if initialization fails. #### 2. In `src/lib_ccx/ccx_decoders_structs.h`: - Added the `dtvcc_rust` field to the existing `lib_cc_decode` struct definition. #### 3. In `src/lib_ccx/ccx_decoders_common.h`: - Added `extern` declarations for `ccxr_dtvcc_init` and `ccxr_dtvcc_free` functions. #### 4. In `src/lib_ccx/ccx_decoders_common.c`: - Added function declarations for the Rust functions. - Added a call to `ccxr_dtvcc_init()` after `dtvcc_init` is called. - Added a call to `ccxr_dtvcc_free()` before `dtvcc_free` is called. - Initialized `dtvcc_rust` to `NULL` in the `init_cc_decode` function. - Added `NULL` initialization for `dtvcc_rust` in the `copy_decoder_context` function. #### 5. In `src/lib_ccx/mp4.c`: - Fixed a conflict between multiple `MEDIA_TYPE` defines. - Confirmed that the `extern` declarations for the Rust functions were already in place. - Added code in the `process_clcp` function to use the Rust implementation of Dtvcc: - Checks if `dtvcc_rust` is `NULL` and initializes it if needed. - Creates a proper `cc_block` for the Rust implementation. - Calls `ccxr_process_cc_data()` with the block. - Falls back to the C implementation if Rust isn't available. --- This implementation ensures that the `Dtvcc` struct is initialized only once at the start of the program and then reused for all subsequent function calls. This fixes the issue where data was being reset each time `ccxr_process_cc_data()` was called. The changes also integrate this approach into the MP4 code path. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-29 17:21:57 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
CEA-708
difficulty: easy
difficulty: hard
difficulty: medium
DTMB
DVB
enhancement
enhancement
Flutter GUI
GCI19
good-first-task
GSoC 2021
GSOC-2023
GSOC-2023
GSOC-2023
GSoC-related
Hacktoberfest
HardsubX
help wanted
invalid
JokerTV
Mac / OSX
more-info-needed
needs-commercial-sponsor
needs-commercial-sponsor
needs-commercial-sponsor
needs-confirmation-of-being-broken
OCR
pull-request
Mirrored from GitHub Pull Request
 Python
regression
Rust
teletext
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/ccextractor#2401
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?