starred/ccextractor
1
0
Fork 0
mirror of https://github.com/CCExtractor/ccextractor.git synced 2026-02-03 21:23:48 +00:00
Code Issues 1.5k Packages Projects Releases 20 Wiki Activity

[PR #1692] [CLOSED] [FEAT]: Add module decoder_vbi in lib_ccxr #2406

New Issue
Open
opened 2026-01-29 17:21:59 +00:00 by claunia · 0 comments
claunia commented 2026-01-29 17:21:59 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/CCExtractor/ccextractor/pull/1692
Author: @vatsalkeshav
Created: 4/19/2025
Status: ❌ Closed

Base: master ← Head: vbi-migration

📝 Commits (1)

  • aea7a92 feat : module decoder_vbi added in lib_ccxr

📊 Changes

16 files changed (+5464 additions, -0 deletions)

View changed files

📝 src/lib_ccx/ccx_decoders_vbi.c (+34 -0)
📝 src/rust/lib_ccxr/Cargo.toml (+1 -0)
➕ src/rust/lib_ccxr/src/decoder_vbi/exit_codes.rs (+102 -0)
➕ src/rust/lib_ccxr/src/decoder_vbi/functions_vbi_decode.rs (+1158 -0)
➕ src/rust/lib_ccxr/src/decoder_vbi/functions_vbi_main.rs (+75 -0)
➕ src/rust/lib_ccxr/src/decoder_vbi/functions_vbi_slice.rs (+1950 -0)
➕ src/rust/lib_ccxr/src/decoder_vbi/mod.rs (+10 -0)
➕ src/rust/lib_ccxr/src/decoder_vbi/structs_ccdecode.rs (+285 -0)
➕ src/rust/lib_ccxr/src/decoder_vbi/structs_isdb.rs (+796 -0)
➕ src/rust/lib_ccxr/src/decoder_vbi/structs_vbi_decode.rs (+153 -0)
➕ src/rust/lib_ccxr/src/decoder_vbi/structs_vbi_slice.rs (+127 -0)
➕ src/rust/lib_ccxr/src/decoder_vbi/structs_xds.rs (+391 -0)
➕ src/rust/lib_ccxr/src/decoder_vbi/vbi_service_table.rs (+312 -0)
📝 src/rust/lib_ccxr/src/lib.rs (+1 -0)
📝 src/rust/src/libccxr_exports/mod.rs (+1 -0)
➕ src/rust/src/libccxr_exports/vbi_exports.rs (+68 -0)

📄 Description

In raising this pull request, I confirm the following (please check boxes):

  • I have read and understood the contributors guide.
  • I have checked that another pull request for this purpose does not exist.
  • I have considered, and confirmed that this submission will be valuable to others.
  • I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  • I give this submission freely, and claim no ownership to its content.
  • I have mentioned this change in the changelog.

My familiarity with the project is as follows (check one):

  • I have never used CCExtractor.
  • I have used CCExtractor just a couple of times.
  • I absolutely love CCExtractor, but have not contributed previously.
  • I am an active contributor to CCExtractor.

This PR migrates /src/lib_ccx/ccx_decoders_vbi.c to rust.
These changes have been made-

  1. Pure rust equivalent functions in /src/rust/lib_ccxr/src/decoder_isdb/functions_vbi_main.rs (helpers in functions_vbi_slice.rs, functions_vbi_decode.rs, vbi_service_table.rs)
  2. Required datatypes in /src/rust/lib_ccxr/src/decoder_isdb, structs_xds.rs, structs_isdb.rs, structs_ccdecode.rs(thanks @steel-bucket), structs_vbi_slice.rs, structs_vbi_decode.rs
  3. Exit codes etc in /src/rust/lib_ccxr/src/decoder_isdb/exit_codes.rs

To-do:

  • challenging refactor - functions_vbi_slice.rs
  • unit testing
  • flag VBI_DEBUG implementation

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/CCExtractor/ccextractor/pull/1692 **Author:** [@vatsalkeshav](https://github.com/vatsalkeshav) **Created:** 4/19/2025 **Status:** ❌ Closed **Base:** `master` ← **Head:** `vbi-migration` --- ### 📝 Commits (1) - [`aea7a92`](https://github.com/CCExtractor/ccextractor/commit/aea7a929bc0f39df33c7ac0ce8f0dab766d7482e) feat : module decoder_vbi added in lib_ccxr ### 📊 Changes **16 files changed** (+5464 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `src/lib_ccx/ccx_decoders_vbi.c` (+34 -0) 📝 `src/rust/lib_ccxr/Cargo.toml` (+1 -0) ➕ `src/rust/lib_ccxr/src/decoder_vbi/exit_codes.rs` (+102 -0) ➕ `src/rust/lib_ccxr/src/decoder_vbi/functions_vbi_decode.rs` (+1158 -0) ➕ `src/rust/lib_ccxr/src/decoder_vbi/functions_vbi_main.rs` (+75 -0) ➕ `src/rust/lib_ccxr/src/decoder_vbi/functions_vbi_slice.rs` (+1950 -0) ➕ `src/rust/lib_ccxr/src/decoder_vbi/mod.rs` (+10 -0) ➕ `src/rust/lib_ccxr/src/decoder_vbi/structs_ccdecode.rs` (+285 -0) ➕ `src/rust/lib_ccxr/src/decoder_vbi/structs_isdb.rs` (+796 -0) ➕ `src/rust/lib_ccxr/src/decoder_vbi/structs_vbi_decode.rs` (+153 -0) ➕ `src/rust/lib_ccxr/src/decoder_vbi/structs_vbi_slice.rs` (+127 -0) ➕ `src/rust/lib_ccxr/src/decoder_vbi/structs_xds.rs` (+391 -0) ➕ `src/rust/lib_ccxr/src/decoder_vbi/vbi_service_table.rs` (+312 -0) 📝 `src/rust/lib_ccxr/src/lib.rs` (+1 -0) 📝 `src/rust/src/libccxr_exports/mod.rs` (+1 -0) ➕ `src/rust/src/libccxr_exports/vbi_exports.rs` (+68 -0) </details> ### 📄 Description <!-- Please prefix your pull request with one of the following: **[FEATURE]** **[FIX]** **[IMPROVEMENT]**. --> **In raising this pull request, I confirm the following (please check boxes):** - [x] I have read and understood the [contributors guide](https://github.com/CCExtractor/ccextractor/blob/master/.github/CONTRIBUTING.md). - [x] I have checked that another pull request for this purpose does not exist. - [x] I have considered, and confirmed that this submission will be valuable to others. - [x] I accept that this submission may not be used, and the pull request closed at the will of the maintainer. - [x] I give this submission freely, and claim no ownership to its content. - [ ] **I have mentioned this change in the [changelog](https://github.com/CCExtractor/ccextractor/blob/master/docs/CHANGES.TXT).** **My familiarity with the project is as follows (check one):** - [ ] I have never used CCExtractor. - [x] I have used CCExtractor just a couple of times. - [ ] I absolutely love CCExtractor, but have not contributed previously. - [ ] I am an active contributor to CCExtractor. --- This PR migrates `/src/lib_ccx/ccx_decoders_vbi.c` to rust. These changes have been made- 1. Pure rust equivalent functions in `/src/rust/lib_ccxr/src/decoder_isdb/functions_vbi_main.rs` (helpers in `functions_vbi_slice.rs`, `functions_vbi_decode.rs`, `vbi_service_table.rs`) 2. Required datatypes in `/src/rust/lib_ccxr/src/decoder_isdb, structs_xds.rs`, `structs_isdb.rs`, `structs_ccdecode.rs`(thanks @steel-bucket), `structs_vbi_slice.rs`, `structs_vbi_decode.rs` 3. Exit codes etc in `/src/rust/lib_ccxr/src/decoder_isdb/exit_codes.rs` **To-do:** - [ ] challenging refactor - `functions_vbi_slice.rs` - [ ] unit testing - [ ] flag VBI_DEBUG implementation --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-29 17:21:59 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
CEA-708
difficulty: easy
difficulty: hard
difficulty: medium
DTMB
DVB
enhancement
enhancement
Flutter GUI
GCI19
good-first-task
GSoC 2021
GSOC-2023
GSOC-2023
GSOC-2023
GSoC-related
Hacktoberfest
HardsubX
help wanted
invalid
JokerTV
Mac / OSX
more-info-needed
needs-commercial-sponsor
needs-commercial-sponsor
needs-commercial-sponsor
needs-confirmation-of-being-broken
OCR
pull-request
Mirrored from GitHub Pull Request
 Python
regression
Rust
teletext
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/ccextractor#2406
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?