[PR #1695] [FIX] The first TODO in avc_functions.c and FIXME in avc_functions.c

## 📋 Pull Request Information **Original PR:** https://github.com/CCExtractor/ccextractor/pull/1695 **Author:** [@steel-bucket](https://github.com/steel-bucket) **Created:** 4/26/2025 **Status:** 🔄 Open **Base:** `master` ← **Head:** `avc-todo` --- ### 📝 Commits (7) - [`dafe728`](https://github.com/CCExtractor/ccextractor/commit/dafe7280df372234b916d4fbfd0f0d02e47a08d8) fix: The first TODO in avc_functions.c and FIXME in avc_functions.c - [`d1f2dbb`](https://github.com/CCExtractor/ccextractor/commit/d1f2dbbc374f89a1d0c42768a75e16a77daa65f9) fix: AVC - Update CHANGES.txt - [`b2353f8`](https://github.com/CCExtractor/ccextractor/commit/b2353f8a0835531931f316129d6a3e16616d737d) fix: Clippy fix for encoder - [`42e70ab`](https://github.com/CCExtractor/ccextractor/commit/42e70abe18b8a3dbd00308aab59e2646648b66e0) Merge branch 'master' into avc-todo - [`28ab492`](https://github.com/CCExtractor/ccextractor/commit/28ab4924632c16789bb3ef3ad1b4b21139891a9c) Merge branch 'CCExtractor:master' into avc-todo - [`3172e80`](https://github.com/CCExtractor/ccextractor/commit/3172e800e9db500cac1ce8d9244fc579ce6febb9) Merge branch 'CCExtractor:master' into avc-todo - [`23330c7`](https://github.com/CCExtractor/ccextractor/commit/23330c71fbddd46c9be6766aa45c47ac90ab123d) fix: trying to use latest vcpkg ### 📊 Changes **2 files changed** (+106 additions, -13 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/build_windows.yml` (+96 -7) 📝 `src/lib_ccx/avc_functions.c` (+10 -6) </details> ### 📄 Description  **In raising this pull request, I confirm the following (please check boxes):** - [x] I have read and understood the [contributors guide](https://github.com/CCExtractor/ccextractor/blob/master/.github/CONTRIBUTING.md). - [x] I have checked that another pull request for this purpose does not exist. - [x] I have considered, and confirmed that this submission will be valuable to others. - [x] I accept that this submission may not be used, and the pull request closed at the will of the maintainer. - [x] I give this submission freely, and claim no ownership to its content. - [ ] **I have mentioned this change in the [changelog](https://github.com/CCExtractor/ccextractor/blob/master/docs/CHANGES.TXT).** **My familiarity with the project is as follows (check one):** - [ ] I have never used CCExtractor. - [ ] I have used CCExtractor just a couple of times. - [ ] I absolutely love CCExtractor, but have not contributed previously. - [x] I am an active contributor to CCExtractor. --- This PR resolves one TODO and one FIXME in the avc_functions.c. The first TODO was -` TODO: Do something if newsize == -1 (broken NAL)` So, what my changes do is, print out a more verbose error message. The first FIXME was to check the set_fts function for `CCX_NAL_TYPE_SEI` which was only being checked in slice_header for NAL Type as `CCX_NAL_TYPE_CODED_SLICE_IDR_PICTURE` or `CCX_NAL_TYPE_CODED_SLICE_NON_IDR_PICTURE_1`. There are more TODOs in the AVC Functions library, which need to be resolved before or during the porting to Rust. This PR will help in debugging and resolving the AVC Issues currently prevalent in CCExtractor.( #1626 , #1597 , #1592 ) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

claunia commented

2026-01-29 17:21:59 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/CCExtractor/ccextractor/pull/1695
Author: @steel-bucket
Created: 4/26/2025
Status: 🔄 Open

Base: master ← Head: avc-todo

📝 Commits (7)

dafe728 fix: The first TODO in avc_functions.c and FIXME in avc_functions.c
d1f2dbb fix: AVC - Update CHANGES.txt
b2353f8 fix: Clippy fix for encoder
42e70ab Merge branch 'master' into avc-todo
28ab492 Merge branch 'CCExtractor:master' into avc-todo
3172e80 Merge branch 'CCExtractor:master' into avc-todo
23330c7 fix: trying to use latest vcpkg

📊 Changes

2 files changed (+106 additions, -13 deletions)

View changed files

📝 .github/workflows/build_windows.yml (+96 -7)
📝 src/lib_ccx/avc_functions.c (+10 -6)

📄 Description

In raising this pull request, I confirm the following (please check boxes):

I have read and understood the contributors guide.
I have checked that another pull request for this purpose does not exist.
I have considered, and confirmed that this submission will be valuable to others.
I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
I give this submission freely, and claim no ownership to its content.
I have mentioned this change in the changelog.

My familiarity with the project is as follows (check one):

I have never used CCExtractor.
I have used CCExtractor just a couple of times.
I absolutely love CCExtractor, but have not contributed previously.
I am an active contributor to CCExtractor.

This PR resolves one TODO and one FIXME in the avc_functions.c.
The first TODO was - TODO: Do something if newsize == -1 (broken NAL)
So, what my changes do is, print out a more verbose error message.
The first FIXME was to check the set_fts function for CCX_NAL_TYPE_SEI which was only being checked in slice_header for NAL Type as CCX_NAL_TYPE_CODED_SLICE_IDR_PICTURE or CCX_NAL_TYPE_CODED_SLICE_NON_IDR_PICTURE_1.

There are more TODOs in the AVC Functions library, which need to be resolved before or during the porting to Rust.
This PR will help in debugging and resolving the AVC Issues currently prevalent in CCExtractor.( #1626 , #1597 , #1592 )

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

claunia added the pull-request label 2026-01-29 17:21:59 +00:00

[PR #1695] [FIX] The first TODO in avc_functions.c and FIXME in avc_functions.c #2408

📋 Pull Request Information

📝 Commits (7)

📊 Changes

📄 Description