[PR #1696] [MERGED] [IMPROVEMENT] Refactor and optimize Dockerfile #2410

Closed
opened 2026-01-29 17:21:59 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/CCExtractor/ccextractor/pull/1696
Author: @AhmedYasserrr
Created: 4/27/2025
Status: Merged
Merged: 4/27/2025
Merged by: @cfsmp3

Base: masterHead: refactor-dockerfile


📝 Commits (4)

  • f3e61fc [FIX] Corrected bitness check for 64-bit systems
  • 49d3177 Merge branch 'CCExtractor:master' into master
  • efdc7c7 Improve Dockerfile: cleanup, parallel build, and remove redundancies
  • e318886 [DOCS] Update CHANGES.TXT for Dockerfile improvements

📊 Changes

2 files changed (+11 additions, -12 deletions)

View changed files

📝 docker/dockerfile (+10 -12)
📝 docs/CHANGES.TXT (+1 -0)

📄 Description

In raising this pull request, I confirm the following (please check boxes):

  • I have read and understood the contributors guide.
  • I have checked that another pull request for this purpose does not exist.
  • I have considered, and confirmed that this submission will be valuable to others.
  • I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  • I give this submission freely, and claim no ownership to its content.
  • I have mentioned this change in the changelog.

My familiarity with the project is as follows (check one):

  • I have never used CCExtractor.
  • I have used CCExtractor just a couple of times.
  • I absolutely love CCExtractor, but have not contributed previously.
  • I am an active contributor to CCExtractor.

Changes:

  • Replaced cd commands with WORKDIR instructions to improve clarity and follow Docker best practices.
  • Removed the unused RUN export for LIB_CLANG_PATH, which only affected a single build layer (since export does not persist between Docker layers); the library is automatically detected during build.
  • Parallelized GPAC build using make -j$(nproc), significantly reducing build time.
  • Removed redundant CMD instruction since ENTRYPOINT already defines the execution command.

This PR improves Dockerfile structure, reduces build time, and eliminates unnecessary instructions for a cleaner and more maintainable setup.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/CCExtractor/ccextractor/pull/1696 **Author:** [@AhmedYasserrr](https://github.com/AhmedYasserrr) **Created:** 4/27/2025 **Status:** ✅ Merged **Merged:** 4/27/2025 **Merged by:** [@cfsmp3](https://github.com/cfsmp3) **Base:** `master` ← **Head:** `refactor-dockerfile` --- ### 📝 Commits (4) - [`f3e61fc`](https://github.com/CCExtractor/ccextractor/commit/f3e61fc660232708b56325b957fdd57693fea460) [FIX] Corrected bitness check for 64-bit systems - [`49d3177`](https://github.com/CCExtractor/ccextractor/commit/49d3177f59c9d1d524ff2b83a6a32f8b86ed9c81) Merge branch 'CCExtractor:master' into master - [`efdc7c7`](https://github.com/CCExtractor/ccextractor/commit/efdc7c73dc3fde5757abdb0a325b5ae1da89c3ee) Improve Dockerfile: cleanup, parallel build, and remove redundancies - [`e318886`](https://github.com/CCExtractor/ccextractor/commit/e318886958d486a96f3c293f8790344f66333859) [DOCS] Update CHANGES.TXT for Dockerfile improvements ### 📊 Changes **2 files changed** (+11 additions, -12 deletions) <details> <summary>View changed files</summary> 📝 `docker/dockerfile` (+10 -12) 📝 `docs/CHANGES.TXT` (+1 -0) </details> ### 📄 Description <!-- Please prefix your pull request with one of the following: **[FEATURE]** **[FIX]** **[IMPROVEMENT]**. --> **In raising this pull request, I confirm the following (please check boxes):** - [x] I have read and understood the [contributors guide](https://github.com/CCExtractor/ccextractor/blob/master/.github/CONTRIBUTING.md). - [x] I have checked that another pull request for this purpose does not exist. - [x] I have considered, and confirmed that this submission will be valuable to others. - [x] I accept that this submission may not be used, and the pull request closed at the will of the maintainer. - [x] I give this submission freely, and claim no ownership to its content. - [x] **I have mentioned this change in the [changelog](https://github.com/CCExtractor/ccextractor/blob/master/docs/CHANGES.TXT).** **My familiarity with the project is as follows (check one):** - [ ] I have never used CCExtractor. - [x] I have used CCExtractor just a couple of times. - [ ] I absolutely love CCExtractor, but have not contributed previously. - [ ] I am an active contributor to CCExtractor. --- **Changes:** - Replaced `cd` commands with `WORKDIR` instructions to improve clarity and follow Docker best practices. - Removed the unused RUN export for LIB_CLANG_PATH, which only affected a single build layer (since export does not persist between Docker layers); the library is automatically detected during build. - Parallelized GPAC build using `make -j$(nproc)`, significantly reducing build time. - Removed redundant `CMD` instruction since `ENTRYPOINT` already defines the execution command. This PR improves Dockerfile structure, reduces build time, and eliminates unnecessary instructions for a cleaner and more maintainable setup. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-29 17:21:59 +00:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/ccextractor#2410