starred/ccextractor
1
0
Fork 0
mirror of https://github.com/CCExtractor/ccextractor.git synced 2026-04-18 20:12:50 +00:00
Code Issues 1.5k Packages Projects Releases 21 Wiki Activity

[PR #1703] [CLOSED] [FIX] escape special characters ( < > & ) to HTML context #2416

New Issue
Open
opened 2026-01-29 17:22:02 +00:00 by claunia · 0 comments
claunia commented 2026-01-29 17:22:02 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/CCExtractor/ccextractor/pull/1703
Author: @AlvinLi-harmonicinc
Created: 6/13/2025
Status: ❌ Closed

Base: master ← Head: master

📝 Commits (2)

  • 68c2dfa [FIX] escape special characters ( < > & ) to HTML context
  • 31e6c19 Merge branch 'master' into master

📊 Changes

5 files changed (+50 additions, -3 deletions)

View changed files

📝 docs/CHANGES.TXT (+1 -0)
📝 src/lib_ccx/ccx_decoders_708_output.c (+4 -1)
📝 src/lib_ccx/ccx_encoders_helpers.c (+11 -2)
📝 src/lib_ccx/utility.c (+32 -0)
📝 src/lib_ccx/utility.h (+2 -0)

📄 Description

In raising this pull request, I confirm the following (please check boxes):

  • I have read and understood the contributors guide.
  • I have checked that another pull request for this purpose does not exist.
  • I have considered, and confirmed that this submission will be valuable to others.
  • I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  • I give this submission freely, and claim no ownership to its content.
  • I have mentioned this change in the changelog.

My familiarity with the project is as follows (check one):

  • I have never used CCExtractor.
  • I have used CCExtractor just a couple of times.
  • I absolutely love CCExtractor, but have not contributed previously.
  • I am an active contributor to CCExtractor.

The <, >, & is not suppose to be appeared in SRT, because SRT supports HTML tags.
So, the content of SRT should be treated as HTML content with those characters being escaped.
As a result, this pull request intends to do the following:

  • convert & to &amp;
  • convert < to &lt;
  • convert > to &gt;

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/CCExtractor/ccextractor/pull/1703 **Author:** [@AlvinLi-harmonicinc](https://github.com/AlvinLi-harmonicinc) **Created:** 6/13/2025 **Status:** ❌ Closed **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (2) - [`68c2dfa`](https://github.com/CCExtractor/ccextractor/commit/68c2dfaeb3bc84ad80e472ba46be1f13f489c514) [FIX] escape special characters ( < > & ) to HTML context - [`31e6c19`](https://github.com/CCExtractor/ccextractor/commit/31e6c19107d57036053701bd54a9f45a20b02794) Merge branch 'master' into master ### 📊 Changes **5 files changed** (+50 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `docs/CHANGES.TXT` (+1 -0) 📝 `src/lib_ccx/ccx_decoders_708_output.c` (+4 -1) 📝 `src/lib_ccx/ccx_encoders_helpers.c` (+11 -2) 📝 `src/lib_ccx/utility.c` (+32 -0) 📝 `src/lib_ccx/utility.h` (+2 -0) </details> ### 📄 Description <!-- Please prefix your pull request with one of the following: **[FEATURE]** **[FIX]** **[IMPROVEMENT]**. --> **In raising this pull request, I confirm the following (please check boxes):** - [x] I have read and understood the [contributors guide](https://github.com/CCExtractor/ccextractor/blob/master/.github/CONTRIBUTING.md). - [x] I have checked that another pull request for this purpose does not exist. - [x] I have considered, and confirmed that this submission will be valuable to others. - [x] I accept that this submission may not be used, and the pull request closed at the will of the maintainer. - [x] I give this submission freely, and claim no ownership to its content. - [x] **I have mentioned this change in the [changelog](https://github.com/CCExtractor/ccextractor/blob/master/docs/CHANGES.TXT).** **My familiarity with the project is as follows (check one):** - [ ] I have never used CCExtractor. - [ ] I have used CCExtractor just a couple of times. - [x] I absolutely love CCExtractor, but have not contributed previously. - [ ] I am an active contributor to CCExtractor. --- The `<`, `>`, `&` is not suppose to be appeared in SRT, because SRT supports HTML tags. So, the content of SRT should be treated as HTML content with those characters being escaped. As a result, this pull request intends to do the following: - convert `&` to `&amp;` - convert `<` to `&lt;` - convert `>` to `&gt;` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-29 17:22:02 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
CEA-708
difficulty: easy
difficulty: hard
difficulty: medium
DTMB
DVB
enhancement
enhancement
Flutter GUI
GCI19
good-first-task
GSoC 2021
GSOC-2023
GSOC-2023
GSOC-2023
GSoC-related
Hacktoberfest
HardsubX
help wanted
invalid
JokerTV
Mac / OSX
more-info-needed
needs-commercial-sponsor
needs-commercial-sponsor
needs-commercial-sponsor
needs-confirmation-of-being-broken
OCR
pull-request
Mirrored from GitHub Pull Request
 Python
regression
Rust
teletext
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/ccextractor#2416
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?