[PR #1706] [MERGED] Fixed Clippy Errors on 1.88 #2423

Closed
opened 2026-01-29 17:22:05 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/CCExtractor/ccextractor/pull/1706
Author: @steel-bucket
Created: 6/26/2025
Status: Merged
Merged: 6/27/2025
Merged by: @cfsmp3

Base: masterHead: fix-clippy-1.88


📝 Commits (2)

  • ec783f7 Fixed Clippy Errors on 1.88
  • 383d92a Update CHANGES.TXT - fix-clippy-1.88

📊 Changes

10 files changed (+36 additions, -45 deletions)

View changed files

📝 docs/CHANGES.TXT (+1 -0)
📝 src/rust/lib_ccxr/src/activity.rs (+1 -1)
📝 src/rust/lib_ccxr/src/teletext.rs (+7 -13)
📝 src/rust/lib_ccxr/src/time/units.rs (+7 -7)
📝 src/rust/lib_ccxr/src/util/bits.rs (+4 -4)
📝 src/rust/lib_ccxr/src/util/log.rs (+8 -11)
📝 src/rust/src/decoder/timing.rs (+1 -1)
📝 src/rust/src/decoder/tv_screen.rs (+2 -2)
📝 src/rust/src/lib.rs (+3 -3)
📝 src/rust/src/parser.rs (+2 -3)

📄 Description

In raising this pull request, I confirm the following (please check boxes):

  • I have read and understood the contributors guide.
  • I have checked that another pull request for this purpose does not exist.
  • I have considered, and confirmed that this submission will be valuable to others.
  • I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  • I give this submission freely, and claim no ownership to its content.
  • I have mentioned this change in the changelog.

My familiarity with the project is as follows (check one):

  • I have never used CCExtractor.
  • I have used CCExtractor just a couple of times.
  • I absolutely love CCExtractor, but have not contributed previously.
  • I am an active contributor to CCExtractor.

Clippy has introduced a new formatting scheme on the New rust version 1.88 which caused clippy to fail.
This PR fixes those issues. I was notified of this from @hrideshmg 's branch failing CI


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/CCExtractor/ccextractor/pull/1706 **Author:** [@steel-bucket](https://github.com/steel-bucket) **Created:** 6/26/2025 **Status:** ✅ Merged **Merged:** 6/27/2025 **Merged by:** [@cfsmp3](https://github.com/cfsmp3) **Base:** `master` ← **Head:** `fix-clippy-1.88` --- ### 📝 Commits (2) - [`ec783f7`](https://github.com/CCExtractor/ccextractor/commit/ec783f7a61d31caae224be00e95592e7a12e299a) Fixed Clippy Errors on 1.88 - [`383d92a`](https://github.com/CCExtractor/ccextractor/commit/383d92aba231f3b77cdff1a80b2f7651f6734395) Update CHANGES.TXT - fix-clippy-1.88 ### 📊 Changes **10 files changed** (+36 additions, -45 deletions) <details> <summary>View changed files</summary> 📝 `docs/CHANGES.TXT` (+1 -0) 📝 `src/rust/lib_ccxr/src/activity.rs` (+1 -1) 📝 `src/rust/lib_ccxr/src/teletext.rs` (+7 -13) 📝 `src/rust/lib_ccxr/src/time/units.rs` (+7 -7) 📝 `src/rust/lib_ccxr/src/util/bits.rs` (+4 -4) 📝 `src/rust/lib_ccxr/src/util/log.rs` (+8 -11) 📝 `src/rust/src/decoder/timing.rs` (+1 -1) 📝 `src/rust/src/decoder/tv_screen.rs` (+2 -2) 📝 `src/rust/src/lib.rs` (+3 -3) 📝 `src/rust/src/parser.rs` (+2 -3) </details> ### 📄 Description <!-- Please prefix your pull request with one of the following: **[FEATURE]** **[FIX]** **[IMPROVEMENT]**. --> **In raising this pull request, I confirm the following (please check boxes):** - [x] I have read and understood the [contributors guide](https://github.com/CCExtractor/ccextractor/blob/master/.github/CONTRIBUTING.md). - [x] I have checked that another pull request for this purpose does not exist. - [x] I have considered, and confirmed that this submission will be valuable to others. - [x] I accept that this submission may not be used, and the pull request closed at the will of the maintainer. - [x] I give this submission freely, and claim no ownership to its content. - [x] **I have mentioned this change in the [changelog](https://github.com/CCExtractor/ccextractor/blob/master/docs/CHANGES.TXT).** **My familiarity with the project is as follows (check one):** - [ ] I have never used CCExtractor. - [ ] I have used CCExtractor just a couple of times. - [ ] I absolutely love CCExtractor, but have not contributed previously. - [x] I am an active contributor to CCExtractor. --- Clippy has introduced a new formatting scheme on the New rust version 1.88 which caused clippy to fail. This PR fixes those issues. I was notified of this from @hrideshmg 's branch [failing CI](https://github.com/CCExtractor/ccextractor/actions/runs/15909554037/job/44873167652) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-29 17:22:05 +00:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/ccextractor#2423