[PR #1708] [MERGED] [FIX] 134 Codes in XDS and General Tests

## 📋 Pull Request Information **Original PR:** https://github.com/CCExtractor/ccextractor/pull/1708 **Author:** [@steel-bucket](https://github.com/steel-bucket) **Created:** 7/6/2025 **Status:** ✅ Merged **Merged:** 7/7/2025 **Merged by:** [@prateekmedia](https://github.com/prateekmedia) **Base:** `master` ← **Head:** `xds-general-134-errors` --- ### 📝 Commits (5) - [`1fb9b3c`](https://github.com/CCExtractor/ccextractor/commit/1fb9b3cf582073fa1b87562ae2a8b47b7eff5f8f) Made pointers valid in Unit Tests of Decoder - [`1596765`](https://github.com/CCExtractor/ccextractor/commit/159676533212f5a66d5e9ee1ac4e6ac2bddde27e) fix: test_do_cb - [`8c0fcd3`](https://github.com/CCExtractor/ccextractor/commit/8c0fcd37b6b992c9d265cda0252fee08b8248e23) Copilot Suggestions - [`3ea122b`](https://github.com/CCExtractor/ccextractor/commit/3ea122b7b5a67e085bad83563424646920c5873b) Suggestions about Redundancy - [`15319d7`](https://github.com/CCExtractor/ccextractor/commit/15319d7184c16c20557704d887b07de954c5191e) Suggestions about Redundancy ### 📊 Changes **2 files changed** (+87 additions, -79 deletions) <details> <summary>View changed files</summary> 📝 `src/rust/src/decoder/mod.rs` (+28 -21) 📝 `src/rust/src/lib.rs` (+59 -58) </details> ### 📄 Description  **In raising this pull request, I confirm the following (please check boxes):** - [x] I have read and understood the [contributors guide](https://github.com/CCExtractor/ccextractor/blob/master/.github/CONTRIBUTING.md). - [x] I have checked that another pull request for this purpose does not exist. - [x] I have considered, and confirmed that this submission will be valuable to others. - [x] I accept that this submission may not be used, and the pull request closed at the will of the maintainer. - [x] I give this submission freely, and claim no ownership to its content. - [ ] **I have mentioned this change in the [changelog](https://github.com/CCExtractor/ccextractor/blob/master/docs/CHANGES.TXT).** **My familiarity with the project is as follows (check one):** - [ ] I have never used CCExtractor. - [ ] I have used CCExtractor just a couple of times. - [ ] I absolutely love CCExtractor, but have not contributed previously. - [x] I am an active contributor to CCExtractor. --- I had made some change before to fix the Unit Tests failing, using Fallback values in functions. But this caused problems in a few regression tests. In this PR, I have reverted the function changes done to `Dtvcc::new()` and have rather focused on the tests. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

claunia commented

2026-01-29 17:22:05 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/CCExtractor/ccextractor/pull/1708
Author: @steel-bucket
Created: 7/6/2025
Status: ✅ Merged
Merged: 7/7/2025
Merged by: @prateekmedia

Base: master ← Head: xds-general-134-errors

📝 Commits (5)

1fb9b3c Made pointers valid in Unit Tests of Decoder
1596765 fix: test_do_cb
8c0fcd3 Copilot Suggestions
3ea122b Suggestions about Redundancy
15319d7 Suggestions about Redundancy

📊 Changes

2 files changed (+87 additions, -79 deletions)

View changed files

📝 src/rust/src/decoder/mod.rs (+28 -21)
📝 src/rust/src/lib.rs (+59 -58)

📄 Description

In raising this pull request, I confirm the following (please check boxes):

I have read and understood the contributors guide.
I have checked that another pull request for this purpose does not exist.
I have considered, and confirmed that this submission will be valuable to others.
I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
I give this submission freely, and claim no ownership to its content.
I have mentioned this change in the changelog.

My familiarity with the project is as follows (check one):

I have never used CCExtractor.
I have used CCExtractor just a couple of times.
I absolutely love CCExtractor, but have not contributed previously.
I am an active contributor to CCExtractor.

I had made some change before to fix the Unit Tests failing, using Fallback values in functions. But this caused problems in a few regression tests. In this PR, I have reverted the function changes done to Dtvcc::new() and have rather focused on the tests.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

claunia added the pull-request label 2026-01-29 17:22:05 +00:00

[PR #1708] [MERGED] [FIX] 134 Codes in XDS and General Tests #2426

📋 Pull Request Information

📝 Commits (5)

📊 Changes

📄 Description