[PR #1708] [FIX] 134 Codes in XDS and General Tests

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/ccextractor#2430

claunia commented

2026-01-29 17:22:06 +00:00

Owner

Original Pull Request: https://github.com/CCExtractor/ccextractor/pull/1708

State: closed
Merged: Yes

In raising this pull request, I confirm the following (please check boxes):

I have read and understood the contributors guide.
I have checked that another pull request for this purpose does not exist.
I have considered, and confirmed that this submission will be valuable to others.
I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
I give this submission freely, and claim no ownership to its content.
I have mentioned this change in the changelog.

My familiarity with the project is as follows (check one):

I have never used CCExtractor.
I have used CCExtractor just a couple of times.
I absolutely love CCExtractor, but have not contributed previously.
I am an active contributor to CCExtractor.

I had made some change before to fix the Unit Tests failing, using Fallback values in functions. But this caused problems in a few regression tests. In this PR, I have reverted the function changes done to Dtvcc::new() and have rather focused on the tests.

**Original Pull Request:** https://github.com/CCExtractor/ccextractor/pull/1708 **State:** closed **Merged:** Yes ---  **In raising this pull request, I confirm the following (please check boxes):** - [x] I have read and understood the [contributors guide](https://github.com/CCExtractor/ccextractor/blob/master/.github/CONTRIBUTING.md). - [x] I have checked that another pull request for this purpose does not exist. - [x] I have considered, and confirmed that this submission will be valuable to others. - [x] I accept that this submission may not be used, and the pull request closed at the will of the maintainer. - [x] I give this submission freely, and claim no ownership to its content. - [ ] **I have mentioned this change in the [changelog](https://github.com/CCExtractor/ccextractor/blob/master/docs/CHANGES.TXT).** **My familiarity with the project is as follows (check one):** - [ ] I have never used CCExtractor. - [ ] I have used CCExtractor just a couple of times. - [ ] I absolutely love CCExtractor, but have not contributed previously. - [x] I am an active contributor to CCExtractor. --- I had made some change before to fix the Unit Tests failing, using Fallback values in functions. But this caused problems in a few regression tests. In this PR, I have reverted the function changes done to `Dtvcc::new()` and have rather focused on the tests.

claunia added the pull-request label 2026-01-29 17:22:06 +00:00

[PR #1708] [FIX] 134 Codes in XDS and General Tests #2430