starred/ccextractor
1
0
Fork 0
mirror of https://github.com/CCExtractor/ccextractor.git synced 2026-07-08 18:06:30 +00:00
Code Issues 1.5k Packages Projects Releases 21 Wiki Activity

[PR #1714] [MERGED] fix: dvd regressions #2434

New Issue
Open
opened 2026-01-29 17:22:08 +00:00 by claunia · 0 comments
claunia commented 2026-01-29 17:22:08 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/CCExtractor/ccextractor/pull/1714
Author: @hrideshmg
Created: 7/17/2025
Status: ✅ Merged
Merged: 8/18/2025
Merged by: @prateekmedia

Base: master ← Head: dvd_fix

📝 Commits (4)

  • 07fcb4f fix: dvd regressions
  • a0c4fb5 chore: fix clippy errors
  • e3d2569 Merge branch 'master' into dvd_fix
  • ec0988b Merge branch 'master' into dvd_fix

📊 Changes

2 files changed (+3 additions, -0 deletions)

View changed files

📝 docs/CHANGES.TXT (+1 -0)
📝 src/rust/src/libccxr_exports/bitstream.rs (+2 -0)

📄 Description

In raising this pull request, I confirm the following (please check boxes):

  • I have read and understood the contributors guide.
  • I have checked that another pull request for this purpose does not exist.
  • I have considered, and confirmed that this submission will be valuable to others.
  • I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  • I give this submission freely, and claim no ownership to its content.
  • I have mentioned this change in the changelog.

My familiarity with the project is as follows (check one):

  • I have never used CCExtractor.
  • I have used CCExtractor just a couple of times.
  • I absolutely love CCExtractor, but have not contributed previously.
  • I am an active contributor to CCExtractor.

Regressions on DVD files are currently broken. See latest test result. Issue seems to have been caused by a segfault involving a struct that was expected to contain data but was lost in conversion between rust and C.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/CCExtractor/ccextractor/pull/1714 **Author:** [@hrideshmg](https://github.com/hrideshmg) **Created:** 7/17/2025 **Status:** ✅ Merged **Merged:** 8/18/2025 **Merged by:** [@prateekmedia](https://github.com/prateekmedia) **Base:** `master` ← **Head:** `dvd_fix` --- ### 📝 Commits (4) - [`07fcb4f`](https://github.com/CCExtractor/ccextractor/commit/07fcb4f9b7c9a661600adfa533db781f63c81f0b) fix: dvd regressions - [`a0c4fb5`](https://github.com/CCExtractor/ccextractor/commit/a0c4fb58f2ec8b86ed3b6ee4265e18ec5e02f811) chore: fix clippy errors - [`e3d2569`](https://github.com/CCExtractor/ccextractor/commit/e3d256962f157dc807e00b8d472f87e156f67e3a) Merge branch 'master' into dvd_fix - [`ec0988b`](https://github.com/CCExtractor/ccextractor/commit/ec0988bcb203f87ab1c096e429cf9d79f4ae71de) Merge branch 'master' into dvd_fix ### 📊 Changes **2 files changed** (+3 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `docs/CHANGES.TXT` (+1 -0) 📝 `src/rust/src/libccxr_exports/bitstream.rs` (+2 -0) </details> ### 📄 Description <!-- Please prefix your pull request with one of the following: **[FEATURE]** **[FIX]** **[IMPROVEMENT]**. --> **In raising this pull request, I confirm the following (please check boxes):** - [x] I have read and understood the [contributors guide](https://github.com/CCExtractor/ccextractor/blob/master/.github/CONTRIBUTING.md). - [x] I have checked that another pull request for this purpose does not exist. - [x] I have considered, and confirmed that this submission will be valuable to others. - [x] I accept that this submission may not be used, and the pull request closed at the will of the maintainer. - [x] I give this submission freely, and claim no ownership to its content. - [x] **I have mentioned this change in the [changelog](https://github.com/CCExtractor/ccextractor/blob/master/docs/CHANGES.TXT).** **My familiarity with the project is as follows (check one):** - [ ] I have never used CCExtractor. - [ ] I have used CCExtractor just a couple of times. - [ ] I absolutely love CCExtractor, but have not contributed previously. - [x] I am an active contributor to CCExtractor. --- Regressions on DVD files are currently broken. See [latest](https://sampleplatform.ccextractor.org/test/5871) test result. Issue seems to have been caused by a segfault involving a struct that was expected to contain data but was lost in conversion between rust and C. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-29 17:22:08 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
CEA-708
difficulty: easy
difficulty: hard
difficulty: medium
DTMB
DVB
enhancement
enhancement
Flutter GUI
GCI19
good-first-task
GSoC 2021
GSOC-2023
GSOC-2023
GSOC-2023
GSoC-related
Hacktoberfest
HardsubX
help wanted
invalid
JokerTV
Mac / OSX
more-info-needed
needs-commercial-sponsor
needs-commercial-sponsor
needs-commercial-sponsor
needs-confirmation-of-being-broken
OCR
pull-request
Mirrored from GitHub Pull Request
 Python
regression
Rust
teletext
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/ccextractor#2434
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?