[PR #1729] [MERGED] fix: CEA-708 segmentation faults on MP4 files

## 📋 Pull Request Information **Original PR:** https://github.com/CCExtractor/ccextractor/pull/1729 **Author:** [@hrideshmg](https://github.com/hrideshmg) **Created:** 8/15/2025 **Status:** ✅ Merged **Merged:** 8/18/2025 **Merged by:** [@prateekmedia](https://github.com/prateekmedia) **Base:** `master` ← **Head:** `cea_708_fixes` --- ### 📝 Commits (2) - [`db4d2b2`](https://github.com/CCExtractor/ccextractor/commit/db4d2b20f5a78632b3480fc3e070622a5924ecc9) fix: CEA-708 segmentation faults on MP4 files - [`1693deb`](https://github.com/CCExtractor/ccextractor/commit/1693debddd7323d10f06863b29a47e11aa834136) chore: fix clippy errors ### 📊 Changes **3 files changed** (+6 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `docs/CHANGES.TXT` (+1 -0) 📝 `src/lib_ccx/mp4.c` (+3 -2) 📝 `src/rust/lib_ccxr/src/encoder/txt_helpers.rs` (+2 -2) </details> ### 📄 Description  **In raising this pull request, I confirm the following (please check boxes):** - [ ] I have read and understood the [contributors guide](https://github.com/CCExtractor/ccextractor/blob/master/.github/CONTRIBUTING.md). - [ ] I have checked that another pull request for this purpose does not exist. - [ ] I have considered, and confirmed that this submission will be valuable to others. - [ ] I accept that this submission may not be used, and the pull request closed at the will of the maintainer. - [ ] I give this submission freely, and claim no ownership to its content. - [x] **I have mentioned this change in the [changelog](https://github.com/CCExtractor/ccextractor/blob/master/docs/CHANGES.TXT).** **My familiarity with the project is as follows (check one):** - [ ] I have never used CCExtractor. - [ ] I have used CCExtractor just a couple of times. - [ ] I absolutely love CCExtractor, but have not contributed previously. - [x] I am an active contributor to CCExtractor. --- Certain MP4 files under the general category have been segfaulting on the sample platform. The cause was a null pointer dereference in an unsafe rust block [here](https://github.com/hrideshmg/ccextractor/blob/cea_708_fixes/src/rust/src/decoder/mod.rs#L48). The issue was that this particular variable is populated quite late in the MP4 processing chain and hence is sometimes missed. I've modified the code so that its populated right after declaration to fix it. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

claunia commented

2026-01-29 17:22:11 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/CCExtractor/ccextractor/pull/1729
Author: @hrideshmg
Created: 8/15/2025
Status: ✅ Merged
Merged: 8/18/2025
Merged by: @prateekmedia

Base: master ← Head: cea_708_fixes

📝 Commits (2)

db4d2b2 fix: CEA-708 segmentation faults on MP4 files
1693deb chore: fix clippy errors

📊 Changes

3 files changed (+6 additions, -4 deletions)

View changed files

📝 docs/CHANGES.TXT (+1 -0)
📝 src/lib_ccx/mp4.c (+3 -2)
📝 src/rust/lib_ccxr/src/encoder/txt_helpers.rs (+2 -2)

📄 Description

In raising this pull request, I confirm the following (please check boxes):

I have read and understood the contributors guide.
I have checked that another pull request for this purpose does not exist.
I have considered, and confirmed that this submission will be valuable to others.
I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
I give this submission freely, and claim no ownership to its content.
I have mentioned this change in the changelog.

My familiarity with the project is as follows (check one):

I have never used CCExtractor.
I have used CCExtractor just a couple of times.
I absolutely love CCExtractor, but have not contributed previously.
I am an active contributor to CCExtractor.

Certain MP4 files under the general category have been segfaulting on the sample platform. The cause was a null pointer dereference in an unsafe rust block here.

The issue was that this particular variable is populated quite late in the MP4 processing chain and hence is sometimes missed. I've modified the code so that its populated right after declaration to fix it.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

claunia added the pull-request label 2026-01-29 17:22:11 +00:00

[PR #1729] [MERGED] fix: CEA-708 segmentation faults on MP4 files #2448

📋 Pull Request Information

📝 Commits (2)

📊 Changes

📄 Description