starred/ccextractor
1
0
Fork 0
mirror of https://github.com/CCExtractor/ccextractor.git synced 2026-07-08 18:06:30 +00:00
Code Issues 1.5k Packages Projects Releases 21 Wiki Activity

[PR #1737] [MERGED] [FEAT] Removed the share module #2460

New Issue
Open
opened 2026-01-29 17:22:16 +00:00 by claunia · 0 comments
claunia commented 2026-01-29 17:22:16 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/CCExtractor/ccextractor/pull/1737
Author: @steel-bucket
Created: 8/23/2025
Status: ✅ Merged
Merged: 8/24/2025
Merged by: @prateekmedia

Base: master ← Head: remove-share-module

📝 Commits (10+)

  • 90578ea replaced nanomsg with nanomsg_sys
  • da6b1e5 feat: Share Module - squash commits
  • d8dd4c9 Share Module: Added Documentation
  • 1d8b363 Share Module: Removed Sharing Service
  • b9cb261 Merge branch 'master' into migration-share-module
  • 20a32a5 Share: formatting issues
  • 009febe Share: failing CI
  • c3e4717 Share: failing CI
  • a0b2ca2 Share: Removed protobuf
  • 25eb707 Share Module: Update CHANGES.txt

📊 Changes

40 files changed (+16 additions, -5716 deletions)

View changed files

📝 .gitignore (+0 -2)
📝 docs/CHANGES.TXT (+1 -0)
📝 docs/using_cmake_build.txt (+1 -4)
📝 linux/Makefile.am (+1 -7)
📝 linux/build (+2 -3)
📝 linux/module_generator (+1 -2)
📝 mac/Makefile.am (+1 -7)
📝 mac/build.command (+2 -3)
📝 src/BUILD (+1 -2)
📝 src/CMakeLists.txt (+0 -18)
📝 src/ccextractor.c (+0 -25)
📝 src/ccextractor.h (+0 -1)
📝 src/lib_ccx/BUILD (+2 -4)
📝 src/lib_ccx/CMakeLists.txt (+0 -3)
📝 src/lib_ccx/ccx_common_constants.h (+0 -3)
📝 src/lib_ccx/ccx_common_option.c (+0 -7)
📝 src/lib_ccx/ccx_common_option.h (+0 -11)
📝 src/lib_ccx/ccx_encoders_common.c (+0 -8)
📝 src/lib_ccx/ccx_encoders_splitbysentence.c (+0 -4)
📝 src/lib_ccx/ccx_encoders_transcript.c (+0 -4)

...and 20 more files

📄 Description

In raising this pull request, I confirm the following (please check boxes):

  • I have read and understood the contributors guide.
  • I have checked that another pull request for this purpose does not exist.
  • I have considered, and confirmed that this submission will be valuable to others.
  • I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  • I give this submission freely, and claim no ownership to its content.
  • I have mentioned this change in the changelog.

My familiarity with the project is as follows (check one):

  • I have never used CCExtractor.
  • I have used CCExtractor just a couple of times.
  • I absolutely love CCExtractor, but have not contributed previously.
  • I am an active contributor to CCExtractor.

Removes the share module and the sharing service.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/CCExtractor/ccextractor/pull/1737 **Author:** [@steel-bucket](https://github.com/steel-bucket) **Created:** 8/23/2025 **Status:** ✅ Merged **Merged:** 8/24/2025 **Merged by:** [@prateekmedia](https://github.com/prateekmedia) **Base:** `master` ← **Head:** `remove-share-module` --- ### 📝 Commits (10+) - [`90578ea`](https://github.com/CCExtractor/ccextractor/commit/90578eaf9dfe3dd0a3c469819317df449a2f97e1) replaced nanomsg with nanomsg_sys - [`da6b1e5`](https://github.com/CCExtractor/ccextractor/commit/da6b1e51b29e5683aacd460b29c37745392e5f2e) feat: Share Module - squash commits - [`d8dd4c9`](https://github.com/CCExtractor/ccextractor/commit/d8dd4c9de5101b8325765407236b0ef7a34cd36a) Share Module: Added Documentation - [`1d8b363`](https://github.com/CCExtractor/ccextractor/commit/1d8b36309effbcbdf9598bdf60a5b50bc898f1c3) Share Module: Removed Sharing Service - [`b9cb261`](https://github.com/CCExtractor/ccextractor/commit/b9cb261adcd4879c38e7fa3a44c487ff79d29d4c) Merge branch 'master' into migration-share-module - [`20a32a5`](https://github.com/CCExtractor/ccextractor/commit/20a32a5b53bf688aa86326d5151ed1a4b0b4fa22) Share: formatting issues - [`009febe`](https://github.com/CCExtractor/ccextractor/commit/009febeab360effc1b1169a9d8a56139274d3f16) Share: failing CI - [`c3e4717`](https://github.com/CCExtractor/ccextractor/commit/c3e471784594a581cd66a68723003da6fc50d3e5) Share: failing CI - [`a0b2ca2`](https://github.com/CCExtractor/ccextractor/commit/a0b2ca28c96357465d0d9154d94a1b53280a44c1) Share: Removed protobuf - [`25eb707`](https://github.com/CCExtractor/ccextractor/commit/25eb7071f3ffd469c169fd0c95d03087dfd83ffa) Share Module: Update CHANGES.txt ### 📊 Changes **40 files changed** (+16 additions, -5716 deletions) <details> <summary>View changed files</summary> 📝 `.gitignore` (+0 -2) 📝 `docs/CHANGES.TXT` (+1 -0) 📝 `docs/using_cmake_build.txt` (+1 -4) 📝 `linux/Makefile.am` (+1 -7) 📝 `linux/build` (+2 -3) 📝 `linux/module_generator` (+1 -2) 📝 `mac/Makefile.am` (+1 -7) 📝 `mac/build.command` (+2 -3) 📝 `src/BUILD` (+1 -2) 📝 `src/CMakeLists.txt` (+0 -18) 📝 `src/ccextractor.c` (+0 -25) 📝 `src/ccextractor.h` (+0 -1) 📝 `src/lib_ccx/BUILD` (+2 -4) 📝 `src/lib_ccx/CMakeLists.txt` (+0 -3) 📝 `src/lib_ccx/ccx_common_constants.h` (+0 -3) 📝 `src/lib_ccx/ccx_common_option.c` (+0 -7) 📝 `src/lib_ccx/ccx_common_option.h` (+0 -11) 📝 `src/lib_ccx/ccx_encoders_common.c` (+0 -8) 📝 `src/lib_ccx/ccx_encoders_splitbysentence.c` (+0 -4) 📝 `src/lib_ccx/ccx_encoders_transcript.c` (+0 -4) _...and 20 more files_ </details> ### 📄 Description <!-- Please prefix your pull request with one of the following: **[FEATURE]** **[FIX]** **[IMPROVEMENT]**. --> **In raising this pull request, I confirm the following (please check boxes):** - [x] I have read and understood the [contributors guide](https://github.com/CCExtractor/ccextractor/blob/master/.github/CONTRIBUTING.md). - [x] I have checked that another pull request for this purpose does not exist. - [x] I have considered, and confirmed that this submission will be valuable to others. - [x] I accept that this submission may not be used, and the pull request closed at the will of the maintainer. - [x] I give this submission freely, and claim no ownership to its content. - [ ] **I have mentioned this change in the [changelog](https://github.com/CCExtractor/ccextractor/blob/master/docs/CHANGES.TXT).** **My familiarity with the project is as follows (check one):** - [ ] I have never used CCExtractor. - [ ] I have used CCExtractor just a couple of times. - [ ] I absolutely love CCExtractor, but have not contributed previously. - [x] I am an active contributor to CCExtractor. --- Removes the share module and the sharing service. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-29 17:22:16 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
CEA-708
difficulty: easy
difficulty: hard
difficulty: medium
DTMB
DVB
enhancement
enhancement
Flutter GUI
GCI19
good-first-task
GSoC 2021
GSOC-2023
GSOC-2023
GSOC-2023
GSoC-related
Hacktoberfest
HardsubX
help wanted
invalid
JokerTV
Mac / OSX
more-info-needed
needs-commercial-sponsor
needs-commercial-sponsor
needs-commercial-sponsor
needs-confirmation-of-being-broken
OCR
pull-request
Mirrored from GitHub Pull Request
 Python
regression
Rust
teletext
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/ccextractor#2460
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?