[PR #1745] [MERGED] [FIX] add mac-ocr-hardsubx workflow & ffmpeg variants support #2469

Open
opened 2026-01-29 17:22:18 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/CCExtractor/ccextractor/pull/1745
Author: @prateekmedia
Created: 9/6/2025
Status: Merged
Merged: 11/3/2025
Merged by: @prateekmedia

Base: masterHead: hardsubx_patch


📝 Commits (10+)

  • 4e96e5f Fix critical hardsubx OCR bugs affecting accuracy and stability
  • 469debd Fix CLI parameters and add platform-specific paths for OCR
  • 660d524 Configure rsmpeg for platform-specific FFmpeg versions
  • 828a9cf Update build scripts to support FFmpeg version selection
  • b0529d8 Update CI workflows and Windows configuration
  • 7d94a15 Update COMPILATION.md with FFmpeg version configuration
  • b94301d fix: update version of rsmpeg
  • 1399b2a fix: revert to ffmpeg6 for windows
  • 2624d8d fix: toml
  • 0787279 Merge remote-tracking branch 'origin/master' into hardsubx_patch

📊 Changes

10 files changed (+463 additions, -120 deletions)

View changed files

📝 .github/workflows/build_mac.yml (+16 -0)
📝 docs/COMPILATION.MD (+47 -8)
📝 linux/build (+6 -1)
📝 mac/build.command (+90 -2)
📝 src/lib_ccx/ocr.c (+1 -0)
📝 src/rust/Cargo.lock (+243 -97)
📝 src/rust/Cargo.toml (+13 -3)
📝 src/rust/build.rs (+33 -0)
📝 src/rust/src/args.rs (+8 -8)
📝 windows/rust.bat (+6 -1)

📄 Description

In raising this pull request, I confirm the following (please check boxes):

  • I have read and understood the contributors guide.
  • I have checked that another pull request for this purpose does not exist.
  • I have considered, and confirmed that this submission will be valuable to others.
  • I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  • I give this submission freely, and claim no ownership to its content.
  • I have mentioned this change in the changelog.

My familiarity with the project is as follows (check one):

  • I have never used CCExtractor.
  • I have used CCExtractor just a couple of times.
  • I absolutely love CCExtractor, but have not contributed previously.
  • I am an active contributor to CCExtractor.

Fix

  • Update params and there doc

Mac OS:

  • Fix FFMpeg, tesseract compilation
  • Re-add Mac os build hardsubx workflow

FFMpeg used in workflow:

  • MacOS: 8.*
  • Windows: 6.* (pinned VCPKG supports this)
  • Linux: 6.* (Latest ubuntu runner supports this)

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/CCExtractor/ccextractor/pull/1745 **Author:** [@prateekmedia](https://github.com/prateekmedia) **Created:** 9/6/2025 **Status:** ✅ Merged **Merged:** 11/3/2025 **Merged by:** [@prateekmedia](https://github.com/prateekmedia) **Base:** `master` ← **Head:** `hardsubx_patch` --- ### 📝 Commits (10+) - [`4e96e5f`](https://github.com/CCExtractor/ccextractor/commit/4e96e5fb59c68d8d935c10f0b94fd50e73872671) Fix critical hardsubx OCR bugs affecting accuracy and stability - [`469debd`](https://github.com/CCExtractor/ccextractor/commit/469debdbf4f4941d30cafc0bf84c299e9fc84766) Fix CLI parameters and add platform-specific paths for OCR - [`660d524`](https://github.com/CCExtractor/ccextractor/commit/660d524494ab2cc9e8c55752014cfe10514ca8f3) Configure rsmpeg for platform-specific FFmpeg versions - [`828a9cf`](https://github.com/CCExtractor/ccextractor/commit/828a9cf2087ddfaff3250e7a8fa2ad3a0d657848) Update build scripts to support FFmpeg version selection - [`b0529d8`](https://github.com/CCExtractor/ccextractor/commit/b0529d8f1753ccaf330986a12fd0c03f2de45d30) Update CI workflows and Windows configuration - [`7d94a15`](https://github.com/CCExtractor/ccextractor/commit/7d94a15c463ea5b9e94c33f377299aa89cccc2f1) Update COMPILATION.md with FFmpeg version configuration - [`b94301d`](https://github.com/CCExtractor/ccextractor/commit/b94301db609dc99e5bd9417ff7f4e08cefa74094) fix: update version of rsmpeg - [`1399b2a`](https://github.com/CCExtractor/ccextractor/commit/1399b2ac8b496293baa10a0d9399a041c819a663) fix: revert to ffmpeg6 for windows - [`2624d8d`](https://github.com/CCExtractor/ccextractor/commit/2624d8d6b41da0dd52f1f59a2530990cc8102cbf) fix: toml - [`0787279`](https://github.com/CCExtractor/ccextractor/commit/0787279d4f6ef30a6df93756903c30f724e78ad1) Merge remote-tracking branch 'origin/master' into hardsubx_patch ### 📊 Changes **10 files changed** (+463 additions, -120 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/build_mac.yml` (+16 -0) 📝 `docs/COMPILATION.MD` (+47 -8) 📝 `linux/build` (+6 -1) 📝 `mac/build.command` (+90 -2) 📝 `src/lib_ccx/ocr.c` (+1 -0) 📝 `src/rust/Cargo.lock` (+243 -97) 📝 `src/rust/Cargo.toml` (+13 -3) 📝 `src/rust/build.rs` (+33 -0) 📝 `src/rust/src/args.rs` (+8 -8) 📝 `windows/rust.bat` (+6 -1) </details> ### 📄 Description **In raising this pull request, I confirm the following (please check boxes):** - [x] I have read and understood the [contributors guide](https://github.com/CCExtractor/ccextractor/blob/master/.github/CONTRIBUTING.md). - [x] I have checked that another pull request for this purpose does not exist. - [x] I have considered, and confirmed that this submission will be valuable to others. - [x] I accept that this submission may not be used, and the pull request closed at the will of the maintainer. - [x] I give this submission freely, and claim no ownership to its content. - [ ] **I have mentioned this change in the [changelog](https://github.com/CCExtractor/ccextractor/blob/master/docs/CHANGES.TXT).** **My familiarity with the project is as follows (check one):** - [ ] I have never used CCExtractor. - [ ] I have used CCExtractor just a couple of times. - [ ] I absolutely love CCExtractor, but have not contributed previously. - [x] I am an active contributor to CCExtractor. --- ## Fix - Update params and there doc ## Mac OS: - Fix FFMpeg, tesseract compilation - Re-add Mac os build hardsubx workflow ## FFMpeg used in workflow: - MacOS: `8.*` - Windows: `6.*` (pinned VCPKG supports this) - Linux: `6.*` (Latest ubuntu runner supports this) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-29 17:22:18 +00:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/ccextractor#2469