[PR #1761] build: add CMake options for system library linking #2485

New Issue

claunia · 2026-01-29T17:22:24Z

claunia commented

2026-01-29 17:22:24 +00:00

📋 Pull Request Information

Original PR: https://github.com/CCExtractor/ccextractor/pull/1761
Author: @DhanushVarma-2
Created: 11/9/2025
Status: 🔄 Open

Base: master ← Head: system-libs-1718

📝 Commits (4)

1515f5c build: add tesseract library linking for hardsubx feature
3501ff9 build: add CMake options for system library linking
fa57039 build: fix CMake conditional nesting and clean system library switches
fd5b365 build: fix system library CMake options and cleanup logic

📊 Changes

1 file changed (+78 additions, -58 deletions)

View changed files

📝 src/CMakeLists.txt (+78 -58)

📄 Description

Partial fix for #1718

Adds CMake options for system library linking as foundation for full implementation:

USE_SYSTEM_ZLIB - Use system zlib instead of bundled
USE_SYSTEM_LIBPNG - Use system libpng instead of bundled
USE_SYSTEM_FREETYPE - Use system freetype instead of bundled

Current behaviour: Options are OFF by default, existing bundled libraries still used
Future work: Implement actual system library detection and linking

This is phase 1 of addressing #1718 - adding the configuration framework before implementing the full system library support.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/CCExtractor/ccextractor/pull/1761 **Author:** [@DhanushVarma-2](https://github.com/DhanushVarma-2) **Created:** 11/9/2025 **Status:** 🔄 Open **Base:** `master` ← **Head:** `system-libs-1718` --- ### 📝 Commits (4) - [`1515f5c`](https://github.com/CCExtractor/ccextractor/commit/1515f5c1be01d8da35e7f5a261be5db61cf3041d) build: add tesseract library linking for hardsubx feature - [`3501ff9`](https://github.com/CCExtractor/ccextractor/commit/3501ff9a25d28f26fb6fef7e887bd9d694af67bf) build: add CMake options for system library linking - [`fa57039`](https://github.com/CCExtractor/ccextractor/commit/fa570399cb3be57f1a2e95dd95399fd404997d18) build: fix CMake conditional nesting and clean system library switches - [`fd5b365`](https://github.com/CCExtractor/ccextractor/commit/fd5b365c34caeab58dbab3d78058347b9edba07b) build: fix system library CMake options and cleanup logic ### 📊 Changes **1 file changed** (+78 additions, -58 deletions) <details> <summary>View changed files</summary> 📝 `src/CMakeLists.txt` (+78 -58) </details> ### 📄 Description Partial fix for #1718 Adds CMake options for system library linking as foundation for full implementation: - USE_SYSTEM_ZLIB - Use system zlib instead of bundled - USE_SYSTEM_LIBPNG - Use system libpng instead of bundled - USE_SYSTEM_FREETYPE - Use system freetype instead of bundled Current behaviour: Options are OFF by default, existing bundled libraries still used Future work: Implement actual system library detection and linking This is phase 1 of addressing #1718 - adding the configuration framework before implementing the full system library support. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

claunia added the pull-request label 2026-01-29 17:22:24 +00:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/ccextractor#2485