[PR #1767] [CLOSED] fix(rust): revert is_multiple_of to maintain MSRV 1.54.0 #2490

New Issue

claunia · 2026-01-29T17:22:26Z

claunia commented

2026-01-29 17:22:26 +00:00

📋 Pull Request Information

Original PR: https://github.com/CCExtractor/ccextractor/pull/1767
Author: @DhanushVarma-2
Created: 11/21/2025
Status: ❌ Closed

Base: master ← Head: fix-rust-msrv-1765

📝 Commits (1)

a0aa9e4 fix(rust): revert is_multiple_of to maintain MSRV 1.54.0

📊 Changes

2 files changed (+2 additions, -1 deletions)

View changed files

➕ src/rust/clippy.toml (+1 -0)
📝 src/rust/src/es/pic.rs (+1 -1)

📄 Description

Reverts is_multiple_of(2) to stable % 2 == 0 check to maintain compatibility with Rust 1.54.0 (project MSRV)
Adds clippy.toml with msrv = '1.54.0' to prevent Clippy from suggesting APIs that aren't available in the MSRV

Fixes: #1765

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/CCExtractor/ccextractor/pull/1767 **Author:** [@DhanushVarma-2](https://github.com/DhanushVarma-2) **Created:** 11/21/2025 **Status:** ❌ Closed **Base:** `master` ← **Head:** `fix-rust-msrv-1765` --- ### 📝 Commits (1) - [`a0aa9e4`](https://github.com/CCExtractor/ccextractor/commit/a0aa9e4616c6e37fbe4734fdc175fa9ae54eda00) fix(rust): revert is_multiple_of to maintain MSRV 1.54.0 ### 📊 Changes **2 files changed** (+2 additions, -1 deletions) <details> <summary>View changed files</summary> ➕ `src/rust/clippy.toml` (+1 -0) 📝 `src/rust/src/es/pic.rs` (+1 -1) </details> ### 📄 Description - Reverts is_multiple_of(2) to stable % 2 == 0 check to maintain compatibility with Rust 1.54.0 (project MSRV) - Adds clippy.toml with msrv = '1.54.0' to prevent Clippy from suggesting APIs that aren't available in the MSRV Fixes: #1765 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

claunia added the pull-request label 2026-01-29 17:22:26 +00:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/ccextractor#2490