mirror of
https://github.com/CCExtractor/ccextractor.git
synced 2026-02-15 13:35:30 +00:00
ctrl-c not working in linux #255
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @cfsmp3 on GitHub (Jan 23, 2017).
ctrl-c (sigint) is not working on the linux version, which is quite annoying.
@Izaron commented on GitHub (Jan 24, 2017):
After removing this line all is OK - https://github.com/CCExtractor/ccextractor/blob/master/src/ccextractor.c#L154
But don't sure if we should just remove this line without understanding.
@saurabhshri commented on GitHub (Jan 24, 2017):
@Izaron Instead of deleting it, I think it will be better to appropriately handle it. For example, if we want to terminate it ASAP on receiving SIGINT, we can do this -> (https://github.com/CCExtractor/ccextractor/compare/master...saurabhshri:patch-2).
@cfsmp3 Please have a look at the above commit. Does this seem okay to you?
Edit : Here's how it looks. Whatever action you would recommend, we will write instead of
terminate_asap = 1;:NOW
PREV
@cfsmp3 commented on GitHub (Jan 24, 2017):
Both solutions are OK. The problem is that we're mixing different (and incompatible) ways to setup handlers. I've solved it by having 3 handlers that are setup in the same way.