[PR #1813] [CLOSED] Improve -out=report to show detected Teletext subtitle pages (Fixes #1034) #2553

New Issue

claunia · 2026-01-29T17:22:45Z

claunia commented

2026-01-29 17:22:45 +00:00

📋 Pull Request Information

Original PR: https://github.com/CCExtractor/ccextractor/pull/1813
Author: @Rahul-2k4
Created: 12/14/2025
Status: ❌ Closed

Base: master ← Head: fix-teletext-page-detection-in-report-mode-fixes-1034

📝 Commits (10+)

51b862f Add teletext report functionality to general_loop.c
95efa93 Initial plan
69672c8 Add changelog entry for Teletext report mode fix
dcc01e7 Merge pull request #1 from Rahul-2k4/copilot/fix-teletext-page-detection
349ca6a Initial plan
80f78f1 Initial plan for fixing formatting issues
8c2e54a Merge pull request #2 from Rahul-2k4/copilot/fix-formatting-issues
1ff7368 Initial plan
95661df Update vcpkg baseline to fix libxml2 hash mismatch
d6b7052 Merge pull request #3 from Rahul-2k4/copilot/update-libxml2-hash

📊 Changes

10 files changed (+187 additions, -88 deletions)

View changed files

📝 docs/CHANGES.TXT (+1 -0)
📝 docs/OCR.md (+16 -0)
📝 src/lib_ccx/ccx_encoders_common.c (+27 -4)
📝 src/lib_ccx/general_loop.c (+19 -6)
📝 src/lib_ccx/hardsubx_decoder.c (+28 -7)
📝 src/lib_ccx/ocr.c (+40 -4)
📝 src/lib_ccx/telxcc.c (+5 -1)
📝 src/rust/Cargo.lock (+9 -54)
📝 src/rust/src/hardsubx/classifier.rs (+31 -1)
📝 windows/vcpkg.json (+11 -11)

📄 Description

This PR fixes Issue #1034, where running CCExtractor with -out=report does not list Teletext pages that contain possible subtitles, even though the same pages are correctly detected during normal extraction.

In report-only mode, CCExtractor skips Teletext PES packet processing because the encoder context (enc_ctx) is not created. Since subtitle-page detection happens inside Teletext packet parsing, no pages are recorded in seen_sub_page[], resulting in an empty Pages With Subtitles: field in the final report.

This PR enables Teletext detection in -out=report mode and ensures proper memory cleanup when the encoder is absent.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/CCExtractor/ccextractor/pull/1813 **Author:** [@Rahul-2k4](https://github.com/Rahul-2k4) **Created:** 12/14/2025 **Status:** ❌ Closed **Base:** `master` ← **Head:** `fix-teletext-page-detection-in-report-mode-fixes-1034` --- ### 📝 Commits (10+) - [`51b862f`](https://github.com/CCExtractor/ccextractor/commit/51b862f7c52505799e778e6e34cf4d7dc650e46f) Add teletext report functionality to general_loop.c - [`95efa93`](https://github.com/CCExtractor/ccextractor/commit/95efa9327b2a8fda0a9bf48fdfae15b391e1b12f) Initial plan - [`69672c8`](https://github.com/CCExtractor/ccextractor/commit/69672c813c96671598c25728b4da86e2901e2820) Add changelog entry for Teletext report mode fix - [`dcc01e7`](https://github.com/CCExtractor/ccextractor/commit/dcc01e786e4d1207b66c2ecb0a8829499f80c5b6) Merge pull request #1 from Rahul-2k4/copilot/fix-teletext-page-detection - [`349ca6a`](https://github.com/CCExtractor/ccextractor/commit/349ca6aaec0a878471068dd5cb24cb1f73196843) Initial plan - [`80f78f1`](https://github.com/CCExtractor/ccextractor/commit/80f78f171de56e9f8658a607e739071efff5d3b9) Initial plan for fixing formatting issues - [`8c2e54a`](https://github.com/CCExtractor/ccextractor/commit/8c2e54ab4acac93ba02ec7e4279d41296fad4893) Merge pull request #2 from Rahul-2k4/copilot/fix-formatting-issues - [`1ff7368`](https://github.com/CCExtractor/ccextractor/commit/1ff73685558199bf22f6c5f8fa14e2fddf1617a2) Initial plan - [`95661df`](https://github.com/CCExtractor/ccextractor/commit/95661dfabfceb99005af9cb4db625046a3aff002) Update vcpkg baseline to fix libxml2 hash mismatch - [`d6b7052`](https://github.com/CCExtractor/ccextractor/commit/d6b70529e1b6bcc0f91b4f0232b613aa3094a784) Merge pull request #3 from Rahul-2k4/copilot/update-libxml2-hash ### 📊 Changes **10 files changed** (+187 additions, -88 deletions) <details> <summary>View changed files</summary> 📝 `docs/CHANGES.TXT` (+1 -0) 📝 `docs/OCR.md` (+16 -0) 📝 `src/lib_ccx/ccx_encoders_common.c` (+27 -4) 📝 `src/lib_ccx/general_loop.c` (+19 -6) 📝 `src/lib_ccx/hardsubx_decoder.c` (+28 -7) 📝 `src/lib_ccx/ocr.c` (+40 -4) 📝 `src/lib_ccx/telxcc.c` (+5 -1) 📝 `src/rust/Cargo.lock` (+9 -54) 📝 `src/rust/src/hardsubx/classifier.rs` (+31 -1) 📝 `windows/vcpkg.json` (+11 -11) </details> ### 📄 Description This PR fixes Issue #1034, where running CCExtractor with -out=report does not list Teletext pages that contain possible subtitles, even though the same pages are correctly detected during normal extraction. In report-only mode, CCExtractor skips Teletext PES packet processing because the encoder context (enc_ctx) is not created. Since subtitle-page detection happens inside Teletext packet parsing, no pages are recorded in seen_sub_page[], resulting in an empty Pages With Subtitles: field in the final report. This PR enables Teletext detection in -out=report mode and ensures proper memory cleanup when the encoder is absent. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

claunia added the pull-request label 2026-01-29 17:22:45 +00:00

claunia closed this issue

2026-01-29 17:22:45 +00:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/ccextractor#2553