[PR #1819] [MERGED] style: use CCX_STREAM_TYPE_VIDEO_HEVC enum instead of raw 0x24 #2563

Open
opened 2026-01-29 17:22:47 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/CCExtractor/ccextractor/pull/1819
Author: @cfsmp3
Created: 12/14/2025
Status: Merged
Merged: 12/14/2025
Merged by: @cfsmp3

Base: masterHead: fix/hevc-enum-consistency


📝 Commits (1)

  • 866b897 style: use CCX_STREAM_TYPE_VIDEO_HEVC enum instead of raw 0x24

📊 Changes

1 file changed (+4 additions, -5 deletions)

View changed files

📝 src/lib_ccx/ts_tables.c (+4 -5)

📄 Description

Summary

Follow-up to PR #1769 - use the defined enum constant CCX_STREAM_TYPE_VIDEO_HEVC instead of the magic number 0x24 for better code maintainability and consistency.

Changes

  • Replace 0x24 with CCX_STREAM_TYPE_VIDEO_HEVC in PMT parsing condition
  • Simplify get_printable_stream_type() case statement by removing redundant assignment (the enum value passes through unchanged)
  • Update comment to list all three supported video stream types

Testing

Tested with ATSC 3.0 sample from issue #1639 - HEVC streams are still properly recognized.

🤖 Generated with Claude Code


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/CCExtractor/ccextractor/pull/1819 **Author:** [@cfsmp3](https://github.com/cfsmp3) **Created:** 12/14/2025 **Status:** ✅ Merged **Merged:** 12/14/2025 **Merged by:** [@cfsmp3](https://github.com/cfsmp3) **Base:** `master` ← **Head:** `fix/hevc-enum-consistency` --- ### 📝 Commits (1) - [`866b897`](https://github.com/CCExtractor/ccextractor/commit/866b897f6d8d7ead21f9ef707df053fa48ef3ab9) style: use CCX_STREAM_TYPE_VIDEO_HEVC enum instead of raw 0x24 ### 📊 Changes **1 file changed** (+4 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `src/lib_ccx/ts_tables.c` (+4 -5) </details> ### 📄 Description ## Summary Follow-up to PR #1769 - use the defined enum constant `CCX_STREAM_TYPE_VIDEO_HEVC` instead of the magic number `0x24` for better code maintainability and consistency. ## Changes - Replace `0x24` with `CCX_STREAM_TYPE_VIDEO_HEVC` in PMT parsing condition - Simplify `get_printable_stream_type()` case statement by removing redundant assignment (the enum value passes through unchanged) - Update comment to list all three supported video stream types ## Testing Tested with ATSC 3.0 sample from issue #1639 - HEVC streams are still properly recognized. 🤖 Generated with [Claude Code](https://claude.com/claude-code) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-29 17:22:47 +00:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/ccextractor#2563