[PR #1831] [CLOSED] MXF: improve ANC/VANC caption detection (fix #1647) #2586

New Issue

claunia · 2026-01-29T17:22:57Z

claunia commented

2026-01-29 17:22:57 +00:00

📋 Pull Request Information

Original PR: https://github.com/CCExtractor/ccextractor/pull/1831
Author: @03-SudheshnaReddy
Created: 12/15/2025
Status: ❌ Closed

Base: master ← Head: fix/mxf-anc-diagnostics

📝 Commits (1)

e384ed8 MXF: improve ANC/VANC caption detection (fix #1647)

📊 Changes

2 files changed (+48 additions, -15 deletions)

View changed files

📝 src/lib_ccx/ccx_demuxer_mxf.c (+47 -15)
📝 src/lib_ccx/ccx_demuxer_mxf.h (+1 -0)

📄 Description

Fixes #1647

What I changed

Improved MXF ANC/VANC parsing logic so caption packets are not silently skipped
Added stricter handling and validation around DID / SDID detection in VANC data
Ensured both CEA-608 and CEA-708 payloads are recognized when present
Minor defensive checks to avoid early exits when valid ANC data exists
Changes are strictly limited to the MXF demuxer (ccx_demuxer_mxf.c/.h)

Why

CCExtractor currently reports “No subtitles found” for some MXF files that clearly contain captions, as confirmed by Premiere Pro.
Investigation showed that ANC/VANC caption packets can be present but not detected due to demuxer-level logic gaps.

This PR aims to ensure CCExtractor correctly identifies and processes those caption packets.

Scope

No changes to Rust code, build scripts, or external dependencies
No behavior changes outside MXF demuxing

Notes

First-time contributor — feedback very welcome
My local Windows build environment is unstable, so I focused on a minimal, reviewable fix based on code inspection and format behavior
Happy to refine, add logging, or adjust based on maintainer guidance

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/CCExtractor/ccextractor/pull/1831 **Author:** [@03-SudheshnaReddy](https://github.com/03-SudheshnaReddy) **Created:** 12/15/2025 **Status:** ❌ Closed **Base:** `master` ← **Head:** `fix/mxf-anc-diagnostics` --- ### 📝 Commits (1) - [`e384ed8`](https://github.com/CCExtractor/ccextractor/commit/e384ed8418dc285e914fa169ba88c6bc92635a4a) MXF: improve ANC/VANC caption detection (fix #1647) ### 📊 Changes **2 files changed** (+48 additions, -15 deletions) <details> <summary>View changed files</summary> 📝 `src/lib_ccx/ccx_demuxer_mxf.c` (+47 -15) 📝 `src/lib_ccx/ccx_demuxer_mxf.h` (+1 -0) </details> ### 📄 Description Fixes #1647 ### What I changed - Improved MXF ANC/VANC parsing logic so caption packets are not silently skipped - Added stricter handling and validation around DID / SDID detection in VANC data - Ensured both CEA-608 and CEA-708 payloads are recognized when present - Minor defensive checks to avoid early exits when valid ANC data exists - Changes are strictly limited to the MXF demuxer (`ccx_demuxer_mxf.c/.h`) ### Why CCExtractor currently reports “No subtitles found” for some MXF files that clearly contain captions, as confirmed by Premiere Pro. Investigation showed that ANC/VANC caption packets can be present but not detected due to demuxer-level logic gaps. This PR aims to ensure CCExtractor correctly identifies and processes those caption packets. ### Scope - No changes to Rust code, build scripts, or external dependencies - No behavior changes outside MXF demuxing ### Notes - First-time contributor — feedback very welcome - My local Windows build environment is unstable, so I focused on a minimal, reviewable fix based on code inspection and format behavior - Happy to refine, add logging, or adjust based on maintainer guidance --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

claunia added the pull-request label 2026-01-29 17:22:57 +00:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/ccextractor#2586