[PR #1891] [CLOSED] Fix infinite binary output when processing .ts files with no subtitles #2678

New Issue

claunia · 2026-01-29T17:23:23Z

claunia commented

2026-01-29 17:23:23 +00:00

📋 Pull Request Information

Original PR: https://github.com/CCExtractor/ccextractor/pull/1891
Author: @tusharbhatt7
Created: 12/24/2025
Status: ❌ Closed

Base: master ← Head: fix-infinite-binary-output-1754

📝 Commits (1)

64f8435 Fix infinite binary output when processing .ts files with no subtitles

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 src/lib_ccx/ts_functions.c (+1 -1)

📄 Description

Problem
When CCExtractor processes a .ts file that contains no subtitles, it produces infinite binary/hex-like output in the terminal instead of stopping gracefully.

Solution
Removed the dump() call in copy_capbuf_demux_data() for CCX_PRIVATE_MPEG2_CC buffer type. This dump was using CCX_DMT_GENERIC_NOTICES which is enabled by default, causing continuous binary output to the terminal.

Changes

Removed dump(CCX_DMT_GENERIC_NOTICES, ...) call from copy_capbuf_demux_data() function
Added explanatory comment about why the dump was removed
Function still processes data correctly, just without the debug output

Testing

Verified that the problematic dump call is removed
Code still handles CCX_PRIVATE_MPEG2_CC buffer type correctly
No infinite binary output when processing TS files with no subtitles

Fixes #1754

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/CCExtractor/ccextractor/pull/1891 **Author:** [@tusharbhatt7](https://github.com/tusharbhatt7) **Created:** 12/24/2025 **Status:** ❌ Closed **Base:** `master` ← **Head:** `fix-infinite-binary-output-1754` --- ### 📝 Commits (1) - [`64f8435`](https://github.com/CCExtractor/ccextractor/commit/64f8435b49f1b431de022919226f5b5ffbb4b6df) Fix infinite binary output when processing .ts files with no subtitles ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `src/lib_ccx/ts_functions.c` (+1 -1) </details> ### 📄 Description Problem When CCExtractor processes a .ts file that contains no subtitles, it produces infinite binary/hex-like output in the terminal instead of stopping gracefully. Solution Removed the `dump()` call in `copy_capbuf_demux_data()` for `CCX_PRIVATE_MPEG2_CC` buffer type. This dump was using `CCX_DMT_GENERIC_NOTICES` which is enabled by default, causing continuous binary output to the terminal. Changes - Removed `dump(CCX_DMT_GENERIC_NOTICES, ...)` call from `copy_capbuf_demux_data()` function - Added explanatory comment about why the dump was removed - Function still processes data correctly, just without the debug output Testing - Verified that the problematic dump call is removed - Code still handles `CCX_PRIVATE_MPEG2_CC` buffer type correctly - No infinite binary output when processing TS files with no subtitles Fixes #1754 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

claunia added the pull-request label 2026-01-29 17:23:23 +00:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/ccextractor#2678