starred/ccextractor
1
0
Fork 0
mirror of https://github.com/CCExtractor/ccextractor.git synced 2026-02-03 21:23:48 +00:00
Code Issues 1.5k Packages Projects Releases 20 Wiki Activity

[PR #1891] Fix infinite binary output when processing .ts files with no subtitles #2682

New Issue
Open
opened 2026-01-29 17:23:24 +00:00 by claunia · 0 comments
claunia commented 2026-01-29 17:23:24 +00:00
Owner
Copy Link

Original Pull Request: https://github.com/CCExtractor/ccextractor/pull/1891

State: closed
Merged: No

Problem
When CCExtractor processes a .ts file that contains no subtitles, it produces infinite binary/hex-like output in the terminal instead of stopping gracefully.

Solution
Removed the dump() call in copy_capbuf_demux_data() for CCX_PRIVATE_MPEG2_CC buffer type. This dump was using CCX_DMT_GENERIC_NOTICES which is enabled by default, causing continuous binary output to the terminal.

Changes

  • Removed dump(CCX_DMT_GENERIC_NOTICES, ...) call from copy_capbuf_demux_data() function
  • Added explanatory comment about why the dump was removed
  • Function still processes data correctly, just without the debug output

Testing

  • Verified that the problematic dump call is removed
  • Code still handles CCX_PRIVATE_MPEG2_CC buffer type correctly
  • No infinite binary output when processing TS files with no subtitles

Fixes #1754

**Original Pull Request:** https://github.com/CCExtractor/ccextractor/pull/1891 **State:** closed **Merged:** No --- Problem When CCExtractor processes a .ts file that contains no subtitles, it produces infinite binary/hex-like output in the terminal instead of stopping gracefully. Solution Removed the `dump()` call in `copy_capbuf_demux_data()` for `CCX_PRIVATE_MPEG2_CC` buffer type. This dump was using `CCX_DMT_GENERIC_NOTICES` which is enabled by default, causing continuous binary output to the terminal. Changes - Removed `dump(CCX_DMT_GENERIC_NOTICES, ...)` call from `copy_capbuf_demux_data()` function - Added explanatory comment about why the dump was removed - Function still processes data correctly, just without the debug output Testing - Verified that the problematic dump call is removed - Code still handles `CCX_PRIVATE_MPEG2_CC` buffer type correctly - No infinite binary output when processing TS files with no subtitles Fixes #1754
claunia added the pull-request label 2026-01-29 17:23:24 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
CEA-708
difficulty: easy
difficulty: hard
difficulty: medium
DTMB
DVB
enhancement
enhancement
Flutter GUI
GCI19
good-first-task
GSoC 2021
GSOC-2023
GSOC-2023
GSOC-2023
GSoC-related
Hacktoberfest
HardsubX
help wanted
invalid
JokerTV
Mac / OSX
more-info-needed
needs-commercial-sponsor
needs-commercial-sponsor
needs-commercial-sponsor
needs-confirmation-of-being-broken
OCR
pull-request
Mirrored from GitHub Pull Request
 Python
regression
Rust
teletext
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/ccextractor#2682
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?