[PR #1905] [FIX] Fix MSVC warning C4098: void function returning a value in networking.c #2697

New Issue

claunia · 2026-01-29T17:23:28Z

claunia commented

2026-01-29 17:23:28 +00:00

Original Pull Request: https://github.com/CCExtractor/ccextractor/pull/1905

State: closed
Merged: Yes

In raising this pull request, I confirm the following (please check boxes):

[x ] I have read and understood the contributors guide.
[x ] I have checked that another pull request for this purpose does not exist.
[x ] I have considered, and confirmed that this submission will be valuable to others.
[x ] I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
[x ] I give this submission freely, and claim no ownership to its content.
I have mentioned this change in the changelog.

My familiarity with the project is as follows (check one):

I have never used CCExtractor.
[x ] I have used CCExtractor just a couple of times.
I absolutely love CCExtractor, but have not contributed previously.
I am an active contributor to CCExtractor.

Description
This PR fixes multiple instances of compiler warning C4098 in src/lib_ccx/networking.c.
Several functions (connect_to_srv, net_send_header, etc.) were declared as void but were attempting to return values from internal function calls.

Changes

Casted the return values of the internal Rust functions to (void) to suppress MSVC warning C4098.
Removed the explicit return; statements to ensure the subsequent C implementation is correctly executed (fixing a logic error where the C fallback was being skipped).

Environment

Windows 11
MSVC / CMake

**Original Pull Request:** https://github.com/CCExtractor/ccextractor/pull/1905 **State:** closed **Merged:** Yes ---  **In raising this pull request, I confirm the following (please check boxes):** - [x ] I have read and understood the [contributors guide](https://github.com/CCExtractor/ccextractor/blob/master/.github/CONTRIBUTING.md). - [x ] I have checked that another pull request for this purpose does not exist. - [x ] I have considered, and confirmed that this submission will be valuable to others. - [x ] I accept that this submission may not be used, and the pull request closed at the will of the maintainer. - [x ] I give this submission freely, and claim no ownership to its content. - [ ] **I have mentioned this change in the [changelog](https://github.com/CCExtractor/ccextractor/blob/master/docs/CHANGES.TXT).** **My familiarity with the project is as follows (check one):** - [ ] I have never used CCExtractor. - [x ] I have used CCExtractor just a couple of times. - [ ] I absolutely love CCExtractor, but have not contributed previously. - [ ] I am an active contributor to CCExtractor. --- **Description** This PR fixes multiple instances of compiler warning C4098 in `src/lib_ccx/networking.c`. Several functions (`connect_to_srv`, `net_send_header`, etc.) were declared as `void` but were attempting to return values from internal function calls. **Changes** - Casted the return values of the internal Rust functions to (void) to suppress MSVC warning C4098. - Removed the explicit return; statements to ensure the subsequent C implementation is correctly executed (fixing a logic error where the C fallback was being skipped). **Environment** - Windows 11 - MSVC / CMake

claunia added the pull-request label 2026-01-29 17:23:28 +00:00

claunia closed this issue

2026-01-29 17:23:28 +00:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/ccextractor#2697