[PR #1912] Automatic extraction of multiple DVB subtitle streams (--split-dvb-subs) fixes#447 #1864 #2706

New Issue

claunia · 2026-01-29T17:23:31Z

claunia commented

2026-01-29 17:23:31 +00:00

Original Pull Request: https://github.com/CCExtractor/ccextractor/pull/1912

State: closed
Merged: Yes

In raising this pull request, I confirm the following (please check boxes):

I have read and understood the contributors guide
.

I have checked that another pull request for this purpose does not exist.
I have considered, and confirmed that this submission will be valuable to others.
I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
I give this submission freely, and claim no ownership to its content.
I have mentioned this change in the changelog

.

My familiarity with the project is as follows (check one):

I have never used CCExtractor.
I have used CCExtractor just a couple of times.
I absolutely love CCExtractor, but have not contributed previously.
I am an active contributor to CCExtractor.

Summary

This PR completes verification of Issue #447 and applies a few small but necessary fixes identified during review. The --split-dvb-subs feature is confirmed to work correctly with real DVB broadcast samples.

Key points

Verified multi-stream DVB subtitle extraction end-to-end using a real broadcast TS.

Applied 3 minor code-review fixes:

Fix escaped newline in DVB debug logging.
Remove hardcoded debug PID values.
Improve language-code validation to accept uppercase letters.
Confirmed legacy (non-split) behavior remains unaffected.

Test sample clarification

The originally referenced file (arte_multiaudio.ts) was not suitable for validation:
DVB subtitle streams were advertised in the PMT
No actual DVB subtitle bitmap packets were present
Testing was therefore redone using a proper broadcast capture containing real DVB subtitles:
https://tsduck.io/streams/france-dttv/tnt-uhf30-546MHz-2019-01-22.ts

Expected / observed behavior:

Separate output files are created per DVB subtitle stream.
Only streams that actually broadcast subtitle packets produce non-empty output.
Streams advertised in PMT but carrying no subtitle data result in empty files.
This matches normal DVB broadcast behavior and is not a bug.

Results:

Valid SRT output extracted ✔
Empty streams handled safely ✔
Invalid flag combinations rejected ✔
No crashes or regressions ✔

Fixes and verification for Issue #447.

**Original Pull Request:** https://github.com/CCExtractor/ccextractor/pull/1912 **State:** closed **Merged:** Yes --- In raising this pull request, I confirm the following (please check boxes): I have read and understood the [contributors guide](https://github.com/CCExtractor/ccextractor/blob/master/.github/CONTRIBUTING.md) . - [x] I have checked that another pull request for this purpose does not exist. - [x] I have considered, and confirmed that this submission will be valuable to others. - [ ] I accept that this submission may not be used, and the pull request closed at the will of the maintainer. - [ ] I give this submission freely, and claim no ownership to its content. - [x] I have mentioned this change in the [changelog](https://github.com/CCExtractor/ccextractor/blob/master/docs/CHANGES.TXT) . My familiarity with the project is as follows (check one): - [ ] I have never used CCExtractor. - [x] I have used CCExtractor just a couple of times. - [ ] I absolutely love CCExtractor, but have not contributed previously. - [x] I am an active contributor to CCExtractor. ______________________________________________________________________________________________________________________________________ ### **Summary** This PR completes verification of Issue #447 and applies a few small but necessary fixes identified during review. The --split-dvb-subs feature is confirmed to work correctly with real DVB broadcast samples. ### **Key points** Verified multi-stream DVB subtitle extraction end-to-end using a real broadcast TS. ### **Applied 3 minor code-review fixes:** - Fix escaped newline in DVB debug logging. - Remove hardcoded debug PID values. - Improve language-code validation to accept uppercase letters. - Confirmed legacy (non-split) behavior remains unaffected. _______________________________________________________________________________________________________________________________________ ### **Test sample clarification** - The originally referenced file (arte_multiaudio.ts) was not suitable for validation: - DVB subtitle streams were advertised in the PMT - No actual DVB subtitle bitmap packets were present - Testing was therefore redone using a proper broadcast capture containing real DVB subtitles: https://tsduck.io/streams/france-dttv/tnt-uhf30-546MHz-2019-01-22.ts _______________________________________________________________________________________________________________________________________ ### **Expected / observed behavior:** - Separate output files are created per DVB subtitle stream. - Only streams that actually broadcast subtitle packets produce non-empty output. - Streams advertised in PMT but carrying no subtitle data result in empty files. - This matches normal DVB broadcast behavior and is not a bug. _______________________________________________________________________________________________________________________________________ ### **Results:** - Valid SRT output extracted ✔ - Empty streams handled safely ✔ - Invalid flag combinations rejected ✔ - No crashes or regressions ✔ _______________________________________________________________________________________________________________________________________ ### **Related issue** Fixes and verification for Issue #447.

claunia added the pull-request label 2026-01-29 17:23:31 +00:00

claunia closed this issue

2026-01-29 17:23:31 +00:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/ccextractor#2706