[PR #1914] [FIX] Resolve unused variable warnings in ts_tables_epg.c #2712

New Issue

claunia · 2026-01-29T17:23:33Z

claunia commented

2026-01-29 17:23:33 +00:00

Original Pull Request: https://github.com/CCExtractor/ccextractor/pull/1914

State: closed
Merged: Yes

In raising this pull request, I confirm the following (please check boxes):

[x ] I have read and understood the contributors guide.
[x ] I have checked that another pull request for this purpose does not exist.
[x ] I have considered, and confirmed that this submission will be valuable to others.
[x ] I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
[x ] I give this submission freely, and claim no ownership to its content.
[ x] I have mentioned this change in the changelog.

My familiarity with the project is as follows (check one):

I have never used CCExtractor.
[x ] I have used CCExtractor just a couple of times.
I absolutely love CCExtractor, but have not contributed previously.
I am an active contributor to CCExtractor.

---### Description
This PR fixes compiler warnings in src/lib_ccx/ts_tables_epg.c related to unused variables.

The Issue:
The variables mode and compression_type were declared and assigned values from the offset array, but they were never subsequently used in the logic block (lines 98-105). This triggered -Wunused-but-set-variable warnings during the build.

The Fix:

Removed the declarations and assignments for mode and compression_type.
Preserved the critical offset += 3; pointer arithmetic to ensure the parsing logic remains correct.
Verified that the code builds without these specific warnings.

Environment:

Windows 11
MSVC / CMake

**Original Pull Request:** https://github.com/CCExtractor/ccextractor/pull/1914 **State:** closed **Merged:** Yes ---  **In raising this pull request, I confirm the following (please check boxes):** - [x ] I have read and understood the [contributors guide](https://github.com/CCExtractor/ccextractor/blob/master/.github/CONTRIBUTING.md). - [x ] I have checked that another pull request for this purpose does not exist. - [x ] I have considered, and confirmed that this submission will be valuable to others. - [x ] I accept that this submission may not be used, and the pull request closed at the will of the maintainer. - [x ] I give this submission freely, and claim no ownership to its content. - [ x] **I have mentioned this change in the [changelog](https://github.com/CCExtractor/ccextractor/blob/master/docs/CHANGES.TXT).** **My familiarity with the project is as follows (check one):** - [ ] I have never used CCExtractor. - [x ] I have used CCExtractor just a couple of times. - [ ] I absolutely love CCExtractor, but have not contributed previously. - [ ] I am an active contributor to CCExtractor. ---### Description This PR fixes compiler warnings in `src/lib_ccx/ts_tables_epg.c` related to unused variables. **The Issue:** The variables `mode` and `compression_type` were declared and assigned values from the `offset` array, but they were never subsequently used in the logic block (lines 98-105). This triggered `-Wunused-but-set-variable` warnings during the build. **The Fix:** - Removed the declarations and assignments for `mode` and `compression_type`. - Preserved the critical `offset += 3;` pointer arithmetic to ensure the parsing logic remains correct. - Verified that the code builds without these specific warnings. **Environment:** - Windows 11 - MSVC / CMake

claunia added the pull-request label 2026-01-29 17:23:33 +00:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/ccextractor#2712