[PR #1924] [MERGED] Clean up VCL HRD TODO comment in avc_functions.c

## 📋 Pull Request Information **Original PR:** https://github.com/CCExtractor/ccextractor/pull/1924 **Author:** [@Harshdhall01](https://github.com/Harshdhall01) **Created:** 12/29/2025 **Status:** ✅ Merged **Merged:** 12/30/2025 **Merged by:** [@cfsmp3](https://github.com/cfsmp3) **Base:** `master` ← **Head:** `cleanup-vcl-hrd-todo` --- ### 📝 Commits (3) - [`3cb0f61`](https://github.com/CCExtractor/ccextractor/commit/3cb0f61b0c24ce515f4d65ddeeb0ef8b89a72572) Clean up VCL HRD TODO comment - [`5352a8b`](https://github.com/CCExtractor/ccextractor/commit/5352a8b8770cb0b812a730991ef1705eaa069783) Fix formatting: use consistent tab indentation and remove trailing whitespace - [`8bf1bc1`](https://github.com/CCExtractor/ccextractor/commit/8bf1bc16de51997c8dee6a7e6a135d4b5646fccf) Remove blank line to fix formatting check ### 📊 Changes **1 file changed** (+3 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `src/lib_ccx/avc_functions.c` (+3 -3) </details> ### 📄 Description **[IMPROVEMENT]** Clean up VCL HRD TODO comment in avc_functions.c Addresses #1894 ### Summary Replace unclear TODO with explanation of why VCL HRD parameters are skipped. VCL HRD is for video buffering compliance and not needed for caption extraction. ### Changes: - Replace TODO comment with clear explanation - Update mprint message to be more informative - Remove commented-out exit(1) ### Context: This code handles VCL (Video Coding Layer) HRD parameters in H.264/AVC streams. These parameters are for video decoder buffering compliance and are not needed for CCExtractor's purpose of extracting closed captions from SEI NAL units. The existing code correctly skips these parameters - this PR just improves the code documentation to make that clear. ### Testing: - ✅ Code changes reviewed (comments and log message only) - ✅ No functional/logic changes - ⚠️ Local build not tested (requires Visual Studio C++ Build Tools on Windows) - CI will verify compilation Thanks to @cfsmp3 for the detailed guidance on this cleanup! --- **In raising this pull request, I confirm the following (please check boxes):** - [x] I have read and understood the [contributors guide](https://github.com/CCExtractor/ccextractor/blob/master/.github/CONTRIBUTING.md). - [x] I have checked that another pull request for this purpose does not exist. - [x] I have considered, and confirmed that this submission will be valuable to others. - [x] I accept that this submission may not be used, and the pull request closed at the will of the maintainer. - [x] I give this submission freely, and claim no ownership to its content. - [ ] **I have mentioned this change in the [changelog](https://github.com/CCExtractor/ccextractor/blob/master/docs/CHANGES.TXT).** **Note:** CHANGES.TXT not updated as this is a minor documentation-only change with no functional impact. **My familiarity with the project is as follows (check one):** - [ ] I have never used CCExtractor. - [ ] I have used CCExtractor just a couple of times. - [x] I absolutely love CCExtractor, but have not contributed previously. - [ ] I am an active contributor to CCExtractor. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

claunia commented

2026-01-29 17:23:35 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/CCExtractor/ccextractor/pull/1924
Author: @Harshdhall01
Created: 12/29/2025
Status: ✅ Merged
Merged: 12/30/2025
Merged by: @cfsmp3

Base: master ← Head: cleanup-vcl-hrd-todo

📝 Commits (3)

3cb0f61 Clean up VCL HRD TODO comment
5352a8b Fix formatting: use consistent tab indentation and remove trailing whitespace
8bf1bc1 Remove blank line to fix formatting check

📊 Changes

1 file changed (+3 additions, -3 deletions)

View changed files

📝 src/lib_ccx/avc_functions.c (+3 -3)

📄 Description

[IMPROVEMENT] Clean up VCL HRD TODO comment in avc_functions.c

Addresses #1894

Summary

Replace unclear TODO with explanation of why VCL HRD parameters are skipped. VCL HRD is for video buffering compliance and not needed for caption extraction.

Changes:

Replace TODO comment with clear explanation
Update mprint message to be more informative
Remove commented-out exit(1)

Context:

This code handles VCL (Video Coding Layer) HRD parameters in H.264/AVC streams. These parameters are for video decoder buffering compliance and are not needed for CCExtractor's purpose of extracting closed captions from SEI NAL units.

The existing code correctly skips these parameters - this PR just improves the code documentation to make that clear.

Testing:

✅ Code changes reviewed (comments and log message only)
✅ No functional/logic changes
⚠️ Local build not tested (requires Visual Studio C++ Build Tools on Windows)
CI will verify compilation

Thanks to @cfsmp3 for the detailed guidance on this cleanup!

In raising this pull request, I confirm the following (please check boxes):

I have read and understood the contributors guide.
I have checked that another pull request for this purpose does not exist.
I have considered, and confirmed that this submission will be valuable to others.
I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
I give this submission freely, and claim no ownership to its content.
I have mentioned this change in the changelog.

Note: CHANGES.TXT not updated as this is a minor documentation-only change with no functional impact.

My familiarity with the project is as follows (check one):

I have never used CCExtractor.
I have used CCExtractor just a couple of times.
I absolutely love CCExtractor, but have not contributed previously.
I am an active contributor to CCExtractor.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

claunia added the pull-request label 2026-01-29 17:23:35 +00:00

[PR #1924] [MERGED] Clean up VCL HRD TODO comment in avc_functions.c #2720