[PR #1921] IMPROVEMENT: 1. simplified verify_parity function. 2.Improved documentat… #2722

New Issue

claunia · 2026-01-29T17:23:35Z

claunia commented

2026-01-29 17:23:35 +00:00

Original Pull Request: https://github.com/CCExtractor/ccextractor/pull/1921

State: closed
Merged: Yes

…ion for public function validate_cc_pair. 3. Added constant for 0x7F.

[IMPROVEMENT]

In raising this pull request, I confirm the following

I have read and understood the contributors guide.
I have checked that another pull request for this purpose does not exist.
I have considered, and confirmed that this submission will be valuable to others.
I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
I give this submission freely, and claim no ownership to its content.
I have mentioned this change in the changelog.

My familiarity with the project is as follows:

I have never used CCExtractor.

##Changes Made

Replaced magic number 0x7F with named constant CC_BLANK_SPACE.
Added comprehensive documentation to function validate_cc_pair.
Simplified verify_parity function.

##Tests
✅ All existing tests passed.

**Original Pull Request:** https://github.com/CCExtractor/ccextractor/pull/1921 **State:** closed **Merged:** Yes --- …ion for public function validate_cc_pair. 3. Added constant for 0x7F. **[IMPROVEMENT]** **In raising this pull request, I confirm the following** - [x] I have read and understood the [contributors guide](https://github.com/CCExtractor/ccextractor/blob/master/.github/CONTRIBUTING.md). - [x] I have checked that another pull request for this purpose does not exist. - [x] I have considered, and confirmed that this submission will be valuable to others. - [x] I accept that this submission may not be used, and the pull request closed at the will of the maintainer. - [x] I give this submission freely, and claim no ownership to its content. - [ ] **I have mentioned this change in the [changelog](https://github.com/CCExtractor/ccextractor/blob/master/docs/CHANGES.TXT).** **My familiarity with the project is as follows:** - [x] I have never used CCExtractor. --- ##Changes Made 1. Replaced magic number 0x7F with named constant `CC_BLANK_SPACE`. 2. Added comprehensive documentation to function `validate_cc_pair`. 3. Simplified verify_parity function. ##Tests ✅ All existing tests passed.

claunia added the pull-request label 2026-01-29 17:23:35 +00:00

claunia closed this issue

2026-01-29 17:23:36 +00:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/ccextractor#2722