[PR #1946] [MERGED] fix(ci): Fix Windows CI cargo build cache path #2746

New Issue

claunia · 2026-01-29T17:23:43Z

claunia commented

2026-01-29 17:23:43 +00:00

📋 Pull Request Information

Original PR: https://github.com/CCExtractor/ccextractor/pull/1946
Author: @cfsmp3
Created: 1/1/2026
Status: ✅ Merged
Merged: 1/2/2026
Merged by: @cfsmp3

Base: master ← Head: fix/windows-ci-caching

📝 Commits (1)

200eb17 fix(ci): Fix Windows CI cargo build cache path

📊 Changes

1 file changed (+3 additions, -3 deletions)

View changed files

📝 .github/workflows/build_windows.yml (+3 -3)

📄 Description

Summary

This PR fixes the Windows CI cargo build cache which was pointing to the wrong path.

Changes:

Fix cargo build cache path: rust.bat sets CARGO_TARGET_DIR to the windows/ directory, which results in artifacts being stored at windows/x86_64-pc-windows-msvc/, not windows/target/. The cache was pointing to the wrong path and never getting hits.
Remove redundant CARGO_TARGET_DIR: The workflow was setting CARGO_TARGET_DIR: "..\\..\\windows" in the build steps, but rust.bat overrides this anyway. Removed the redundant environment variable.

Results:

vcpkg cache: Working (Install vcpkg dependencies skipped on cache hit)
Cargo build cache: Now points to correct path for future cache hits
Build time: ~8 minutes with cache hits vs 38+ minutes without

Test plan

Verify Windows CI build passes
Verify vcpkg cache is restored (check "Install vcpkg dependencies" is skipped)

🤖 Generated with Claude Code

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/CCExtractor/ccextractor/pull/1946 **Author:** [@cfsmp3](https://github.com/cfsmp3) **Created:** 1/1/2026 **Status:** ✅ Merged **Merged:** 1/2/2026 **Merged by:** [@cfsmp3](https://github.com/cfsmp3) **Base:** `master` ← **Head:** `fix/windows-ci-caching` --- ### 📝 Commits (1) - [`200eb17`](https://github.com/CCExtractor/ccextractor/commit/200eb1750ac13e0ab7b83cc9d90bb40284a942d0) fix(ci): Fix Windows CI cargo build cache path ### 📊 Changes **1 file changed** (+3 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/build_windows.yml` (+3 -3) </details> ### 📄 Description ## Summary This PR fixes the Windows CI cargo build cache which was pointing to the wrong path. ### Changes: 1. **Fix cargo build cache path**: `rust.bat` sets `CARGO_TARGET_DIR` to the `windows/` directory, which results in artifacts being stored at `windows/x86_64-pc-windows-msvc/`, not `windows/target/`. The cache was pointing to the wrong path and never getting hits. 2. **Remove redundant CARGO_TARGET_DIR**: The workflow was setting `CARGO_TARGET_DIR: "..\\..\\windows"` in the build steps, but `rust.bat` overrides this anyway. Removed the redundant environment variable. ### Results: - vcpkg cache: Working (Install vcpkg dependencies skipped on cache hit) - Cargo build cache: Now points to correct path for future cache hits - Build time: ~8 minutes with cache hits vs 38+ minutes without ## Test plan - [x] Verify Windows CI build passes - [x] Verify vcpkg cache is restored (check "Install vcpkg dependencies" is skipped) 🤖 Generated with [Claude Code](https://claude.com/claude-code) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

claunia added the pull-request label 2026-01-29 17:23:43 +00:00

claunia closed this issue

2026-01-29 17:23:44 +00:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/ccextractor#2746