[PR #1947] [MERGED] fix(avc): Remove unnecessary TODO for idr_pic_id #2748

New Issue

claunia · 2026-01-29T17:23:44Z

claunia commented

2026-01-29 17:23:44 +00:00

📋 Pull Request Information

Original PR: https://github.com/CCExtractor/ccextractor/pull/1947
Author: @cfsmp3
Created: 1/1/2026
Status: ✅ Merged
Merged: 1/1/2026
Merged by: @cfsmp3

Base: master ← Head: fix/remove-idr-pic-id-todo

📝 Commits (1)

925560f fix(avc): Remove unnecessary TODO for idr_pic_id

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 src/lib_ccx/avc_functions.c (+1 -1)

📄 Description

Summary

Removes the TODO comment at src/lib_ccx/avc_functions.c:997 and adds a clarifying comment explaining why idr_pic_id is read but not stored.

Why idr_pic_id doesn't need to be stored:

Bitstream parsing requirement: The value must be read to advance the bitstream position - subsequent fields like pic_order_cnt_lsb come after it in the slice header
Not needed for caption extraction: CCExtractor uses pic_order_cnt_lsb for frame ordering (when --usepicorder is set) and PTS for timing synchronization - neither requires idr_pic_id
Purpose in H.264: idr_pic_id distinguishes between consecutive IDR pictures for decoder error recovery - not relevant for extracting embedded captions from SEI NAL units

Closes #1895

🤖 Generated with Claude Code

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/CCExtractor/ccextractor/pull/1947 **Author:** [@cfsmp3](https://github.com/cfsmp3) **Created:** 1/1/2026 **Status:** ✅ Merged **Merged:** 1/1/2026 **Merged by:** [@cfsmp3](https://github.com/cfsmp3) **Base:** `master` ← **Head:** `fix/remove-idr-pic-id-todo` --- ### 📝 Commits (1) - [`925560f`](https://github.com/CCExtractor/ccextractor/commit/925560f7738935d17ac3e3f693a6bbf4f51579b9) fix(avc): Remove unnecessary TODO for idr_pic_id ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `src/lib_ccx/avc_functions.c` (+1 -1) </details> ### 📄 Description ## Summary Removes the TODO comment at `src/lib_ccx/avc_functions.c:997` and adds a clarifying comment explaining why `idr_pic_id` is read but not stored. ### Why idr_pic_id doesn't need to be stored: 1. **Bitstream parsing requirement**: The value must be read to advance the bitstream position - subsequent fields like `pic_order_cnt_lsb` come after it in the slice header 2. **Not needed for caption extraction**: CCExtractor uses `pic_order_cnt_lsb` for frame ordering (when `--usepicorder` is set) and PTS for timing synchronization - neither requires `idr_pic_id` 3. **Purpose in H.264**: `idr_pic_id` distinguishes between consecutive IDR pictures for decoder error recovery - not relevant for extracting embedded captions from SEI NAL units Closes #1895 🤖 Generated with [Claude Code](https://claude.com/claude-code) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

claunia added the pull-request label 2026-01-29 17:23:44 +00:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/ccextractor#2748