[PR #1947] fix(avc): Remove unnecessary TODO for idr_pic_id #2752

New Issue

claunia · 2026-01-29T17:23:44Z

claunia commented

2026-01-29 17:23:44 +00:00

Original Pull Request: https://github.com/CCExtractor/ccextractor/pull/1947

State: closed
Merged: Yes

Summary

Removes the TODO comment at src/lib_ccx/avc_functions.c:997 and adds a clarifying comment explaining why idr_pic_id is read but not stored.

Why idr_pic_id doesn't need to be stored:

Bitstream parsing requirement: The value must be read to advance the bitstream position - subsequent fields like pic_order_cnt_lsb come after it in the slice header
Not needed for caption extraction: CCExtractor uses pic_order_cnt_lsb for frame ordering (when --usepicorder is set) and PTS for timing synchronization - neither requires idr_pic_id
Purpose in H.264: idr_pic_id distinguishes between consecutive IDR pictures for decoder error recovery - not relevant for extracting embedded captions from SEI NAL units

Closes #1895

🤖 Generated with Claude Code

**Original Pull Request:** https://github.com/CCExtractor/ccextractor/pull/1947 **State:** closed **Merged:** Yes --- ## Summary Removes the TODO comment at `src/lib_ccx/avc_functions.c:997` and adds a clarifying comment explaining why `idr_pic_id` is read but not stored. ### Why idr_pic_id doesn't need to be stored: 1. **Bitstream parsing requirement**: The value must be read to advance the bitstream position - subsequent fields like `pic_order_cnt_lsb` come after it in the slice header 2. **Not needed for caption extraction**: CCExtractor uses `pic_order_cnt_lsb` for frame ordering (when `--usepicorder` is set) and PTS for timing synchronization - neither requires `idr_pic_id` 3. **Purpose in H.264**: `idr_pic_id` distinguishes between consecutive IDR pictures for decoder error recovery - not relevant for extracting embedded captions from SEI NAL units Closes #1895 🤖 Generated with [Claude Code](https://claude.com/claude-code)

claunia added the pull-request label 2026-01-29 17:23:44 +00:00

claunia closed this issue

2026-01-29 17:23:45 +00:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/ccextractor#2752