[PR #1988] Fix pmtentry clean #2790

New Issue

claunia · 2026-01-29T17:23:54Z

claunia commented

2026-01-29 17:23:54 +00:00

Original Pull Request: https://github.com/CCExtractor/ccextractor/pull/1988

State: closed
Merged: No

[FIX] Critical Rust FFI memory safety: avoid returning pointer to stack-allocated PMTEntry

In raising this pull request, I confirm the following (please check boxes):

I have read and understood the contributors guide.
I have checked that another pull request for this purpose does not exist.
I have considered, and confirmed that this submission will be valuable to others.
I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
I give this submission freely, and claim no ownership to its content.
I have mentioned this change in the changelog.

My familiarity with the project is as follows (check one):

I have never used CCExtractor.
I have used CCExtractor just a couple of times.
I absolutely love CCExtractor, but have not contributed previously.
I am an active contributor to CCExtractor.

Description

PR fixes a use-after-scope (dangling pointer) bug in the Rust FFI layer.

The implementation of:

impl FromCType<*mut PMT_entry> for *mut PMTEntry

previously returned a raw pointer derived from a stack-allocated PMTEntry.
Once the function returned, the stack frame was destroyed, leaving the pointer
dangling and causing undefined behavior in Rust.

This is a correctness and memory-safety issue independent of C-side usage,
tests, or call order.

Fixes #1986

**Original Pull Request:** https://github.com/CCExtractor/ccextractor/pull/1988 **State:** closed **Merged:** No ---  **[FIX] Critical Rust FFI memory safety: avoid returning pointer to stack-allocated PMTEntry** **In raising this pull request, I confirm the following (please check boxes):** - [x] I have read and understood the [contributors guide](https://github.com/CCExtractor/ccextractor/blob/master/.github/CONTRIBUTING.md). - [x] I have checked that another pull request for this purpose does not exist. - [x] I have considered, and confirmed that this submission will be valuable to others. - [x] I accept that this submission may not be used, and the pull request closed at the will of the maintainer. - [x] I give this submission freely, and claim no ownership to its content. - [x] **I have mentioned this change in the [changelog](https://github.com/CCExtractor/ccextractor/blob/master/docs/CHANGES.TXT).** **My familiarity with the project is as follows (check one):** - [ ] I have never used CCExtractor. - [ ] I have used CCExtractor just a couple of times. - [ ] I absolutely love CCExtractor, but have not contributed previously. - [x] I am an active contributor to CCExtractor. --- ### Description PR fixes a **use-after-scope (dangling pointer) bug** in the Rust FFI layer. The implementation of: ```rust impl FromCType<*mut PMT_entry> for *mut PMTEntry ``` previously returned a raw pointer derived from a stack-allocated PMTEntry. Once the function returned, the stack frame was destroyed, leaving the pointer dangling and causing undefined behavior in Rust. This is a correctness and memory-safety issue independent of C-side usage, tests, or call order. Fixes #1986

claunia added the pull-request label 2026-01-29 17:23:54 +00:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/ccextractor#2790