[PR #1992] fix: Teletext decoder panic on malformed BCD data

**Original Pull Request:** https://github.com/CCExtractor/ccextractor/pull/1992 **State:** closed **Merged:** Yes ---  **In raising this pull request, I confirm the following (please check boxes):** - [x] I have read and understood the [contributors guide](https://github.com/CCExtractor/ccextractor/blob/master/.github/CONTRIBUTING.md). - [x] I have checked that another pull request for this purpose does not exist. - [x] I have considered, and confirmed that this submission will be valuable to others. - [x] I accept that this submission may not be used, and the pull request closed at the will of the maintainer. - [x] I give this submission freely, and claim no ownership to its content. - [x] **I have mentioned this change in the [changelog](https://github.com/CCExtractor/ccextractor/blob/master/docs/CHANGES.TXT).** **My familiarity with the project is as follows (check one):** - [ ] I have never used CCExtractor. - [ ] I have used CCExtractor just a couple of times. - [ ] I absolutely love CCExtractor, but have not contributed previously. - [x] I am an active contributor to CCExtractor. --- ### Description This PR fixes a crash in the Teletext decoder caused by unwrap() on malformed BCD data. Although PR #1991 addressed a related issue in the Rust word file parser for #1990, some edge cases in the Teletext decoder were left unhandled. This PR fixes those remaining cases. ### Changes made - Replaced all unwrap() calls in teletext.rs with safe alternatives (unwrap_or(0) or early return) to prevent panics. - Ensures malformed broadcast packets no longer crash. ### Context - A previous PR (#1991) fixed a similar issue in the Rust word file parser, preventing panics from malformed input. - However, some edge cases in the Teletext decoder were not addressed at that time. This PR safely handles those remaining cases. Fixes #1990 ### Verification - Unit tests simulate malformed BCD input and confirm no panics. - Verified CCExtractor runs normally under invalid Teletext packets.

claunia commented

2026-01-29 17:23:56 +00:00

Owner

Original Pull Request: https://github.com/CCExtractor/ccextractor/pull/1992

State: closed
Merged: Yes

In raising this pull request, I confirm the following (please check boxes):

I have read and understood the contributors guide.
I have checked that another pull request for this purpose does not exist.
I have considered, and confirmed that this submission will be valuable to others.
I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
I give this submission freely, and claim no ownership to its content.
I have mentioned this change in the changelog.

My familiarity with the project is as follows (check one):

I have never used CCExtractor.
I have used CCExtractor just a couple of times.
I absolutely love CCExtractor, but have not contributed previously.
I am an active contributor to CCExtractor.

Description

This PR fixes a crash in the Teletext decoder caused by unwrap() on malformed BCD data.

Although PR #1991 addressed a related issue in the Rust word file parser for #1990, some edge cases in the Teletext decoder were left unhandled. This PR fixes those remaining cases.

Changes made

Replaced all unwrap() calls in teletext.rs with safe alternatives (unwrap_or(0) or early return) to prevent panics.
Ensures malformed broadcast packets no longer crash.

Context

A previous PR (#1991) fixed a similar issue in the Rust word file parser, preventing panics from malformed input.
However, some edge cases in the Teletext decoder were not addressed at that time. This PR safely handles those remaining cases.

Fixes #1990

Verification

Unit tests simulate malformed BCD input and confirm no panics.
Verified CCExtractor runs normally under invalid Teletext packets.

claunia added the pull-request label 2026-01-29 17:23:56 +00:00

[PR #1992] fix: Teletext decoder panic on malformed BCD data #2798

Description

Changes made

Context

Verification