[PR #2040] fix SEI payload size handling and type correctness

## 📋 Pull Request Information **Original PR:** https://github.com/CCExtractor/ccextractor/pull/2040 **Author:** [@THE-Amrit-mahto-05](https://github.com/THE-Amrit-mahto-05) **Created:** 1/18/2026 **Status:** 🔄 Open **Base:** `master` ← **Head:** `fix/avc-sei-payload-size` --- ### 📝 Commits (3) - [`3618c23`](https://github.com/CCExtractor/ccextractor/commit/3618c23b5a10d048d596eae3b863fe0549e31a32) rust/avc: fix SEI payload size handling and type correctness - [`fe6dad8`](https://github.com/CCExtractor/ccextractor/commit/fe6dad83b70ffbae769d5c5fa7b961085d91c252) use u32 for SEI payload type and size - [`2dfb44d`](https://github.com/CCExtractor/ccextractor/commit/2dfb44d7d4857b901405988eb78ec11a04af3dd4) re running CI ### 📊 Changes **1 file changed** (+4 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `src/rust/src/avc/sei.rs` (+4 -4) </details> ### 📄 Description  **In raising this pull request, I confirm the following (please check boxes):** - [x] I have read and understood the [contributors guide](https://github.com/CCExtractor/ccextractor/blob/master/.github/CONTRIBUTING.md). - [x] I have checked that another pull request for this purpose does not exist. - [x] I have considered, and confirmed that this submission will be valuable to others. - [x] I accept that this submission may not be used, and the pull request closed at the will of the maintainer. - [x] I give this submission freely, and claim no ownership to its content. - [x] **I have mentioned this change in the [changelog](https://github.com/CCExtractor/ccextractor/blob/master/docs/CHANGES.TXT).** **My familiarity with the project is as follows (check one):** - [ ] I have never used CCExtractor. - [ ] I have used CCExtractor just a couple of times. - [ ] I absolutely love CCExtractor, but have not contributed previously. - [x] I am an active contributor to CCExtractor. --- ### Description `payload_type` and `payload_size` were previously inferred or explicitly defined as `i32`, which required repeated casting when indexing buffers or comparing against slice lengths. This added unnecessary casts and could theoretically lead to incorrect behavior for large payload values. ### Fix - Changed `payload_type` and `payload_size` to explicit `usize`. - Removed unnecessary `as i32` casts during accumulation. - Removed redundant `as usize` casts during indexing and bounds checks. - Ensured `seibuf_idx` arithmetic remains type-safe and consistent. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

claunia commented

2026-01-29 17:24:13 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/CCExtractor/ccextractor/pull/2040
Author: @THE-Amrit-mahto-05
Created: 1/18/2026
Status: 🔄 Open

Base: master ← Head: fix/avc-sei-payload-size

📝 Commits (3)

3618c23 rust/avc: fix SEI payload size handling and type correctness
fe6dad8 use u32 for SEI payload type and size
2dfb44d re running CI

📊 Changes

1 file changed (+4 additions, -4 deletions)

View changed files

📝 src/rust/src/avc/sei.rs (+4 -4)

📄 Description

In raising this pull request, I confirm the following (please check boxes):

I have read and understood the contributors guide.
I have checked that another pull request for this purpose does not exist.
I have considered, and confirmed that this submission will be valuable to others.
I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
I give this submission freely, and claim no ownership to its content.
I have mentioned this change in the changelog.

My familiarity with the project is as follows (check one):

I have never used CCExtractor.
I have used CCExtractor just a couple of times.
I absolutely love CCExtractor, but have not contributed previously.
I am an active contributor to CCExtractor.

Description

payload_type and payload_size were previously inferred or explicitly defined as i32, which required repeated casting when indexing buffers or comparing against slice lengths. This added unnecessary casts and could theoretically lead to incorrect behavior for large payload values.

Fix

Changed payload_type and payload_size to explicit usize.
Removed unnecessary as i32 casts during accumulation.
Removed redundant as usize casts during indexing and bounds checks.
Ensured seibuf_idx arithmetic remains type-safe and consistent.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

claunia added the pull-request label 2026-01-29 17:24:13 +00:00

[PR #2040] fix SEI payload size handling and type correctness #2846

📋 Pull Request Information

📝 Commits (3)

📊 Changes

📄 Description

Description

Fix