[PR #2045] docs/debug: add verbose log when user data is skipped #2851

Open
opened 2026-01-29 17:24:16 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/CCExtractor/ccextractor/pull/2045
Author: @pranavshar223
Created: 1/19/2026
Status: 🔄 Open

Base: masterHead: docs-userdata-debug-log


📝 Commits (3)

  • 5f4373b docs/debug: add verbose log when user data is skipped
  • 2469b29 retry the test
  • e5ffd30 restore all changes

📊 Changes

2 files changed (+69 additions, -39 deletions)

View changed files

📝 linux/pre-build.sh (+34 -34)
📝 src/rust/src/es/userdata.rs (+35 -5)

📄 Description

[IMPROVEMENT]

In raising this pull request, I confirm the following (please check boxes):

  • I have read and understood the contributors guide.
  • I have checked that another pull request for this purpose does not exist.
  • I have considered, and confirmed that this submission will be valuable to others.
  • I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  • I give this submission freely, and claim no ownership to its content.
  • I have mentioned this change in the changelog.

My familiarity with the project is as follows (check one):

  • I have never used CCExtractor.
  • I have used CCExtractor just a couple of times.
  • I absolutely love CCExtractor, but have not contributed previously.
  • I am an active contributor to CCExtractor.

What this PR does

  • Adds clarifying documentation comments to src/rust/src/es/userdata.rs
  • Adds verbose debug logging when MPEG user data is skipped due to invalid or empty bitstream

Why this is useful

userdata.rs contains complex legacy parsing logic for multiple caption standards.
The added documentation and logging improve readability and debuggability without
changing runtime behavior.

Scope

  • Documentation and debug logging only
  • No functional or behavioral changes

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/CCExtractor/ccextractor/pull/2045 **Author:** [@pranavshar223](https://github.com/pranavshar223) **Created:** 1/19/2026 **Status:** 🔄 Open **Base:** `master` ← **Head:** `docs-userdata-debug-log` --- ### 📝 Commits (3) - [`5f4373b`](https://github.com/CCExtractor/ccextractor/commit/5f4373b29be5a5e0ffd52fb8d62591f55cf884b9) docs/debug: add verbose log when user data is skipped - [`2469b29`](https://github.com/CCExtractor/ccextractor/commit/2469b290f0bf26b69ae76fabb414c816ca2a4d9a) retry the test - [`e5ffd30`](https://github.com/CCExtractor/ccextractor/commit/e5ffd30c483d430cca6906e9c8ff79f53190be71) restore all changes ### 📊 Changes **2 files changed** (+69 additions, -39 deletions) <details> <summary>View changed files</summary> 📝 `linux/pre-build.sh` (+34 -34) 📝 `src/rust/src/es/userdata.rs` (+35 -5) </details> ### 📄 Description [IMPROVEMENT] **In raising this pull request, I confirm the following (please check boxes):** - [x] I have read and understood the [contributors guide](https://github.com/CCExtractor/ccextractor/blob/master/.github/CONTRIBUTING.md). - [x] I have checked that another pull request for this purpose does not exist. - [x] I have considered, and confirmed that this submission will be valuable to others. - [x] I accept that this submission may not be used, and the pull request closed at the will of the maintainer. - [x] I give this submission freely, and claim no ownership to its content. - [ ] **I have mentioned this change in the [changelog](https://github.com/CCExtractor/ccextractor/blob/master/docs/CHANGES.TXT).** **My familiarity with the project is as follows (check one):** - [ ] I have never used CCExtractor. - [x] I have used CCExtractor just a couple of times. - [ ] I absolutely love CCExtractor, but have not contributed previously. - [ ] I am an active contributor to CCExtractor. --- ### What this PR does - Adds clarifying documentation comments to `src/rust/src/es/userdata.rs` - Adds verbose debug logging when MPEG user data is skipped due to invalid or empty bitstream ### Why this is useful `userdata.rs` contains complex legacy parsing logic for multiple caption standards. The added documentation and logging improve readability and debuggability without changing runtime behavior. ### Scope - Documentation and debug logging only - No functional or behavioral changes --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-29 17:24:16 +00:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/ccextractor#2851