[PR #2046] [CLOSED] fix(rust): harden ccxr_process_cc_data against excessive cc_count #2854

Open
opened 2026-01-29 17:24:16 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/CCExtractor/ccextractor/pull/2046
Author: @Harsh-Sahu43
Created: 1/19/2026
Status: Closed

Base: masterHead: fix/ccxr-process-cc-data-limit


📝 Commits (2)

  • 91f1e96 fix(rust): harden ccxr_process_cc_data against excessive cc_count
  • 046a045 style(rust): fix doc comment attachment for ccxr_process_cc_data limit

📊 Changes

1 file changed (+22 additions, -0 deletions)

View changed files

📝 src/rust/src/lib.rs (+22 -0)

📄 Description

In raising this pull request, I confirm the following (please check boxes):

  • I have read and understood the contributors guide.
  • I have checked that another pull request for this purpose does not exist.
  • I have considered, and confirmed that this submission will be valuable to others.
  • I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  • I give this submission freely, and claim no ownership to its content.
  • I have mentioned this change in the changelog.

My familiarity with the project is as follows (check one):

  • I have never used CCExtractor.
  • I have used CCExtractor just a couple of times.
  • I absolutely love CCExtractor, but have not contributed previously.
  • I am an active contributor to CCExtractor.

{pull request content here}

Summary

Adds a defensive upper bound on cc_count in ccxr_process_cc_data to prevent
excessive allocations or misuse at the FFI boundary.

Details

  • Rejects calls where cc_count exceeds a sane limit
  • Logs a warning instead of attempting allocation
  • Adds a unit test to validate the guard
  • No behavior change for valid inputs

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/CCExtractor/ccextractor/pull/2046 **Author:** [@Harsh-Sahu43](https://github.com/Harsh-Sahu43) **Created:** 1/19/2026 **Status:** ❌ Closed **Base:** `master` ← **Head:** `fix/ccxr-process-cc-data-limit` --- ### 📝 Commits (2) - [`91f1e96`](https://github.com/CCExtractor/ccextractor/commit/91f1e966d1bad1fefeb4458a71fbe615ecd494ef) fix(rust): harden ccxr_process_cc_data against excessive cc_count - [`046a045`](https://github.com/CCExtractor/ccextractor/commit/046a045a83f44963393d7d6c60da6c238b9d1986) style(rust): fix doc comment attachment for ccxr_process_cc_data limit ### 📊 Changes **1 file changed** (+22 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `src/rust/src/lib.rs` (+22 -0) </details> ### 📄 Description <!-- Please prefix your pull request with one of the following: **[FEATURE]** **[FIX]** **[IMPROVEMENT]**. --> **In raising this pull request, I confirm the following (please check boxes):** - [x] I have read and understood the [contributors guide](https://github.com/CCExtractor/ccextractor/blob/master/.github/CONTRIBUTING.md). - [x] I have checked that another pull request for this purpose does not exist. - [x] I have considered, and confirmed that this submission will be valuable to others. - [x] I accept that this submission may not be used, and the pull request closed at the will of the maintainer. - [x] I give this submission freely, and claim no ownership to its content. - [ ] **I have mentioned this change in the [changelog](https://github.com/CCExtractor/ccextractor/blob/master/docs/CHANGES.TXT).** **My familiarity with the project is as follows (check one):** - [ ] I have never used CCExtractor. - [x] I have used CCExtractor just a couple of times. - [ ] I absolutely love CCExtractor, but have not contributed previously. - [ ] I am an active contributor to CCExtractor. --- {pull request content here} ### Summary Adds a defensive upper bound on `cc_count` in `ccxr_process_cc_data` to prevent excessive allocations or misuse at the FFI boundary. ### Details - Rejects calls where `cc_count` exceeds a sane limit - Logs a warning instead of attempting allocation - Adds a unit test to validate the guard - No behavior change for valid inputs --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-29 17:24:16 +00:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/ccextractor#2854