[PR #2047] [MERGED] fix(rust): correct mkvlang test to use MkvLangFilter type #2858

New Issue

claunia · 2026-01-29T17:24:17Z

claunia commented

2026-01-29 17:24:17 +00:00

📋 Pull Request Information

Original PR: https://github.com/CCExtractor/ccextractor/pull/2047
Author: @cfsmp3
Created: 1/19/2026
Status: ✅ Merged
Merged: 1/19/2026
Merged by: @cfsmp3

Base: master ← Head: fix/mkvlang-test-type-mismatch

📝 Commits (1)

9db727d fix(rust): correct mkvlang test to use MkvLangFilter type

📊 Changes

1 file changed (+2 additions, -2 deletions)

View changed files

📝 src/rust/src/parser.rs (+2 -2)

📄 Description

Summary

Fix type mismatch in test_mkvlang_sets_mkv_language test
The test was comparing against Language::Eng, but mkvlang field type changed to MkvLangFilter after BCP 47 support was added in PR #2038

Test plan

cargo test --workspace passes (395 tests in ccx_rust + 91 in lib_ccxr)

🤖 Generated with Claude Code

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/CCExtractor/ccextractor/pull/2047 **Author:** [@cfsmp3](https://github.com/cfsmp3) **Created:** 1/19/2026 **Status:** ✅ Merged **Merged:** 1/19/2026 **Merged by:** [@cfsmp3](https://github.com/cfsmp3) **Base:** `master` ← **Head:** `fix/mkvlang-test-type-mismatch` --- ### 📝 Commits (1) - [`9db727d`](https://github.com/CCExtractor/ccextractor/commit/9db727d593f3e5caee492456b417d89a86582d92) fix(rust): correct mkvlang test to use MkvLangFilter type ### 📊 Changes **1 file changed** (+2 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `src/rust/src/parser.rs` (+2 -2) </details> ### 📄 Description ## Summary - Fix type mismatch in `test_mkvlang_sets_mkv_language` test - The test was comparing against `Language::Eng`, but `mkvlang` field type changed to `MkvLangFilter` after BCP 47 support was added in PR #2038 ## Test plan - [x] `cargo test --workspace` passes (395 tests in ccx_rust + 91 in lib_ccxr) 🤖 Generated with [Claude Code](https://claude.ai/claude-code) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

claunia added the pull-request label 2026-01-29 17:24:17 +00:00

claunia closed this issue

2026-01-29 17:24:17 +00:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/ccextractor#2858