mirror of
https://github.com/CCExtractor/ccextractor.git
synced 2026-02-17 13:35:35 +00:00
[BUG] "Unicode" output encoding mixes newlines #328
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @aaaxx on GitHub (Aug 14, 2017).
CCExtractor version: 0.85
Platform: Windows
Using the combination of Unicode encoding and "DOS/Windows (CRLF)" line terminators creates files that use both CR and CRLF newlines. (The "UNIX (LF)" option works fine, though.)
@saurabhshri commented on GitHub (Oct 2, 2017):
@aaaxx What exact command did you use? Also, did the video by any change had bitmap subtitles (e.g. was it a DVB sample?).
I have made a PR which should hopefully fix this (as the context based newlines were missing).
@aaaxx commented on GitHub (Oct 3, 2017):
The source is a retail DVD (multiple VOB files).
Note that it happens only with
-unicode, not with-utf8and-latin1.@aaaxx commented on GitHub (Oct 3, 2017):
And yes, it also had bitmap subtitles.
@saurabhshri commented on GitHub (Oct 3, 2017):
@aaaxx Please try again with the latest code from the repo, and if you still see the mixed line endings, feel free to re-open the issue.
@aaaxx commented on GitHub (Oct 3, 2017):
Sorry, I'm not geeky enough to know how to compile things, but if you can be bothered to make an exe, I'll test it.
@hax0kartik commented on GitHub (Nov 29, 2017):
This issue was fixed with pr #783. The image on the right is produced by ccextractor built from the latest commit while the image on the left is produced from ccextractor v0.80
@saurabhshri commented on GitHub (Nov 29, 2017):
@Pirater12 Thank you for validating the fix! :)