starred/ccextractor
1
0
Fork 0
mirror of https://github.com/CCExtractor/ccextractor.git synced 2026-02-13 21:22:29 +00:00
Code Issues 1.5k Packages Projects Releases 20 Wiki Activity

Compilation warnings on C++ 11 #337

New Issue
Closed
opened 2026-01-29 16:41:23 +00:00 by claunia · 17 comments
claunia commented 2026-01-29 16:41:23 +00:00
Owner
Copy Link

Originally created by @cfsmp3 on GitHub (Sep 28, 2017).

../src/ccextractor.cpp:813:12: warning: invalid suffix on literal; C++11 requires a space between literal and string macro [-Wliteral-suffix]
mprint ( "Teletext decoder: %"PRIu32" packets processed, %"PRIu32" SRT frames written.\n", tlt_packet_counter, tlt_frames_produced);
^
../src/ccextractor.cpp:813:39: warning: invalid suffix on literal; C++11 requires a space between literal and string macro [-Wliteral-suffix]
mprint ( "Teletext decoder: %"PRIu32" packets processed, %"PRIu32" SRT frames written.\n", tlt_packet_counter, tlt_frames_produced);
^
../src/telxcc.cpp:599:42: warning: invalid suffix on literal; C++11 requires a space between literal and string macro [-Wliteral-suffix]
if (wbout1.fh!=-1) fdprintf(wbout1.fh,"%"PRIu32"\r\n%s --> %s\r\n", tlt_frames_produced, timecode_show, timecode_hide);
^

Originally created by @cfsmp3 on GitHub (Sep 28, 2017). ../src/ccextractor.cpp:813:12: warning: invalid suffix on literal; C++11 requires a space between literal and string macro [-Wliteral-suffix] mprint ( "Teletext decoder: %"PRIu32" packets processed, %"PRIu32" SRT frames written.\n", tlt_packet_counter, tlt_frames_produced); ^ ../src/ccextractor.cpp:813:39: warning: invalid suffix on literal; C++11 requires a space between literal and string macro [-Wliteral-suffix] mprint ( "Teletext decoder: %"PRIu32" packets processed, %"PRIu32" SRT frames written.\n", tlt_packet_counter, tlt_frames_produced); ^ ../src/telxcc.cpp:599:42: warning: invalid suffix on literal; C++11 requires a space between literal and string macro [-Wliteral-suffix] if (wbout1.fh!=-1) fdprintf(wbout1.fh,"%"PRIu32"\r\n%s --> %s\r\n", tlt_frames_produced, timecode_show, timecode_hide); ^
claunia added the difficulty: easyHacktoberfest labels 2026-01-29 16:41:23 +00:00
claunia commented 2026-01-29 16:41:24 +00:00
Author
Owner
Copy Link

@mackworth commented on GitHub (Oct 4, 2017):

Oh, man. If you want compiler warnings, there's always been a gazilllion on the mac. (where gazillion is defined as "about 300" currently)

I particularly like the "tautological" ones:

comparison of constant 256 with expression of type 'unsigned char' is always true [-Wtautological-constant-out-of-range-compare]
if (c < 256)

@mackworth commented on GitHub (Oct 4, 2017): Oh, man. If you want compiler warnings, there's always been a gazilllion on the mac. (where gazillion is defined as "about 300" currently) I particularly like the "tautological" ones: > comparison of constant 256 with expression of type 'unsigned char' is always true [-Wtautological-constant-out-of-range-compare] > if (c < 256)
claunia commented 2026-01-29 16:41:24 +00:00
Author
Owner
Copy Link

@cfsmp3 commented on GitHub (Oct 9, 2017):

@mackworth where are those warnings? If they are in GPAC or any other library we just borrowed probably not worth it to do anything about it (except update the library), but if they are in our code we should definitely fix them.

@cfsmp3 commented on GitHub (Oct 9, 2017): @mackworth where are those warnings? If they are in GPAC or any other library we just borrowed probably not worth it to do anything about it (except update the library), but if they are in our code we should definitely fix them.
claunia commented 2026-01-29 16:41:24 +00:00
Author
Owner
Copy Link

@mackworth commented on GitHub (Oct 13, 2017):

So, the errors are generated from api/extractors/extractor.c, src/lib_ccx src/zlib, and src/zvbi
ccextractor Errors.zip

@mackworth commented on GitHub (Oct 13, 2017): So, the errors are generated from api/extractors/extractor.c, src/lib_ccx src/zlib, and src/zvbi [ccextractor Errors.zip](https://github.com/CCExtractor/ccextractor/files/1384100/ccextractor.Errors.zip)
claunia commented 2026-01-29 16:41:24 +00:00
Author
Owner
Copy Link

@shucon commented on GitHub (Oct 13, 2017):

@cfsmp3 all the warnings are not eliminated yet , reopen the issue please.

@shucon commented on GitHub (Oct 13, 2017): @cfsmp3 all the warnings are not eliminated yet , reopen the issue please.
claunia commented 2026-01-29 16:41:25 +00:00
Author
Owner
Copy Link

@saurabhshri commented on GitHub (Oct 14, 2017):

@cfsmp3 Please re-open the issue.

Note to the people working on this issue : ff you are building on Linux using the build scripts located inside the /linux/ directory, please use ./builddebug for complete list of warnings being generated.

@saurabhshri commented on GitHub (Oct 14, 2017): @cfsmp3 Please re-open the issue. Note to the people working on this issue : ff you are building on Linux using the build scripts located inside the `/linux/` directory, please use `./builddebug` for complete list of warnings being generated.
claunia commented 2026-01-29 16:41:25 +00:00
Author
Owner
Copy Link

@mackworth commented on GitHub (Jan 11, 2020):

Just as an update, here's the 3,400 lines of compilation warnings on the current master branch when built on the Mac... (Reflecting only 290 actual warnings).
[ccextractorWarnings.txt]

(https://github.com/CCExtractor/ccextractor/files/4048936/ccextractorWarnings.txt)

@mackworth commented on GitHub (Jan 11, 2020): Just as an update, here's the 3,400 lines of compilation warnings on the current master branch when built on the Mac... (Reflecting only 290 actual warnings). [ccextractorWarnings.txt] (https://github.com/CCExtractor/ccextractor/files/4048936/ccextractorWarnings.txt)
claunia commented 2026-01-29 16:41:25 +00:00
Author
Owner
Copy Link

@NilsIrl commented on GitHub (Jan 13, 2020):

I don't think this is specific to Mac.

On linux I get thousands of lines as well. In fact there are so many warnings that it fills my scrollback buffer.

@NilsIrl commented on GitHub (Jan 13, 2020): I don't think this is specific to Mac. On linux I get thousands of lines as well. In fact there are so many warnings that it fills my scrollback buffer.
claunia commented 2026-01-29 16:41:25 +00:00
Author
Owner
Copy Link

@cfsmp3 commented on GitHub (Jan 13, 2020):

Many are bogus but there's a few ones that at least show raise some eyebrows:

../src/lib_ccx/ts_functions.c:89:47: warning: format specifies type
      'unsigned long' but the argument has type 'uint64_t' (aka
      'unsigned long long') [-Wformat]
        printf("Packet start code prefix: %04lx # ", pes_prefix);
                                          ~~~~~      ^~~~~~~~~~
                                          %04llx
../src/lib_ccx/ts_functions.c:127:10: warning: implicit conversion from
      enumeration type 'enum ccx_bufferdata_type' to different enumeration type
      'enum ccx_stream_type' [-Wenum-conversion]
                return CCX_PES;
@cfsmp3 commented on GitHub (Jan 13, 2020): Many are bogus but there's a few ones that at least show raise some eyebrows: ``` ../src/lib_ccx/ts_functions.c:89:47: warning: format specifies type 'unsigned long' but the argument has type 'uint64_t' (aka 'unsigned long long') [-Wformat] printf("Packet start code prefix: %04lx # ", pes_prefix); ~~~~~ ^~~~~~~~~~ %04llx ../src/lib_ccx/ts_functions.c:127:10: warning: implicit conversion from enumeration type 'enum ccx_bufferdata_type' to different enumeration type 'enum ccx_stream_type' [-Wenum-conversion] return CCX_PES; ```
claunia commented 2026-01-29 16:41:25 +00:00
Author
Owner
Copy Link

@NilsIrl commented on GitHub (Jan 13, 2020):

A good proportion of the warnings have to do with ignoring the return value of write.

@NilsIrl commented on GitHub (Jan 13, 2020): A good proportion of the warnings have to do with ignoring the return value of `write`.
claunia commented 2026-01-29 16:41:26 +00:00
Author
Owner
Copy Link

@cfsmp3 commented on GitHub (Jan 16, 2020):

Maybe we should just disable that specific warning and move on. I don't want to fill the code casts to void or replace calls to write to a function that does the cast, etc.

@cfsmp3 commented on GitHub (Jan 16, 2020): Maybe we should just disable that specific warning and move on. I don't want to fill the code casts to void or replace calls to write to a function that does the cast, etc.
claunia commented 2026-01-29 16:41:26 +00:00
Author
Owner
Copy Link

@NilsIrl commented on GitHub (Jan 18, 2020):

I thing it's a good thing that we try to fix compilation warnings because if there are too many warnings (like it is currently), then we just ignore the warnings which can sometimes help

@NilsIrl commented on GitHub (Jan 18, 2020): I thing it's a good thing that we try to fix compilation warnings because if there are too many warnings (like it is currently), then we just ignore the warnings which can sometimes help
claunia commented 2026-01-29 16:41:26 +00:00
Author
Owner
Copy Link

@cfsmp3 commented on GitHub (Jan 18, 2020):

Yes but some warnings are just overkill. Ignoring the return of a function when you're only interested in its secondary effect is totally normal.

@cfsmp3 commented on GitHub (Jan 18, 2020): Yes but some warnings are just overkill. Ignoring the return of a function when you're only interested in its secondary effect is totally normal.
claunia commented 2026-01-29 16:41:26 +00:00
Author
Owner
Copy Link

@hv7214 commented on GitHub (Feb 8, 2020):

@cfsmp3 i don't see any warnings when built on linux. Is this solved for Linux systems ?

@hv7214 commented on GitHub (Feb 8, 2020): @cfsmp3 i don't see any warnings when built on linux. Is this solved for Linux systems ?
claunia commented 2026-01-29 16:41:27 +00:00
Author
Owner
Copy Link

@canihavesomecoffee commented on GitHub (Feb 8, 2020):

It's heavily dependent on your used compiler version and other parameters, but they're for sure not all fixed yet.

@canihavesomecoffee commented on GitHub (Feb 8, 2020): It's heavily dependent on your used compiler version and other parameters, but they're for sure not all fixed yet.
claunia commented 2026-01-29 16:41:27 +00:00
Author
Owner
Copy Link

@hv7214 commented on GitHub (Feb 8, 2020):

oh i see! yeah i'm using C++14.

@hv7214 commented on GitHub (Feb 8, 2020): oh i see! yeah i'm using C++14.
claunia commented 2026-01-29 16:41:27 +00:00
Author
Owner
Copy Link

@cfsmp3 commented on GitHub (Nov 21, 2021):

Closing as I don't see warnings on master now.

@cfsmp3 commented on GitHub (Nov 21, 2021): Closing as I don't see warnings on master now.
claunia commented 2026-01-29 16:41:27 +00:00
Author
Owner
Copy Link

@mackworth commented on GitHub (Nov 21, 2021):

Just FYI, although they are much less problematic, I still see 397 errors during compilation on my Mac.
Almost all are -Wpointer-sign warnings with many different specific types, but a sample is:

passing 'u8 *' (aka 'unsigned char *') to parameter of type 'const char *' converts between pointers to integer types with different sign [-Wpointer-sign]

There's also 8 -Wself-assign warnings such as

explicitly assigning value of variable of type 'const uint8_t *' (aka 'const unsigned char *') to itself [-Wself-assign]

and a handful of others:

unused function 'cpr1204_crc' [-Wunused-function]
unused variable 'last_sub' [-Wunused-variable]

format specifies type 'long' but the argument has type 'LLONG' (aka 'long long') [-Wformat]
format specifies type 'unsigned long' but the argument has type 'uint64_t' (aka 'unsigned long long') [-Wformat]
implicit conversion from enumeration type 'const vbi_modulation' to different enumeration type 'vbi3_modulation' [-Wenum-conversion]
@mackworth commented on GitHub (Nov 21, 2021): Just FYI, although they are much less problematic, I still see 397 errors during compilation on my Mac. Almost all are `-Wpointer-sign` warnings with many different specific types, but a sample is: ``` passing 'u8 *' (aka 'unsigned char *') to parameter of type 'const char *' converts between pointers to integer types with different sign [-Wpointer-sign] ``` There's also 8 `-Wself-assign` warnings such as ``` explicitly assigning value of variable of type 'const uint8_t *' (aka 'const unsigned char *') to itself [-Wself-assign] ``` and a handful of others: ``` unused function 'cpr1204_crc' [-Wunused-function] unused variable 'last_sub' [-Wunused-variable] format specifies type 'long' but the argument has type 'LLONG' (aka 'long long') [-Wformat] format specifies type 'unsigned long' but the argument has type 'uint64_t' (aka 'unsigned long long') [-Wformat] implicit conversion from enumeration type 'const vbi_modulation' to different enumeration type 'vbi3_modulation' [-Wenum-conversion] ```
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
CEA-708
difficulty: easy
difficulty: hard
difficulty: medium
DTMB
DVB
enhancement
enhancement
Flutter GUI
GCI19
good-first-task
GSoC 2021
GSOC-2023
GSOC-2023
GSOC-2023
GSoC-related
Hacktoberfest
HardsubX
help wanted
invalid
JokerTV
Mac / OSX
more-info-needed
needs-commercial-sponsor
needs-commercial-sponsor
needs-commercial-sponsor
needs-confirmation-of-being-broken
OCR
pull-request
Mirrored from GitHub Pull Request
 Python
regression
Rust
teletext
No Label difficulty: easy Hacktoberfest
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/ccextractor#337
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?