mirror of
https://github.com/CCExtractor/ccextractor.git
synced 2026-02-03 21:23:48 +00:00
[PROPOSAL] Add some Unit Test for CCExtractor #374
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @thefar8 on GitHub (Jan 22, 2018).
Please prefix your issue with one of the following: [BUG], [PROPOSAL], [QUESTION].
CCExtractor version (using the --version parameter preferably) : X.X
In raising this issue, I confirm the following (please check boxes, eg [X]):
My familiarity with the project is as follows (check one, eg [X]):
Necessary information
-autoprogramVideo links
Please make the affected input file available for us (no screenshots, those don't help!). Public links to Dropbox, Google Drive, etc, are all fine. If it is not possible to make it available publicly, send us a private invitation (both Dropbox and Google Drive allow that). In this case we will download the file and upload it to the private developer repository.
Do not upload your file to any location that will require us to sign up or endure a wait list, slow downloads, etc. If your upload expires make sure you keep it active somehow (replace links if needed). Keep in mind that while we go over all tickets some may take a few days, and it's important we have the file available when we actually need it.
Additional information
We need to add some unit test to CCExtractor to make sure things run properly (as the latest unit test commit is a year ago)
PS: Make sure you set an alert in GitHub so you get notifications about your ticket. We may need to ask questions and we do everything inside GitHub's system.
@MatejMecka commented on GitHub (Jan 22, 2018):
This is part of the ccx_testsuite where it's purpose is to Test CCExtractor. There is already an issue there for writing unit tests.
https://github.com/CCExtractor/ccx_testsuite/issues/7
@harrynull commented on GitHub (Jan 22, 2018):
I think that issue is to write unit tests for ccx_testsuite, instead of CCExtractor.
@canihavesomecoffee commented on GitHub (Jan 23, 2018):
Just to be clear:
However, if tests can be added for CCExtractor, why not?
@prateekmedia commented on GitHub (Mar 16, 2023):
@canihavesomecoffee don't we have CI tests of CCExtractor for pull requests already, so what will make unit tests different from that?
@cfsmp3 commented on GitHub (Mar 22, 2023):
Those are integration tests - end to end. But they don't really test individual parts of the code, so when a commit break something all we know from the CI is that something broke :-)
I don't know however how unit tests would work for us, with the huge amount of spaguetti code we've accumulated over the years.
I think we should try to have unit tests for Rust code as we port/rewrite, but I wouldn't bother with the C code.