[BUG][QUESTION] does '-nofc' option (no font color) work #404

Closed
opened 2026-01-29 16:43:08 +00:00 by claunia · 1 comment
Owner

Originally created by @tsmarinov on GitHub (Mar 6, 2018).

Please prefix your issue with one of the following: [BUG], [PROPOSAL], [QUESTION].

CCExtractor version (using the --version parameter preferably) : X.X

In raising this issue, I confirm the following (please check boxes, eg [X] - and delete unchecked ones):

  • I have read and understood the contributors guide.
  • I have checked that the bug-fix I am reporting can be replicated, or that the feature I am suggesting isn't already present.
  • I have checked that the issue I'm posting isn't already reported.
  • I have checked that the issue I'm porting isn't already solved and no duplicates exist in closed issues and in opened issues
  • I have checked the pull requests tab for existing solutions/implementations to my issue/suggestion.
  • I have used the latest available version of CCExtractor to verify this issue exists.

My familiarity with the project is as follows (check one, eg [X] - and delete unchecked ones):

  • I have never used CCExtractor.
  • I have used CCExtractor just a couple of times.
  • I absolutely love CCExtractor, but have not contributed previously.
  • I am an active contributor to CCExtractor.

Necessary information

  • Is this a regression (did it work before)? [ ] NO | [ ] YES - please specify the last known working version
  • What platform did you use? [ ] Windows - [X] Linux - [ ] Mac
  • What were the used arguments? -autoprogram
    ./ccextractor -nofc -in=ts -nobom -trim -noteletext -codec dvbsub -dvblang bul -ocrlang bul animalplanet.ts

**Video links (replace text below with your links) **
https://goo.gl/iMq9QQ
Please make the affected input file available for us (no screenshots, those don't help!). Public links to Dropbox, Google Drive, etc, are all fine. If it is not possible to make it available publicly, send us a private invitation (both Dropbox and Google Drive allow that). In this case we will download the file and upload it to the private developer repository.

Do not upload your file to any location that will require us to sign up or endure a wait list, slow downloads, etc. If your upload expires make sure you keep it active somehow (replace links if needed). Keep in mind that while we go over all tickets some may take a few days, and it's important we have the file available when we actually need it.

Additional information

{issue content here, replace this line with your issue content}

PS: Make sure you set an alert in GitHub so you get notifications about your ticket. We may need to ask questions and we do everything inside GitHub's system.

There is no change in result if i use '-nofc' option with srt output. Font color tags are always presents
Using latest commit f46e3dc

Originally created by @tsmarinov on GitHub (Mar 6, 2018). Please prefix your issue with one of the following: [BUG], [PROPOSAL], [QUESTION]. CCExtractor version (using the --version parameter preferably) : **X.X** **In raising this issue, I confirm the following (please check boxes, eg [X] - and delete unchecked ones):** - [X] I have read and understood the [contributors guide](https://github.com/CCExtractor/ccextractor/blob/master/.github/CONTRIBUTING.md). - [X] I have checked that the bug-fix I am reporting can be replicated, or that the feature I am suggesting isn't already present. - [X] I have checked that the issue I'm posting isn't already reported. - [X] I have checked that the issue I'm porting isn't already solved and no duplicates exist in [closed issues](https://github.com/CCExtractor/ccextractor/issues?q=is%3Aissue+is%3Aclosed) and in [opened issues](https://github.com/CCExtractor/ccextractor/issues) - [X] I have checked the pull requests tab for existing solutions/implementations to my issue/suggestion. - [X] I have used the latest available version of CCExtractor to verify this issue exists. **My familiarity with the project is as follows (check one, eg [X] - and delete unchecked ones):** - [ ] I have never used CCExtractor. - [ ] I have used CCExtractor just a couple of times. - [X] I absolutely love CCExtractor, but have not contributed previously. - [ ] I am an active contributor to CCExtractor. **Necessary information** - Is this a regression (did it work before)? [ ] NO | [ ] YES - *please specify the last known working version* - What platform did you use? [ ] Windows - [X] Linux - [ ] Mac - What were the used arguments? `-autoprogram` ./ccextractor -nofc -in=ts -nobom -trim -noteletext -codec dvbsub -dvblang bul -ocrlang bul animalplanet.ts **Video links (replace text below with your links) ** https://goo.gl/iMq9QQ Please make the affected input file available for us (no screenshots, those don't help!). Public links to Dropbox, Google Drive, etc, are all fine. If it is not possible to make it available publicly, send us a private invitation (both Dropbox and Google Drive allow that). In this case we will download the file and upload it to the private developer repository. Do *not* upload your file to any location that will require us to sign up or endure a wait list, slow downloads, etc. If your upload expires make sure you keep it active somehow (replace links if needed). Keep in mind that while we go over all tickets some may take a few days, and it's important we have the file available when we actually need it. **Additional information** {issue content here, replace this line with your issue content} PS: Make sure you set an alert in GitHub so you get notifications about your ticket. We may need to ask questions and we do everything inside GitHub's system. There is no change in result if i use '-nofc' option with srt output. Font color tags are always presents Using latest commit f46e3dc
Author
Owner

@thealphadollar commented on GitHub (Mar 6, 2018):

I could reproduce the error after installing tesseract "bul" language pack.

The error was caused since there was no check for "nofontcolor" parameter (stored in tlt_config) in the color detection function present in the OCR mode (ocr.c)

587f0b8609/src/lib_ccx/ocr.c (L290)

File: /src/lib_ccx/ocr.c

Adding a check for the parameter would solve the issue.

@thealphadollar commented on GitHub (Mar 6, 2018): I could reproduce the error after installing tesseract "bul" language pack. The error was caused since there was no check for "nofontcolor" parameter (stored in tlt_config) in the color detection function present in the OCR mode (ocr.c) https://github.com/CCExtractor/ccextractor/blob/587f0b86098eae3b6c90356389f1e7f08f065deb/src/lib_ccx/ocr.c#L290 File: /src/lib_ccx/ocr.c Adding a check for the parameter would solve the issue.
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/ccextractor#404