Issue with timing (diagnosed, but not fixed) #459

Closed
opened 2026-01-29 16:44:27 +00:00 by claunia · 3 comments
Owner

Originally created by @diksha90 on GitHub (Oct 27, 2018).

It is known that timing in our CEA-708 is different from the timing of CEA-708 in video player with a difference of a second or so and in general it's not critical error.
But sometimes the timing differs a lot - end of the time goes ahead ~10 seconds or so in different examples. This always happens due to this bug where window is undefined (decoder->current_window == -1) and it's col_count too: line (and line 129). It may be a one line fix or maybe hell with codecs, but I must sleep and somewhere else, so if you want we can fix it together.

ccextractor/src/lib_ccx/ccx_decoders_708.c
Line 1115 in 25a8b53
if (screen_content_changed && !_dtvcc_decoder_has_visible_windows(decoder))

In this line , although we check screen content and works correctly if there is any active window in decoder but current_window many times have value -1 and none of the windows are defined or active in decoder,

which causes above mentioned exception and also we cannot ignore content without defined windows, as I have tested we miss captions.
Therefore either we can store that data until a new window is defined or we can flush screen data before removing window.

This is just one instance , similar solution might be needed for handling this issue in other case .

Originally created by @diksha90 on GitHub (Oct 27, 2018). It is known that timing in our CEA-708 is different from the timing of CEA-708 in video player with a difference of a second or so and in general it's not critical error. But sometimes the timing differs a lot - end of the time goes ahead ~10 seconds or so in different examples. This always happens due to this bug where window is undefined (decoder->current_window == -1) and it's col_count too: line (and line 129). It may be a one line fix or maybe hell with codecs, but I must sleep and somewhere else, so if you want we can fix it together. **ccextractor/src/lib_ccx/ccx_decoders_708.c Line 1115 in 25a8b53 if (screen_content_changed && !_dtvcc_decoder_has_visible_windows(decoder))** In this line , although we check screen content and works correctly if there is any active window in decoder but current_window many times have value -1 and none of the windows are defined or active in decoder, which causes above mentioned exception and also we cannot ignore content without defined windows, as I have tested we miss captions. Therefore either we can store that data until a new window is defined or we can flush screen data before removing window. This is just one instance , similar solution might be needed for handling this issue in other case .
Author
Owner

@anshul1912 commented on GitHub (Oct 27, 2018):

Hi Diksha,

It would be helpful for someone to take your diagnosis and fixed issue.
If you provide video link with and ccextractor command you used to reproduce issue.

Thanks
Anshul Maheshwari

@anshul1912 commented on GitHub (Oct 27, 2018): Hi Diksha, It would be helpful for someone to take your diagnosis and fixed issue. If you provide video link with and ccextractor command you used to reproduce issue. Thanks Anshul Maheshwari
Author
Owner

@saurabhshri commented on GitHub (Oct 28, 2018):

Hi, thanks for posting this, but I am not sure what's the purpose of this bug report. It just contains the text from https://github.com/CCExtractor/ccextractor/issues/641 . Am I missing something?

@saurabhshri commented on GitHub (Oct 28, 2018): Hi, thanks for posting this, but I am not sure what's the purpose of this bug report. It just contains the text from https://github.com/CCExtractor/ccextractor/issues/641 . Am I missing something?
Author
Owner

@cfsmp3 commented on GitHub (Dec 23, 2018):

Closed (duplicate)

@cfsmp3 commented on GitHub (Dec 23, 2018): Closed (duplicate)
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/ccextractor#459