mirror of
https://github.com/CCExtractor/ccextractor.git
synced 2026-02-03 21:23:48 +00:00
[BUG] Segmentation Fault part way through extracting from DVB #491
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @bcb2000 on GitHub (Apr 28, 2019).
CCExtractor version (using the --version parameter preferably) : 0.87
In raising this issue, I confirm the following (please check boxes, eg [X] - and delete unchecked ones):
My familiarity with the project is as follows (check one, eg [X] - and delete unchecked ones):
Necessary information
Video links (replace text below with your links)
http://213.229.121.188/1.srt
http://213.229.121.188/1.ts
Additional information
./buildmethodThe resulting .srt is complete as far as to 11:44.
@thelastpolaris commented on GitHub (Apr 28, 2019):
I can confirm this issue and will look at it in more details soon.
@thelastpolaris commented on GitHub (Apr 28, 2019):
The issue at 11:44 is due to the absence of check whether
last_font_tag_endin ocr.c:662 actually contains text or not. However, I get another SEGFAULT with your file in the middle of processing. Will look at it and commit the changes.@bcb2000 commented on GitHub (Apr 28, 2019):
Thanks for your swift analysis and investigation!
For background, the sample .ts file is the output from Plex, whose source is a HDHomeRun network tuner. I initially thought the issue was related to HD streams (the sample I provided is HD) but I have also seen the same issue with SD streams. From a small sample, it seems that at least half of the .ts files I've grabbed can demonstrate this behaviour in CCExtractor.
I'm happy to provide more samples if required, and will test any published updates against my backlog of .ts files.
Thanks again!
@thelastpolaris commented on GitHub (Apr 30, 2019):
Ok, so I made a pull request with changes that solve the bug you filed, but it doesn't solve all the problems that we have in DVB module. I'm getting a segfault at 33:53 with
free(): invalid next size (normal)description. Kindly ask you to test extensively CCExtractor on your files with DVB. The problem, which you described, should be solved by this commit, but there can be other problems with DVB support. Please, tell me if you will encounter any more segfaults.While waiting for pull request to be pulled to master you can try the new changes by downloading and building CCExtractor from this repo
@bcb2000 commented on GitHub (May 1, 2019):
Thanks again.
My testing is continuing. I have set master and issue_1084 branches away on my full set of 220 .ts files, most (if not all?) seem to have dvb subtitles.
So far, master has processed 190, and had 110 segfaults
issue_1084 has processed 125, and had 1 segfault.
The single segfault for issue_1084 branch is on this file:
http://213.229.121.188/2.ts [836M]
I will post final test results when both versions have processed all files.
@thelastpolaris commented on GitHub (May 1, 2019):
@bcb2000 Thx for testing! It looks like this patch solved most of the issues but let's wait for the end results of your testing. Patch is available in master now.
Also I processed 2.ts file that you provided and got no segfault. Some issues with DVB module look pretty random.
@bcb2000 commented on GitHub (May 2, 2019):
All of my ts files have now been processed by the issue_1084 branch of ccextractor.
master: 129 Segfaults from 220 .ts files. 5 ended abruptly with "Aborted"
fix: 1 Segfault (as previously reported - I tried again and still get a Segfault) 17 "Aborted"
The fix seems very good to me.
On a point of order, would you like me to raise a new bug for the 17 "Aborted" scenarios? There's something not right about the files because ffmpeg also has problems with them (if I use
-c:s copyarguments) and also aborts without completing processing.@thelastpolaris commented on GitHub (May 2, 2019):
@bcb2000 I'm happy to hear that it helped :)
Sure. Please, add sample files with which you get "aborted" scenario to the issue.