mirror of
https://github.com/CCExtractor/ccextractor.git
synced 2026-02-04 05:44:53 +00:00
BUG - not all closed captions are found #598
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @madzarevic on GitHub (Aug 23, 2020).
Originally assigned to: @PunitLodha on GitHub.
CCExtractor version: 0.85 - 0.88 (I checked 0.85, 0.85b, 0.87, 0.88)
In raising this issue, I confirm the following:
I've read all the stuff and did my best to check that this issue is not a duplicate
Necessary information
I confirmed that this problem does not happen in version 0.84 and earlier (I checked 0.79, 0.80, 0.82)
I used Windows 10 64 bit.
I used the following arguments:
--gui_mode_reports -autoprogram -out=srt -bom -latin1 [+input files]
CCExtractor will find the closed captions at the beginning a VOB stream, but at a certain point (e.g. ~6 minute in), it will stop seeing any closed captions. This doesn't happen with all VOBs, but it will happen every time with certain VOBs.
Video links
https://drive.google.com/drive/folders/1gb6zOfPrFQJlCOLslUfTYfaIVEy5kEMK?usp=sharing
Included are sequential vob files of an individual episode of an old TV show and the srt files generated by both version 0.84 and 0.88.
Additional information
If you look at the diff between the 2 srt files. 0.88 produces the same output until entry 213 where there is a discrepancy, and then misses all the entries from 214 to 618
@cfsmp3 commented on GitHub (May 19, 2021):
Closing. @madzarevic feel free to ask the issue to be reopened once a working link is available.
@madzarevic commented on GitHub (May 19, 2021):
@cfsmp3 I ran out of google drive space, and I wasn't sure if anyone would ever investigate this issue after a few months. I have reuploaded the files and updated the link in the original post.
@cfsmp3 commented on GitHub (May 19, 2021):
Reopened.
Alternate download (on my Drive, but it should be stable): https://drive.google.com/drive/folders/1s38ZqpYdGcYUX6d0sBbyjs_EmXfzAu2f?usp=sharing
@PunitLodha I'm tentatively assigning this to you since you are digging into missing captions these days.
@madzarevic commented on GitHub (May 20, 2021):
Turning on debug for EI8-608 messages shows that ccextractor is still seeing all the subtitles, they just don't end up in the final SRT file nor show in the preview window.
Also I verified that for the discrepancy in entry 213, ccextractor 0.84 gets the correct time, and ccextractor 0.88 gets the wrong time before failing to handle all the subsequent captions
@madzarevic commented on GitHub (Sep 13, 2021):
The new versions of CCExtractor (I tested 0.90 and 0.93 with the same results), seem to find all the entries, but the timestamps are wrong compared with the output of the last known version that did not have this problem (0.84)
@PunitLodha commented on GitHub (Sep 17, 2021):
VOB files have multiple chapters. So when a new chapter starts, time resets to 0. Isn't that the correct behaviour?
@cfsmp3 commented on GitHub (Sep 17, 2021):
No :-)
To elaborate a bit. Indeed VOBs may have chapters. They usually do. And they there's two major cases here:
1 - It's a collection of TV episodes or something like that, in which each chapter is one episode and then of course the subtitles are for that episode only. In this case the right way is to just extract that chapter (using whatever DVD decrypt tool we want) and then process that VOB by itself with CCExtractor.
2 - It's a movie, and there's chapters in it that allow the viewer to seek quickly to different places, but those bookmarks are irrelevant for subtitles.
So in both cases, we don't want to reset the timer just because we're starting a new chapter.
@PunitLodha commented on GitHub (Sep 18, 2021):
Oh, ok. I misunderstood that part. Will try to fix it