ignoreptsjumps and fixptsjumps are the same thing #641

New Issue

claunia · 2026-01-29T16:49:52Z

claunia commented

2026-01-29 16:49:52 +00:00

Originally created by @techno-disaster on GitHub (Jun 12, 2021).

ignoreptsjumps and fixptsjumps are the same thing, remove one?

Originally created by @techno-disaster on GitHub (Jun 12, 2021). ignoreptsjumps and fixptsjumps are the [same](https://github.com/CCExtractor/ccextractor/blob/master/src/lib_ccx/params.c#L2117) thing, remove one?

claunia closed this issue

2026-01-29 16:49:52 +00:00

claunia commented

2026-01-29 16:49:53 +00:00

@cfsmp3 commented on GitHub (Mar 22, 2023):

@Techno-Disaster See above

@cfsmp3 commented on GitHub (Mar 22, 2023): @Techno-Disaster See above

claunia commented

2026-01-29 16:49:53 +00:00

@cfsmp3 commented on GitHub (Dec 28, 2025):

After investigating the code, these flags are not duplicates - they are opposites:

Current behavior:

--ignoreptsjumps sets ignore_pts_jumps = true (ignore PTS jumps - default)
--fixptsjumps sets ignore_pts_jumps = false (fix PTS jumps)

From the original C code (when this issue was filed in 2021):

if (strcmp(argv[i], "-ignoreptsjumps") == 0) {
    opt->ignore_pts_jumps = 1;  // IGNORE jumps
}
// -ignoreptsjumps counterpart
if (strcmp(argv[i], "-fixptsjumps") == 0) {
    opt->ignore_pts_jumps = 0;  // FIX jumps
}

The comment // -ignoreptsjumps counterpart shows these were always intended as opposite options.

When to use each:

Flag	Effect	Use case
`--ignoreptsjumps`	Don't fix PTS jumps	Default, works for most files
`--fixptsjumps`	Fix PTS jumps	Use if you experience timeline resets/jumps in output

The flags correctly conflict with each other in the argument parser. Both flags serve valid, distinct purposes.

Closing as not a bug.

@cfsmp3 commented on GitHub (Dec 28, 2025): After investigating the code, these flags are **not duplicates** - they are **opposites**: ### Current behavior: - `--ignoreptsjumps` sets `ignore_pts_jumps = true` (ignore PTS jumps - **default**) - `--fixptsjumps` sets `ignore_pts_jumps = false` (fix PTS jumps) ### From the original C code (when this issue was filed in 2021): ```c if (strcmp(argv[i], "-ignoreptsjumps") == 0) { opt->ignore_pts_jumps = 1; // IGNORE jumps } // -ignoreptsjumps counterpart if (strcmp(argv[i], "-fixptsjumps") == 0) { opt->ignore_pts_jumps = 0; // FIX jumps } ``` The comment `// -ignoreptsjumps counterpart` shows these were always intended as opposite options. ### When to use each: | Flag | Effect | Use case | |------|--------|----------| | `--ignoreptsjumps` | Don't fix PTS jumps | Default, works for most files | | `--fixptsjumps` | Fix PTS jumps | Use if you experience timeline resets/jumps in output | The flags correctly conflict with each other in the argument parser. Both flags serve valid, distinct purposes. Closing as not a bug.

claunia referenced this issue

2026-01-29 17:20:15 +00:00

[PR #1319] Fix 708 timing issue #2096

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/ccextractor#641