Rust panic on malformed input due to unchecked unwrap() calls #893

New Issue

claunia · 2026-01-29T16:56:23Z

claunia commented

2026-01-29 16:56:23 +00:00

Originally created by @THE-Amrit-mahto-05 on GitHub (Jan 7, 2026).

description

The Rust components of CCExtractor contain several unchecked unwrap() calls that can cause user triggerable panics when processing malformed input or invalid command line arguments.

Impact

Malformed CLI arguments or corrupted broadcast data can panic the Rust runtime
This is user-triggerable and causes a denial of service style crash
Affects robustness and reliability of the Rust pipeline

Affected

Rust CLI parser
parser.rs

Unchecked parse().unwrap() in argument handling

Rust Teletext decoder
teletext.rs

decode_hamming_8_4(...).unwrap() and similar unchecked operations on broadcast data

Expected Behavior

Invalid or malformed input should produce a clear error message
Malformed teletext packets should be safely ignored, not crash the process

Originally created by @THE-Amrit-mahto-05 on GitHub (Jan 7, 2026). ### description The Rust components of CCExtractor contain several unchecked unwrap() calls that can cause user triggerable panics when processing malformed input or invalid command line arguments. ### Impact - Malformed CLI arguments or corrupted broadcast data can panic the Rust runtime - This is user-triggerable and causes a denial of service style crash - Affects robustness and reliability of the Rust pipeline ### Affected Rust CLI parser parser.rs - Unchecked parse().unwrap() in argument handling Rust Teletext decoder teletext.rs - decode_hamming_8_4(...).unwrap() and similar unchecked operations on broadcast data ### Expected Behavior - Invalid or malformed input should produce a clear error message - Malformed teletext packets should be safely ignored, not crash the process

claunia closed this issue

2026-01-29 16:56:24 +00:00

claunia commented

2026-01-29 16:56:25 +00:00

@cfsmp3 commented on GitHub (Jan 8, 2026):

Please don't open a ticket for these things - PRs are OK, but issues are for users to report problems. If a developer sees a problem he/she just sends a PR.

@cfsmp3 commented on GitHub (Jan 8, 2026): Please don't open a ticket for these things - PRs are OK, but issues are for users to report problems. If a developer sees a problem he/she just sends a PR.

claunia referenced this issue

2026-01-29 17:23:05 +00:00

[PR #1850] [MERGED] [FIX] -out=spupng with EIA608/teletext: offset values in XML may be not correct #893 #2612

claunia referenced this issue

2026-01-29 17:23:06 +00:00

[PR #1850] [FIX] -out=spupng with EIA608/teletext: offset values in XML may be not correct #893 #2616

claunia referenced this issue

2026-01-29 17:23:23 +00:00

[PR #1892] [CLOSED] [DOCS](mac): document -system-libs build mode for Homebrew compatibility #2680

Sign in to join this conversation.