[PR #51] [MERGED] Fix for mp4 #944

Open
opened 2026-01-29 16:57:31 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/CCExtractor/ccextractor/pull/51
Author: @canihavesomecoffee
Created: 6/22/2014
Status: Merged
Merged: 6/23/2014
Merged by: @cfsmp3

Base: masterHead: mp4


📝 Commits (2)

  • ef7d478 Fix for mp4
  • 86ef6d5 Added a description of fix in changes.txt

📊 Changes

2 files changed (+27 additions, -2 deletions)

View changed files

📝 docs/CHANGES.TXT (+2 -0)
📝 src/gpacmp4/mp4.c (+25 -2)

📄 Description

Fixed the wrong subtitles on the given iphone sample by splitting up the
sample into multiple atoms (if present) instead of just one. Tested
change with a second (already working) sample, nothing broke there.

closes #50


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/CCExtractor/ccextractor/pull/51 **Author:** [@canihavesomecoffee](https://github.com/canihavesomecoffee) **Created:** 6/22/2014 **Status:** ✅ Merged **Merged:** 6/23/2014 **Merged by:** [@cfsmp3](https://github.com/cfsmp3) **Base:** `master` ← **Head:** `mp4` --- ### 📝 Commits (2) - [`ef7d478`](https://github.com/CCExtractor/ccextractor/commit/ef7d4785e0ce824b06f4e098292c94ca2ea641a6) Fix for mp4 - [`86ef6d5`](https://github.com/CCExtractor/ccextractor/commit/86ef6d521e09fb862bb1c1f80d2045485d1d74bc) Added a description of fix in changes.txt ### 📊 Changes **2 files changed** (+27 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `docs/CHANGES.TXT` (+2 -0) 📝 `src/gpacmp4/mp4.c` (+25 -2) </details> ### 📄 Description Fixed the wrong subtitles on the given iphone sample by splitting up the sample into multiple atoms (if present) instead of just one. Tested change with a second (already working) sample, nothing broke there. closes #50 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-29 16:57:31 +00:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/ccextractor#944